public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/104240] New: SLP discovery does not consider swapping comparisons
@ 2022-01-26 12:43 rguenth at gcc dot gnu.org
2022-01-26 12:44 ` [Bug tree-optimization/104240] " rguenth at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-26 12:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104240
Bug ID: 104240
Summary: SLP discovery does not consider swapping comparisons
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: rguenth at gcc dot gnu.org
Target Milestone: ---
The following testcase is not vectorized because of a < vs > operation
mismatch.
void foo (int *c, float *x, float *y)
{
c[0] = x[0] < y[0];
c[1] = y[1] > x[1];
c[2] = x[2] < y[2];
c[3] = x[3] < y[3];
}
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/104240] SLP discovery does not consider swapping comparisons
2022-01-26 12:43 [Bug tree-optimization/104240] New: SLP discovery does not consider swapping comparisons rguenth at gcc dot gnu.org
@ 2022-01-26 12:44 ` rguenth at gcc dot gnu.org
2022-01-26 12:45 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-26 12:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104240
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org
Blocks| |53947
Depends on| |103941
Keywords| |missed-optimization
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
Last reconfirmed| |2022-01-26
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I have a patch.
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53947
[Bug 53947] [meta-bug] vectorizer missed-optimizations
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103941
[Bug 103941] uavgv2qi3_ceil is not used (SLP costing and patterns vs live
stmts)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/104240] SLP discovery does not consider swapping comparisons
2022-01-26 12:43 [Bug tree-optimization/104240] New: SLP discovery does not consider swapping comparisons rguenth at gcc dot gnu.org
2022-01-26 12:44 ` [Bug tree-optimization/104240] " rguenth at gcc dot gnu.org
@ 2022-01-26 12:45 ` rguenth at gcc dot gnu.org
2022-04-19 14:44 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-01-26 12:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104240
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 52292
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52292&action=edit
untested patch
With this patch we then run into PR103941.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/104240] SLP discovery does not consider swapping comparisons
2022-01-26 12:43 [Bug tree-optimization/104240] New: SLP discovery does not consider swapping comparisons rguenth at gcc dot gnu.org
2022-01-26 12:44 ` [Bug tree-optimization/104240] " rguenth at gcc dot gnu.org
2022-01-26 12:45 ` rguenth at gcc dot gnu.org
@ 2022-04-19 14:44 ` rguenth at gcc dot gnu.org
2022-05-02 11:17 ` cvs-commit at gcc dot gnu.org
2022-05-02 11:17 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-04-19 14:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104240
Bug 104240 depends on bug 103941, which changed state.
Bug 103941 Summary: uavgv2qi3_ceil is not used (SLP costing and patterns vs live stmts)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103941
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/104240] SLP discovery does not consider swapping comparisons
2022-01-26 12:43 [Bug tree-optimization/104240] New: SLP discovery does not consider swapping comparisons rguenth at gcc dot gnu.org
` (2 preceding siblings ...)
2022-04-19 14:44 ` rguenth at gcc dot gnu.org
@ 2022-05-02 11:17 ` cvs-commit at gcc dot gnu.org
2022-05-02 11:17 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-05-02 11:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104240
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:
https://gcc.gnu.org/g:41e3db05d697405256b6002d8432955a93d249f1
commit r13-71-g41e3db05d697405256b6002d8432955a93d249f1
Author: Richard Biener <rguenther@suse.de>
Date: Mon May 2 12:01:51 2022 +0200
tree-optimization/104240 - SLP discovery with swapped comparisons
The following extends SLP discovery to handle swapped operands
in comparisons.
2022-05-02 Richard Biener <rguenther@suse.de>
PR tree-optimization/104240
* tree-vect-slp.cc (op1_op0_map): New.
(vect_get_operand_map): Handle compares.
(vect_build_slp_tree_1): Support swapped operands for
tcc_comparison.
* gcc.dg/vect/bb-slp-pr104240.c: New testcase.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug tree-optimization/104240] SLP discovery does not consider swapping comparisons
2022-01-26 12:43 [Bug tree-optimization/104240] New: SLP discovery does not consider swapping comparisons rguenth at gcc dot gnu.org
` (3 preceding siblings ...)
2022-05-02 11:17 ` cvs-commit at gcc dot gnu.org
@ 2022-05-02 11:17 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-05-02 11:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104240
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-02 11:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 12:43 [Bug tree-optimization/104240] New: SLP discovery does not consider swapping comparisons rguenth at gcc dot gnu.org
2022-01-26 12:44 ` [Bug tree-optimization/104240] " rguenth at gcc dot gnu.org
2022-01-26 12:45 ` rguenth at gcc dot gnu.org
2022-04-19 14:44 ` rguenth at gcc dot gnu.org
2022-05-02 11:17 ` cvs-commit at gcc dot gnu.org
2022-05-02 11:17 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).