public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/104314] New: ICE in deferred_op_assign, at fortran/resolve.cc:11794
@ 2022-01-31 20:03 gscfq@t-online.de
2022-01-31 20:14 ` [Bug fortran/104314] " kargl at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: gscfq@t-online.de @ 2022-01-31 20:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104314
Bug ID: 104314
Summary: ICE in deferred_op_assign, at fortran/resolve.cc:11794
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
Assignee: unassigned at gcc dot gnu.org
Reporter: gscfq@t-online.de
Target Milestone: ---
Affects versions down to at least r5 :
$ cat z1.f90
program p
character(:), allocatable :: c(:)
c = ['123']
c = c == c
end
$ gfortran-12-20220130 -c z1.f90
z1.f90:4:7:
4 | c = c == c
| 1
Error: Cannot convert LOGICAL(4) to CHARACTER(0) at (1)
f951: internal compiler error: Segmentation fault
0xe6e49f crash_signal
../../gcc/toplev.cc:322
0x7a979c deferred_op_assign
../../gcc/fortran/resolve.cc:11794
0x7a979c gfc_resolve_code(gfc_code*, gfc_namespace*)
../../gcc/fortran/resolve.cc:12063
0x7a98e7 resolve_codes
../../gcc/fortran/resolve.cc:17537
0x7a99ae gfc_resolve(gfc_namespace*)
../../gcc/fortran/resolve.cc:17572
0x791cd4 resolve_all_program_units
../../gcc/fortran/parse.cc:6586
0x791cd4 gfc_parse_file()
../../gcc/fortran/parse.cc:6842
0x7dff7f gfc_be_parse_file
../../gcc/fortran/f95-lang.cc:216
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug fortran/104314] ICE in deferred_op_assign, at fortran/resolve.cc:11794
2022-01-31 20:03 [Bug fortran/104314] New: ICE in deferred_op_assign, at fortran/resolve.cc:11794 gscfq@t-online.de
@ 2022-01-31 20:14 ` kargl at gcc dot gnu.org
2022-01-31 21:17 ` sgk at troutmask dot apl.washington.edu
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: kargl at gcc dot gnu.org @ 2022-01-31 20:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104314
kargl at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
CC| |kargl at gcc dot gnu.org
Priority|P3 |P4
Ever confirmed|0 |1
Last reconfirmed| |2022-01-31
--- Comment #1 from kargl at gcc dot gnu.org ---
Untested patch.
diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index 835a4783718..d18404da09d 100644
--- a/gcc/fortran/resolve.cc
+++ b/gcc/fortran/resolve.cc
@@ -11784,6 +11784,9 @@ deferred_op_assign (gfc_code **code, gfc_namespace *ns)
if (gfc_expr_attr ((*code)->expr1).pointer)
return false;
+ if ((*code)->expr1->ts.type != (*code)->expr2->ts.type)
+ return false;
+
tmp_expr = get_temp_from_expr ((*code)->expr1, ns);
tmp_expr->where = (*code)->loc;
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug fortran/104314] ICE in deferred_op_assign, at fortran/resolve.cc:11794
2022-01-31 20:03 [Bug fortran/104314] New: ICE in deferred_op_assign, at fortran/resolve.cc:11794 gscfq@t-online.de
2022-01-31 20:14 ` [Bug fortran/104314] " kargl at gcc dot gnu.org
@ 2022-01-31 21:17 ` sgk at troutmask dot apl.washington.edu
2022-09-05 21:00 ` anlauf at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: sgk at troutmask dot apl.washington.edu @ 2022-01-31 21:17 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104314
--- Comment #2 from Steve Kargl <sgk at troutmask dot apl.washington.edu> ---
On Mon, Jan 31, 2022 at 08:14:39PM +0000, kargl at gcc dot gnu.org wrote:
>
> --- Comment #1 from kargl at gcc dot gnu.org ---
> Untested patch.
>
Seems to pass regression testing.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug fortran/104314] ICE in deferred_op_assign, at fortran/resolve.cc:11794
2022-01-31 20:03 [Bug fortran/104314] New: ICE in deferred_op_assign, at fortran/resolve.cc:11794 gscfq@t-online.de
2022-01-31 20:14 ` [Bug fortran/104314] " kargl at gcc dot gnu.org
2022-01-31 21:17 ` sgk at troutmask dot apl.washington.edu
@ 2022-09-05 21:00 ` anlauf at gcc dot gnu.org
2022-09-15 20:15 ` cvs-commit at gcc dot gnu.org
2022-09-15 20:24 ` anlauf at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2022-09-05 21:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104314
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anlauf at gcc dot gnu.org
--- Comment #3 from anlauf at gcc dot gnu.org ---
(In reply to kargl from comment #1)
> Untested patch.
Yes, that works. Even shorter:
diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index ca114750f65..3834f9a3f06 100644
--- a/gcc/fortran/resolve.cc
+++ b/gcc/fortran/resolve.cc
@@ -11803,6 +11803,7 @@ deferred_op_assign (gfc_code **code, gfc_namespace *ns)
if (!((*code)->expr1->ts.type == BT_CHARACTER
&& (*code)->expr1->ts.deferred && (*code)->expr1->rank
+ && (*code)->expr2->ts.type == BT_CHARACTER
&& (*code)->expr2->expr_type == EXPR_OP))
return false;
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug fortran/104314] ICE in deferred_op_assign, at fortran/resolve.cc:11794
2022-01-31 20:03 [Bug fortran/104314] New: ICE in deferred_op_assign, at fortran/resolve.cc:11794 gscfq@t-online.de
` (2 preceding siblings ...)
2022-09-05 21:00 ` anlauf at gcc dot gnu.org
@ 2022-09-15 20:15 ` cvs-commit at gcc dot gnu.org
2022-09-15 20:24 ` anlauf at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-09-15 20:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104314
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:7bd4deb2a7c1394550610ab27507d1ed2af817c2
commit r13-2690-g7bd4deb2a7c1394550610ab27507d1ed2af817c2
Author: Harald Anlauf <anlauf@gmx.de>
Date: Thu Sep 15 22:06:53 2022 +0200
Fortran: error recovery for bad deferred character length assignment
[PR104314]
gcc/fortran/ChangeLog:
PR fortran/104314
* resolve.cc (deferred_op_assign): Do not try to generate temporary
for deferred character length assignment if types do not agree.
gcc/testsuite/ChangeLog:
PR fortran/104314
* gfortran.dg/pr104314.f90: New test.
Co-authored-by: Steven G. Kargl <kargl@gcc.gnu.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug fortran/104314] ICE in deferred_op_assign, at fortran/resolve.cc:11794
2022-01-31 20:03 [Bug fortran/104314] New: ICE in deferred_op_assign, at fortran/resolve.cc:11794 gscfq@t-online.de
` (3 preceding siblings ...)
2022-09-15 20:15 ` cvs-commit at gcc dot gnu.org
@ 2022-09-15 20:24 ` anlauf at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: anlauf at gcc dot gnu.org @ 2022-09-15 20:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104314
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #5 from anlauf at gcc dot gnu.org ---
Fixed on mainline. Closing.
Thanks for the report!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-15 20:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-31 20:03 [Bug fortran/104314] New: ICE in deferred_op_assign, at fortran/resolve.cc:11794 gscfq@t-online.de
2022-01-31 20:14 ` [Bug fortran/104314] " kargl at gcc dot gnu.org
2022-01-31 21:17 ` sgk at troutmask dot apl.washington.edu
2022-09-05 21:00 ` anlauf at gcc dot gnu.org
2022-09-15 20:15 ` cvs-commit at gcc dot gnu.org
2022-09-15 20:24 ` anlauf at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).