[Bug fortran/104352] New: ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[Bug fortran/104352] New: ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104352

            Bug ID: 104352
           Summary: ICE in gfc_conv_intrinsic_anyall, at
                    fortran/trans-intrinsic.cc:4481 (etc.)
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Affects versions down to at least r5 :


$ cat z1.f90
program p
   integer, parameter :: a(0) = 1
   print *, any(a(1:1) == 1)
end

$ cat z2.f90
program p
   integer, parameter :: a(0) = 1
   print *, any(a(:1) == 1)
end


$ cat z3.f90
program p
   integer, parameter :: a(0) = 1
   print *, any(a(0:0) == 1)
end


$ cat z4.f90
program p
   integer, parameter :: a(0) = 1
   print *, any(a(0:1) == 1)
end


$ gfortran-12-20220130 -c z1.f90
z1.f90:3:18:

    3 |    print *, any(a(1:1) == 1)
      |                  1
Warning: Lower array reference at (1) is out of bounds (1 > 0) in dimension 1
z1.f90:3:18:

    3 |    print *, any(a(1:1) == 1)
      |                  1
Warning: Lower array reference at (1) is out of bounds (1 > 0) in dimension 1
z1.f90:3:28:

    3 |    print *, any(a(1:1) == 1)
      |                            1
internal compiler error: in gfc_conv_intrinsic_anyall, at
fortran/trans-intrinsic.cc:4481
0x7f5fb3 gfc_conv_intrinsic_anyall
        ../../gcc/fortran/trans-intrinsic.cc:4481
0x802c56 gfc_conv_intrinsic_anyall
        ../../gcc/fortran/trans-intrinsic.cc:4463
0x802c56 gfc_conv_intrinsic_function(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-intrinsic.cc:10228
0x7d6dba gfc_conv_expr(gfc_se*, gfc_expr*)
        ../../gcc/fortran/trans-expr.cc:9398
0x7de952 gfc_conv_expr_reference(gfc_se*, gfc_expr*, bool)
        ../../gcc/fortran/trans-expr.cc:9544
0x808f57 gfc_trans_transfer(gfc_code*)
        ../../gcc/fortran/trans-io.cc:2581
0x7a6067 trans_code
        ../../gcc/fortran/trans.cc:2136
0x806a3e build_dt
        ../../gcc/fortran/trans-io.cc:2025
0x7a6047 trans_code
        ../../gcc/fortran/trans.cc:2108
0x7cf19e gfc_generate_function_code(gfc_namespace*)
        ../../gcc/fortran/trans-decl.cc:7654
0x751efe translate_all_program_units
        ../../gcc/fortran/parse.cc:6651
0x751efe gfc_parse_file()
        ../../gcc/fortran/parse.cc:6938
0x79eecf gfc_be_parse_file
        ../../gcc/fortran/f95-lang.cc:216

[Bug fortran/104352] ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104352

G. Steinmetz <gscfq@t-online.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code

--- Comment #1 from G. Steinmetz <gscfq@t-online.de> ---

Intrinsic "any" in above test files can be replaced with e.g.

$ cat za1.f90
program p
   integer, parameter :: a(0) = 1
   print *, all(a(1:1) == 1)
   print *, any(a(1:1) == 1)
   print *, count(a(1:1) == 1)
   print *, is_contiguous(a(1:1) == 1)
   print *, parity(a(1:1) == 1)
   print *, shape(a(1:1) == 1)
   print *, size(a(1:1) == 1)
   print *, ubound(a(1:1) == 1)
end


Other variants also affect intrinsics like iany, iall, ...

$ cat zb1.f90
program p
   integer, parameter :: a(0) = 1
   print *, iall(a(1:1))
   print *, iany(a(1:1))
   print *, iparity(a(1:1))
   print *, maxval(a(1:1))
   print *, minval(a(1:1))
   print *, product(a(1:1))
   print *, sum(a(1:1))
end


Another modification pattern hits minloc, macloc, ...

$ cat zc1.f90
program p
   integer, parameter :: a(0) = 1
   print *, ibclr(a(1:1), 1)
   print *, ibset(a(1:1), 1)
   print *, max(a(1:1), 1)
   print *, max0(a(1:1), 1)
   print *, maxloc(a(1:1), 1)
   print *, min(a(1:1), 1)
   print *, min0(a(1:1), 1)
   print *, minloc(a(1:1), 1)
end


or ...

$ cat zd1.f90
program p
   real, parameter :: a(0) = 1
   print *, dot_product(a(1:1), a(1:1))
   print *, norm2(a(1:1))
end
subroutine s
   complex, parameter :: a(0) = 1
   print *, dot_product(a(1:1), a(1:1))
   print *, conjg(a(1:1))
end

[Bug fortran/104352] ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[kargl at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104352

kargl at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-05-25
           Priority|P3                          |P4
     Ever confirmed|0                           |1
                 CC|                            |kargl at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #2 from kargl at gcc dot gnu.org ---
It make absolutely no sense to emit a warning when gfortran
detects an out-of-bounds array index.  This patch fixes the
ICE and fixes the second error message to report that it is
the upper bound not the lower bound that errors out.

diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index 2ebf076f730..52a394db26a 100644
--- a/gcc/fortran/resolve.cc
+++ b/gcc/fortran/resolve.cc
@@ -4754,19 +4754,19 @@ check_dimension (int i, gfc_array_ref *ar,
gfc_array_spec *as)
          {
            if (compare_bound (AR_START, as->lower[i]) == CMP_LT)
              {
-               gfc_warning (0, "Lower array reference at %L is out of bounds "
+               gfc_error ("Lower array reference at %L is out of bounds "
                       "(%ld < %ld) in dimension %d", &ar->c_where[i],
                       mpz_get_si (AR_START->value.integer),
                       mpz_get_si (as->lower[i]->value.integer), i+1);
-               return true;
+               return false;
              }
            if (compare_bound (AR_START, as->upper[i]) == CMP_GT)
              {
-               gfc_warning (0, "Lower array reference at %L is out of bounds "
+               gfc_error ("Upper array reference at %L is out of bounds "
                       "(%ld > %ld) in dimension %d", &ar->c_where[i],
                       mpz_get_si (AR_START->value.integer),
                       mpz_get_si (as->upper[i]->value.integer), i+1);
-               return true;
+               return false;
              }
          }

[Bug fortran/104352] ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104352

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
There are also other PRs with ICEs and array bounds violation which might
be fixed by turning warnings into errors.

The patch in comment#2 misses another pair of checks in check_dimension
that need to be adjusted, including the mixup Lower <-> Upper.

However, the resulting modification leads to regressions in the following
testcases:

gfortran.dg/bounds_check_3.f90
gfortran.dg/bounds_check_11.f90
gfortran.dg/goacc/subarrays.f95
gfortran.dg/gomp/map-1.f90

I think we need to know which kind of abuse of array indices we want to
accept for legacy code, of which there might be plenty in the wild.

Potential candidates where there should be no error, maybe even no warning:

- assumed-size arrays
- arrays whose last dimension is 1 (only for -std=legacy (?))

[Bug fortran/104352] ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104352

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:7bafe652dba9167b65e7b5ef24e77eceb49709ba

commit r14-950-g7bafe652dba9167b65e7b5ef24e77eceb49709ba
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed May 17 20:39:18 2023 +0200

    Fortran: set shape of initializers of zero-sized arrays [PR95374,PR104352]

    gcc/fortran/ChangeLog:

            PR fortran/95374
            PR fortran/104352
            * decl.cc (add_init_expr_to_sym): Set shape of initializer also for
            zero-sized arrays, so that bounds violations can be detected later.

    gcc/testsuite/ChangeLog:

            PR fortran/95374
            PR fortran/104352
            * gfortran.dg/zero_sized_13.f90: New test.

[Bug fortran/104352] ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104352

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|---                         |14.0
         Resolution|---                         |FIXED

--- Comment #5 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-14.  Closing.

Thanks for the report!

[Bug fortran/104352] ICE in gfc_conv_intrinsic_anyall, at fortran/trans-intrinsic.cc:4481 (etc.)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104352

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:0dd82c0fba660775ff76ae27077a67f2f1358920

commit r13-8557-g0dd82c0fba660775ff76ae27077a67f2f1358920
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed May 17 20:39:18 2023 +0200

    Fortran: set shape of initializers of zero-sized arrays [PR95374,PR104352]

    gcc/fortran/ChangeLog:

            PR fortran/95374
            PR fortran/104352
            * decl.cc (add_init_expr_to_sym): Set shape of initializer also for
            zero-sized arrays, so that bounds violations can be detected later.

    gcc/testsuite/ChangeLog:

            PR fortran/95374
            PR fortran/104352
            * gfortran.dg/zero_sized_13.f90: New test.

    (cherry picked from commit 7bafe652dba9167b65e7b5ef24e77eceb49709ba)