[Bug middle-end/104449] New: [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[Bug middle-end/104449] New: [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

            Bug ID: 104449
           Summary: [9/10/11/12 Regression] ICE: verify_gimple failed:
                    dead statement in EH table with -fexceptions
                    -fsanitize=address -fstack-check=generic
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 52378
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52378&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -fexceptions -fsanitize=address -fstack-check=generic
testcase.c
testcase.c: In function 'foo':
testcase.c:2:1: error: dead statement in EH table
    2 | foo (void)
      | ^~~
# _4 = VDEF <.MEM_2>
_5 = __builtin_alloca_with_align (64, 32);
during GIMPLE pass: asan0
testcase.c:2:1: internal compiler error: verify_gimple failed
0x13d156d verify_gimple_in_cfg(function*, bool)
        /repo/gcc-trunk/gcc/tree-cfg.cc:5561
0x127adc7 execute_function_todo
        /repo/gcc-trunk/gcc/passes.cc:2084
0x127b2fe execute_todo
        /repo/gcc-trunk/gcc/passes.cc:2138
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r12-7089-20220208123931-g0103c2e4082-checking-yes-rtl-df-extra-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
--with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r12-7089-20220208123931-g0103c2e4082-checking-yes-rtl-df-extra-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.1 20220208 (experimental) (GCC)

[Bug middle-end/104449] [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Target Milestone|---                         |9.5
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-02-08

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed. With -fstack-check=generic, __builtin_alloca_with_align is marked as
being able to throw but asan decides to insert its annonations right after the
builtin call instead of on the branch after the function call.

[Bug middle-end/104449] [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug middle-end/104449] [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r8-1884-ge3174bdf35c172f69daf08350401aa177f8f1498

[Bug middle-end/104449] [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
C++ testcase that ICEs with such options even at -O2:
void bar (int *);
struct A { A (); ~A (); };

void
foo (int n)
{
  A b;
  {
    int a[n];
    bar (a);
  }
}

[Bug sanitizer/104449] [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52421
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52421&action=edit
gcc12-pr104449.patch

Untested fix.

[Bug sanitizer/104449] [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[ebotcazou at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org

--- Comment #5 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
> Confirmed. With -fstack-check=generic, __builtin_alloca_with_align is marked
> as being able to throw but asan decides to insert its annonations right
> after the builtin call instead of on the branch after the function call.

With any -fstack-check option to be exact:

  /* If we're checking the stack, `alloca' can throw.  */
  const int alloca_flags
    = ECF_MALLOC | ECF_LEAF | (flag_stack_check ? 0 : ECF_NOTHROW);

[Bug sanitizer/104449] [9/10/11/12 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:f0c7367b8802c47efaad87b1f2126fe6350d8b47

commit r12-7214-gf0c7367b8802c47efaad87b1f2126fe6350d8b47
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Feb 12 19:17:44 2022 +0100

    asan: Fix up address sanitizer instrumentation of __builtin_alloca* if it
can throw [PR104449]

    With -fstack-check* __builtin_alloca* can throw and the asan
    instrumentation of this builtin wasn't prepared for that case.
    The following patch fixes that by replacing the builtin with the
    replacement builtin and emitting any further insns on the fallthru
    edge.

    I haven't touched the hwasan code which most likely suffers from the
    same problem.

    2022-02-12  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/104449
            * asan.cc: Include tree-eh.h.
            (handle_builtin_alloca): Handle the case when __builtin_alloca or
            __builtin_alloca_with_align can throw.

            * gcc.dg/asan/pr104449.c: New test.
            * g++.dg/asan/pr104449.C: New test.

[Bug sanitizer/104449] [9/10/11 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11/12 Regression]     |[9/10/11 Regression] ICE:
                   |ICE: verify_gimple failed:  |verify_gimple failed: dead
                   |dead statement in EH table  |statement in EH table with
                   |with -fexceptions           |-fexceptions
                   |-fsanitize=address          |-fsanitize=address
                   |-fstack-check=generic       |-fstack-check=generic

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug sanitizer/104449] [9/10/11 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:8a97d7bdb38285a7954f67172013098b61548870

commit r11-9604-g8a97d7bdb38285a7954f67172013098b61548870
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Feb 12 19:17:44 2022 +0100

    asan: Fix up address sanitizer instrumentation of __builtin_alloca* if it
can throw [PR104449]

    With -fstack-check* __builtin_alloca* can throw and the asan
    instrumentation of this builtin wasn't prepared for that case.
    The following patch fixes that by replacing the builtin with the
    replacement builtin and emitting any further insns on the fallthru
    edge.

    I haven't touched the hwasan code which most likely suffers from the
    same problem.

    2022-02-12  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/104449
            * asan.c: Include tree-eh.h.
            (handle_builtin_alloca): Handle the case when __builtin_alloca or
            __builtin_alloca_with_align can throw.

            * gcc.dg/asan/pr104449.c: New test.
            * g++.dg/asan/pr104449.C: New test.

    (cherry picked from commit f0c7367b8802c47efaad87b1f2126fe6350d8b47)

[Bug sanitizer/104449] [9/10 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11 Regression] ICE:   |[9/10 Regression] ICE:
                   |verify_gimple failed: dead  |verify_gimple failed: dead
                   |statement in EH table with  |statement in EH table with
                   |-fexceptions                |-fexceptions
                   |-fsanitize=address          |-fsanitize=address
                   |-fstack-check=generic       |-fstack-check=generic

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.3+ too.

[Bug sanitizer/104449] [9/10 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449
Bug 104449 depends on bug 105214, which changed state.

Bug 105214 Summary: [12 Regression] ICE: in connect_traces, at dwarf2cfi.cc:3074 with custom flags
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105214

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

[Bug sanitizer/104449] [9/10 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:f5b1fcfd69c7a09f661ebec1341f3df34aec4ead

commit r10-10679-gf5b1fcfd69c7a09f661ebec1341f3df34aec4ead
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Feb 12 19:17:44 2022 +0100

    asan: Fix up address sanitizer instrumentation of __builtin_alloca* if it
can throw [PR104449]

    With -fstack-check* __builtin_alloca* can throw and the asan
    instrumentation of this builtin wasn't prepared for that case.
    The following patch fixes that by replacing the builtin with the
    replacement builtin and emitting any further insns on the fallthru
    edge.

    I haven't touched the hwasan code which most likely suffers from the
    same problem.

    2022-02-12  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/104449
            * asan.c: Include tree-eh.h.
            (handle_builtin_alloca): Handle the case when __builtin_alloca or
            __builtin_alloca_with_align can throw.

            * gcc.dg/asan/pr104449.c: New test.
            * g++.dg/asan/pr104449.C: New test.

    (cherry picked from commit f0c7367b8802c47efaad87b1f2126fe6350d8b47)

[Bug sanitizer/104449] [9/10 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:77ee9b906d1c214648230d417b45831b8ef8386a

commit r9-10127-g77ee9b906d1c214648230d417b45831b8ef8386a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Feb 12 19:17:44 2022 +0100

    asan: Fix up address sanitizer instrumentation of __builtin_alloca* if it
can throw [PR104449]

    With -fstack-check* __builtin_alloca* can throw and the asan
    instrumentation of this builtin wasn't prepared for that case.
    The following patch fixes that by replacing the builtin with the
    replacement builtin and emitting any further insns on the fallthru
    edge.

    I haven't touched the hwasan code which most likely suffers from the
    same problem.

    2022-02-12  Jakub Jelinek  <jakub@redhat.com>

            PR sanitizer/104449
            * asan.c: Include tree-eh.h.
            (handle_builtin_alloca): Handle the case when __builtin_alloca or
            __builtin_alloca_with_align can throw.

            * gcc.dg/asan/pr104449.c: New test.
            * g++.dg/asan/pr104449.C: New test.

    (cherry picked from commit f0c7367b8802c47efaad87b1f2126fe6350d8b47)

[Bug sanitizer/104449] [9/10 Regression] ICE: verify_gimple failed: dead statement in EH table with -fexceptions -fsanitize=address -fstack-check=generic

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104449

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.