[Bug tree-optimization/104510] New: ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[Bug tree-optimization/104510] New: ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

            Bug ID: 104510
           Summary: ICE: 'verify_gimple' failed: mismatching comparison
                    operand types in verify_gimple_in_seq()
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 52424
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52424&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc testcase.c
testcase.c: In function 'foo':
testcase.c:5:1: error: mismatching comparison operand types
    5 | foo (void)
      | ^~~
_Decimal32
_Decimal64
_4 = _2 < d.1_3;
testcase.c:5:1: internal compiler error: 'verify_gimple' failed
0x13e08fd verify_gimple_in_seq(gimple*)
        /repo/gcc-trunk/gcc/tree-cfg.cc:5213
0x1092686 gimplify_body(tree_node*, bool)
        /repo/gcc-trunk/gcc/gimplify.cc:16302
0x10927dd gimplify_function_tree(tree_node*)
        /repo/gcc-trunk/gcc/gimplify.cc:16373
0xeb6837 cgraph_node::analyze()
        /repo/gcc-trunk/gcc/cgraphunit.cc:675
0xeb94a7 analyze_functions
        /repo/gcc-trunk/gcc/cgraphunit.cc:1240
0xeba14d symbol_table::finalize_compilation_unit()
        /repo/gcc-trunk/gcc/cgraphunit.cc:2500
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r12-7210-20220212001623-ge8d68f0a456-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r12-7210-20220212001623-ge8d68f0a456-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.1 20220212 (experimental) (GCC)

[Bug c/104510] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-02-13
             Status|UNCONFIRMED                 |NEW
          Component|tree-optimization           |c
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
It works with the C++ front-end:
float f;
typedef float t32 __attribute__((mode(SD)));
typedef float t64 __attribute__((mode(DD)));
t64 d;
int
foo (void)
{
  return d > (t32) (t64) f;
}

[Bug c/104510] [9/10/11/12 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |5.1.0
            Summary|ICE: 'verify_gimple'        |[9/10/11/12 Regression]
                   |failed: mismatching         |ICE: 'verify_gimple'
                   |comparison operand types in |failed: mismatching
                   |verify_gimple_in_seq()      |comparison operand types in
                   |                            |verify_gimple_in_seq()
      Known to work|                            |4.9.0, 4.9.4
   Target Milestone|---                         |9.5

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This is a regression from GCC 4.9.0 which produced the correct trees even:


In GCC 5+:
  return (_Decimal32) f < d;


While in GCC 4.9.x:
  return (_Decimal64) f < (_Decimal64) d;

[Bug c/104510] [9/10/11/12 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug c/104510] [9/10/11/12 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Started with r5-4736-g1e51d0a29dbfebe6c0df58739562644c1a50f3c3

[Bug c/104510] [9/10/11/12 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52439
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52439&action=edit
gcc12-pr104510.patch

Untested fix.  Callers don't expect shorten_compare to ever fail, even when it
returns NULL it still should convert arguments at least to the original
*restype_ptr.

[Bug c/104510] [9/10/11/12 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:6e74122f0de6748b3fd0ed9183090cd7c61fb53e

commit r12-7256-g6e74122f0de6748b3fd0ed9183090cd7c61fb53e
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Feb 16 09:25:55 2022 +0100

    c-family: Fix up shorten_compare for decimal vs. non-decimal float
comparison [PR104510]

    The comment in shorten_compare says:
      /* If either arg is decimal float and the other is float, fail.  */
    but the callers of shorten_compare don't expect anything like failure
    as a possibility from the function, callers require that the function
    promotes the operands to the same type, whether the original selected
    *restype_ptr one or some shortened.
    So, if we choose not to shorten, we should still promote to the original
    *restype_ptr.

    2022-02-16  Jakub Jelinek  <jakub@redhat.com>

            PR c/104510
            * c-common.cc (shorten_compare): Convert original arguments to
            the original *restype_ptr when mixing binary and decimal float.

            * gcc.dg/dfp/pr104510.c: New test.

[Bug c/104510] [9/10/11 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11/12 Regression]     |[9/10/11 Regression] ICE:
                   |ICE: 'verify_gimple'        |'verify_gimple' failed:
                   |failed: mismatching         |mismatching comparison
                   |comparison operand types in |operand types in
                   |verify_gimple_in_seq()      |verify_gimple_in_seq()

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug c/104510] [9/10/11 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:3a543eb7982ae6ccfb6ea2027ad4c71d5fcaf92a

commit r11-9608-g3a543eb7982ae6ccfb6ea2027ad4c71d5fcaf92a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Feb 16 09:25:55 2022 +0100

    c-family: Fix up shorten_compare for decimal vs. non-decimal float
comparison [PR104510]

    The comment in shorten_compare says:
      /* If either arg is decimal float and the other is float, fail.  */
    but the callers of shorten_compare don't expect anything like failure
    as a possibility from the function, callers require that the function
    promotes the operands to the same type, whether the original selected
    *restype_ptr one or some shortened.
    So, if we choose not to shorten, we should still promote to the original
    *restype_ptr.

    2022-02-16  Jakub Jelinek  <jakub@redhat.com>

            PR c/104510
            * c-common.c (shorten_compare): Convert original arguments to
            the original *restype_ptr when mixing binary and decimal float.

            * gcc.dg/dfp/pr104510.c: New test.

    (cherry picked from commit 6e74122f0de6748b3fd0ed9183090cd7c61fb53e)

[Bug c/104510] [9/10 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[9/10/11 Regression] ICE:   |[9/10 Regression] ICE:
                   |'verify_gimple' failed:     |'verify_gimple' failed:
                   |mismatching comparison      |mismatching comparison
                   |operand types in            |operand types in
                   |verify_gimple_in_seq()      |verify_gimple_in_seq()

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.3+ too.

[Bug c/104510] [9/10 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:83aea9cb28f729698a79e4262ef3a43a0fd79d4f

commit r10-10683-g83aea9cb28f729698a79e4262ef3a43a0fd79d4f
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Feb 16 09:25:55 2022 +0100

    c-family: Fix up shorten_compare for decimal vs. non-decimal float
comparison [PR104510]

    The comment in shorten_compare says:
      /* If either arg is decimal float and the other is float, fail.  */
    but the callers of shorten_compare don't expect anything like failure
    as a possibility from the function, callers require that the function
    promotes the operands to the same type, whether the original selected
    *restype_ptr one or some shortened.
    So, if we choose not to shorten, we should still promote to the original
    *restype_ptr.

    2022-02-16  Jakub Jelinek  <jakub@redhat.com>

            PR c/104510
            * c-common.c (shorten_compare): Convert original arguments to
            the original *restype_ptr when mixing binary and decimal float.

            * gcc.dg/dfp/pr104510.c: New test.

    (cherry picked from commit 6e74122f0de6748b3fd0ed9183090cd7c61fb53e)

[Bug c/104510] [9/10 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b65f562b8f203948ebe1c09d9710184b0a2052bb

commit r9-10131-gb65f562b8f203948ebe1c09d9710184b0a2052bb
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Feb 16 09:25:55 2022 +0100

    c-family: Fix up shorten_compare for decimal vs. non-decimal float
comparison [PR104510]

    The comment in shorten_compare says:
      /* If either arg is decimal float and the other is float, fail.  */
    but the callers of shorten_compare don't expect anything like failure
    as a possibility from the function, callers require that the function
    promotes the operands to the same type, whether the original selected
    *restype_ptr one or some shortened.
    So, if we choose not to shorten, we should still promote to the original
    *restype_ptr.

    2022-02-16  Jakub Jelinek  <jakub@redhat.com>

            PR c/104510
            * c-common.c (shorten_compare): Convert original arguments to
            the original *restype_ptr when mixing binary and decimal float.

            * gcc.dg/dfp/pr104510.c: New test.

    (cherry picked from commit 6e74122f0de6748b3fd0ed9183090cd7c61fb53e)

[Bug c/104510] [9/10 Regression] ICE: 'verify_gimple' failed: mismatching comparison operand types in verify_gimple_in_seq()

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104510

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.