public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter
Date: Tue, 15 Feb 2022 09:25:24 +0000	[thread overview]
Message-ID: <bug-104517-4-jrtdHf5vQI@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104517-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:6a0d6e7ca9b9e338e82572db79c26168684a7441

commit r12-7237-g6a0d6e7ca9b9e338e82572db79c26168684a7441
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 15 10:22:30 2022 +0100

    openmp: Make finalize_task_copyfn order reproduceable [PR104517]

    The following testcase fails -fcompare-debug, because finalize_task_copyfn
    was invoked from splay tree destruction, whose order can in some cases
    depend on -g/-g0.  The fix is to queue the task stmts that need copyfn
    in a vector and run finalize_task_copyfn on elements of that vector.

    2022-02-15  Jakub Jelinek  <jakub@redhat.com>

            PR debug/104517
            * omp-low.cc (task_cpyfns): New variable.
            (delete_omp_context): Don't call finalize_task_copyfn from here.
            (create_task_copyfn): Push task_stmt into task_cpyfns.
            (execute_lower_omp): Call finalize_task_copyfn here on entries from
            task_cpyfns vector and release the vector.

            * gcc.dg/gomp/pr104517.c: New test.

  parent reply	other threads:[~2022-02-15  9:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-13  6:48 [Bug debug/104517] New: " asolokha at gmx dot com
2022-02-13  6:49 ` [Bug debug/104517] " asolokha at gmx dot com
2022-02-13 23:11 ` pinskia at gcc dot gnu.org
2022-02-13 23:43 ` asolokha at gmx dot com
2022-02-13 23:53 ` pinskia at gcc dot gnu.org
2022-02-14 13:01 ` jakub at gcc dot gnu.org
2022-02-15  9:25 ` cvs-commit at gcc dot gnu.org [this message]
2022-02-19  8:03 ` cvs-commit at gcc dot gnu.org
2022-05-10  8:24 ` cvs-commit at gcc dot gnu.org
2022-05-11  6:24 ` cvs-commit at gcc dot gnu.org
2022-05-11  6:36 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-104517-4-jrtdHf5vQI@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).