[Bug debug/104517] New: '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[Bug debug/104517] New: '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

            Bug ID: 104517
           Summary: '-fcompare-debug' failure w/ -O1 -fopenmp
                    -fno-tree-ter
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: compare-debug-failure, openmp
          Severity: normal
          Priority: P3
         Component: debug
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

Created attachment 52429
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52429&action=edit
Testcase

gcc 12.0.1 20220206 snapshot (g:8eb329e963593342855b6072e5692659107337b7) fails
-fcompare-debug check when compiling the attached testcase, reduced from
gcc/testsuite/c-c++-common/gomp/clauses-1.c, w/ -O1 -fopenmp -fno-tree-ter:

% gcc-12.0.1 -O1 -fcompare-debug -fopenmp -fno-tree-ter -c isdtsldh.c
-save-temps
gcc-12.0.1: error: isdtsldh.c: '-fcompare-debug' failure

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #1 from Arseny Solokha <asolokha at gmx dot com> ---
Created attachment 52430
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52430&action=edit
gkd diff

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I can't reproduce it on the trunk.

I wonder if it was fixed by the patch which fixed PR 104459.

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #3 from Arseny Solokha <asolokha at gmx dot com> ---
No, it still fails w/ 20220213 snapshot
(g:58aeb75d4097010ad9bb72b964265b18ab284f93). You should try adding -save-temps
to the command line.

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
yes adding -save-temps causes the difference, interesting.

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-02-14
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52436
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52436&action=edit
gcc12-pr104517.patch

Untested fix.

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:6a0d6e7ca9b9e338e82572db79c26168684a7441

commit r12-7237-g6a0d6e7ca9b9e338e82572db79c26168684a7441
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 15 10:22:30 2022 +0100

    openmp: Make finalize_task_copyfn order reproduceable [PR104517]

    The following testcase fails -fcompare-debug, because finalize_task_copyfn
    was invoked from splay tree destruction, whose order can in some cases
    depend on -g/-g0.  The fix is to queue the task stmts that need copyfn
    in a vector and run finalize_task_copyfn on elements of that vector.

    2022-02-15  Jakub Jelinek  <jakub@redhat.com>

            PR debug/104517
            * omp-low.cc (task_cpyfns): New variable.
            (delete_omp_context): Don't call finalize_task_copyfn from here.
            (create_task_copyfn): Push task_stmt into task_cpyfns.
            (execute_lower_omp): Call finalize_task_copyfn here on entries from
            task_cpyfns vector and release the vector.

            * gcc.dg/gomp/pr104517.c: New test.

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:14f0b450f7976f824428f0d35b4e7e6dc162f708

commit r11-9606-g14f0b450f7976f824428f0d35b4e7e6dc162f708
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 15 10:22:30 2022 +0100

    openmp: Make finalize_task_copyfn order reproduceable [PR104517]

    The following testcase fails -fcompare-debug, because finalize_task_copyfn
    was invoked from splay tree destruction, whose order can in some cases
    depend on -g/-g0.  The fix is to queue the task stmts that need copyfn
    in a vector and run finalize_task_copyfn on elements of that vector.

    2022-02-15  Jakub Jelinek  <jakub@redhat.com>

            PR debug/104517
            * omp-low.c (task_cpyfns): New variable.
            (delete_omp_context): Don't call finalize_task_copyfn from here.
            (create_task_copyfn): Push task_stmt into task_cpyfns.
            (execute_lower_omp): Call finalize_task_copyfn here on entries from
            task_cpyfns vector and release the vector.

            * gcc.dg/gomp/pr104517.c: New test.

    (cherry picked from commit 6a0d6e7ca9b9e338e82572db79c26168684a7441)

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d028f4313ae55837b30bec6b737c92a229b4f23d

commit r10-10681-gd028f4313ae55837b30bec6b737c92a229b4f23d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 15 10:22:30 2022 +0100

    openmp: Make finalize_task_copyfn order reproduceable [PR104517]

    The following testcase fails -fcompare-debug, because finalize_task_copyfn
    was invoked from splay tree destruction, whose order can in some cases
    depend on -g/-g0.  The fix is to queue the task stmts that need copyfn
    in a vector and run finalize_task_copyfn on elements of that vector.

    2022-02-15  Jakub Jelinek  <jakub@redhat.com>

            PR debug/104517
            * omp-low.c (task_cpyfns): New variable.
            (delete_omp_context): Don't call finalize_task_copyfn from here.
            (create_task_copyfn): Push task_stmt into task_cpyfns.
            (execute_lower_omp): Call finalize_task_copyfn here on entries from
            task_cpyfns vector and release the vector.

    (cherry picked from commit 6a0d6e7ca9b9e338e82572db79c26168684a7441)

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:57e0795a44639d1cc84abbdd46c507cc64dfa2f8

commit r9-10129-g57e0795a44639d1cc84abbdd46c507cc64dfa2f8
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 15 10:22:30 2022 +0100

    openmp: Make finalize_task_copyfn order reproduceable [PR104517]

    The following testcase fails -fcompare-debug, because finalize_task_copyfn
    was invoked from splay tree destruction, whose order can in some cases
    depend on -g/-g0.  The fix is to queue the task stmts that need copyfn
    in a vector and run finalize_task_copyfn on elements of that vector.

    2022-02-15  Jakub Jelinek  <jakub@redhat.com>

            PR debug/104517
            * omp-low.c (task_cpyfns): New variable.
            (delete_omp_context): Don't call finalize_task_copyfn from here.
            (create_task_copyfn): Push task_stmt into task_cpyfns.
            (execute_lower_omp): Call finalize_task_copyfn here on entries from
            task_cpyfns vector and release the vector.

    (cherry picked from commit 6a0d6e7ca9b9e338e82572db79c26168684a7441)

[Bug debug/104517] '-fcompare-debug' failure w/ -O1 -fopenmp -fno-tree-ter

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104517

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.