public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/104545] New: [OpenMP & Fortran] Pointers issue in combination of depobj construct and depend clause with depobj dependence-type
@ 2022-02-15  9:55 marcel at codesourcery dot com
  2022-02-15 11:32 ` [Bug fortran/104545] " burnus at gcc dot gnu.org
  2022-02-16  7:57 ` burnus at gcc dot gnu.org
  0 siblings, 2 replies; 3+ messages in thread
From: marcel at codesourcery dot com @ 2022-02-15  9:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104545

            Bug ID: 104545
           Summary: [OpenMP & Fortran] Pointers issue in combination of
                    depobj construct and depend clause with depobj
                    dependence-type
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marcel at codesourcery dot com
  Target Milestone: ---

Created attachment 52445
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52445&action=edit
test which fails due to the issue

Defining a dependence object "obj1" for a pointer "p" with:

  !$omp depobj(obj1) depend(in: p)

is not correctly considered at execution time when used in a depend clause
like:

  !$omp task depend(depobj: obj1)

even if the pointer is associated. This effects for instance that tasks in a
parallel construct are not executed in the correct order (see attached test
case).

This is not an issue if the locator ("p") has type integer e.g. but does not
work with pointer type.

This is not an issue for C/C++, only for Fortran.

A complete test case which fails due to this issue is attached.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug fortran/104545] [OpenMP & Fortran] Pointers issue in combination of depobj construct and depend clause with depobj dependence-type
  2022-02-15  9:55 [Bug fortran/104545] New: [OpenMP & Fortran] Pointers issue in combination of depobj construct and depend clause with depobj dependence-type marcel at codesourcery dot com
@ 2022-02-15 11:32 ` burnus at gcc dot gnu.org
  2022-02-16  7:57 ` burnus at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: burnus at gcc dot gnu.org @ 2022-02-15 11:32 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104545

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED on GCC 12, only, by commit
r12-7242-g3939c1b11279dc950d2f160eb940dd791f7b40f1

commit 3939c1b11279dc950d2f160eb940dd791f7b40f1
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Feb 15 12:26:48 2022 +0100

    Fortran/OpenMP: Fix depend-clause handling

    gcc/fortran/ChangeLog:

            * trans-openmp.cc (gfc_trans_omp_clauses, gfc_trans_omp_depobj):
            Depend on the proper addr, for ptr/alloc depend on pointee.

    libgomp/ChangeLog:

            * testsuite/libgomp.fortran/depend-4.f90: New test.

    gcc/testsuite/ChangeLog:

            * gfortran.dg/gomp/depend-4.f90: New test.
            * gfortran.dg/gomp/depend-5.f90: New test.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Bug fortran/104545] [OpenMP & Fortran] Pointers issue in combination of depobj construct and depend clause with depobj dependence-type
  2022-02-15  9:55 [Bug fortran/104545] New: [OpenMP & Fortran] Pointers issue in combination of depobj construct and depend clause with depobj dependence-type marcel at codesourcery dot com
  2022-02-15 11:32 ` [Bug fortran/104545] " burnus at gcc dot gnu.org
@ 2022-02-16  7:57 ` burnus at gcc dot gnu.org
  1 sibling, 0 replies; 3+ messages in thread
From: burnus at gcc dot gnu.org @ 2022-02-16  7:57 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104545

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Crossrefs:

* PR 104562 shows an issue caused by the original commit.

* r12-7250-g4d74ea551734694c225643c4069b1b4d4d2b05ed
  "Fortran/OpenMP: Fix depend-clause handling for c_ptr"
  fixes that issue + an issue with type(c_ptr)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-16  7:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15  9:55 [Bug fortran/104545] New: [OpenMP & Fortran] Pointers issue in combination of depobj construct and depend clause with depobj dependence-type marcel at codesourcery dot com
2022-02-15 11:32 ` [Bug fortran/104545] " burnus at gcc dot gnu.org
2022-02-16  7:57 ` burnus at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).