public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650
@ 2022-02-15 19:39 gscfq@t-online.de
2022-02-15 21:42 ` [Bug fortran/104554] " kargl at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: gscfq@t-online.de @ 2022-02-15 19:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104554
Bug ID: 104554
Summary: ICE in check_assumed_size_reference, at
fortran/resolve.cc:1650
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: fortran
Assignee: unassigned at gcc dot gnu.org
Reporter: gscfq@t-online.de
Target Milestone: ---
With a missing attribute allocatable or pointer :
(starts with r9)
$ cat z1.f90
program p
type t
integer :: a
end type
class(t) :: x(*)
x%a = 3
end
$ cat z2.f90
program p
type t
integer :: a
end type
class(t), allocatable :: x(*)
x%a = 3
end
$ gfortran-12-20220213 -c z1.f90
z1.f90:5:19:
5 | class(t) :: x(*)
| 1
Error: Assumed size array at (1) must be a dummy argument
f951: internal compiler error: Segmentation fault
0xe7073f crash_signal
../../gcc/toplev.cc:322
0x79babd check_assumed_size_reference
../../gcc/fortran/resolve.cc:1650
0x7a136f resolve_variable
../../gcc/fortran/resolve.cc:5873
0x7a136f gfc_resolve_expr(gfc_expr*)
../../gcc/fortran/resolve.cc:7171
0x7a9324 gfc_resolve_expr(gfc_expr*)
../../gcc/fortran/resolve.cc:7136
0x7a9324 gfc_resolve_code(gfc_code*, gfc_namespace*)
../../gcc/fortran/resolve.cc:11927
0x7aa977 resolve_codes
../../gcc/fortran/resolve.cc:17536
0x7aaa3e gfc_resolve(gfc_namespace*)
../../gcc/fortran/resolve.cc:17571
0x792d64 resolve_all_program_units
../../gcc/fortran/parse.cc:6586
0x792d64 gfc_parse_file()
../../gcc/fortran/parse.cc:6842
0x7e102f gfc_be_parse_file
../../gcc/fortran/f95-lang.cc:216
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/104554] ICE in check_assumed_size_reference, at fortran/resolve.cc:1650
2022-02-15 19:39 [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650 gscfq@t-online.de
@ 2022-02-15 21:42 ` kargl at gcc dot gnu.org
2022-02-24 11:22 ` marxin at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: kargl at gcc dot gnu.org @ 2022-02-15 21:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104554
kargl at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kargl at gcc dot gnu.org
Status|UNCONFIRMED |NEW
Last reconfirmed| |2022-02-15
Priority|P3 |P4
Ever confirmed|0 |1
--- Comment #1 from kargl at gcc dot gnu.org ---
NULL pointer dereference.
diff --git a/gcc/fortran/resolve.cc b/gcc/fortran/resolve.cc
index 835a4783718..51162455cbb 100644
--- a/gcc/fortran/resolve.cc
+++ b/gcc/fortran/resolve.cc
@@ -1647,7 +1647,9 @@ check_assumed_size_reference (gfc_symbol *sym, gfc_expr
*e)
/* FIXME: The comparison "e->ref->u.ar.type == AR_FULL" is wrong.
What should it be? */
- if (e->ref && (e->ref->u.ar.end[e->ref->u.ar.as->rank - 1] == NULL)
+ if (e->ref
+ && e->ref->u.ar.as
+ && (e->ref->u.ar.end[e->ref->u.ar.as->rank - 1] == NULL)
&& (e->ref->u.ar.as->type == AS_ASSUMED_SIZE)
&& (e->ref->u.ar.type == AR_FULL))
{
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/104554] ICE in check_assumed_size_reference, at fortran/resolve.cc:1650
2022-02-15 19:39 [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650 gscfq@t-online.de
2022-02-15 21:42 ` [Bug fortran/104554] " kargl at gcc dot gnu.org
@ 2022-02-24 11:22 ` marxin at gcc dot gnu.org
2023-02-15 19:59 ` anlauf at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-02-24 11:22 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104554
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org,
| |pault at gcc dot gnu.org
--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
I think it started with r12-570-ga2c593009fef1564.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/104554] ICE in check_assumed_size_reference, at fortran/resolve.cc:1650
2022-02-15 19:39 [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650 gscfq@t-online.de
2022-02-15 21:42 ` [Bug fortran/104554] " kargl at gcc dot gnu.org
2022-02-24 11:22 ` marxin at gcc dot gnu.org
@ 2023-02-15 19:59 ` anlauf at gcc dot gnu.org
2023-02-15 21:23 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-02-15 19:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104554
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |anlauf at gcc dot gnu.org
Status|NEW |ASSIGNED
CC| |anlauf at gcc dot gnu.org
--- Comment #3 from anlauf at gcc dot gnu.org ---
Will commit Steve's patch as obvious.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/104554] ICE in check_assumed_size_reference, at fortran/resolve.cc:1650
2022-02-15 19:39 [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650 gscfq@t-online.de
` (2 preceding siblings ...)
2023-02-15 19:59 ` anlauf at gcc dot gnu.org
@ 2023-02-15 21:23 ` cvs-commit at gcc dot gnu.org
2023-02-16 17:30 ` cvs-commit at gcc dot gnu.org
2023-02-16 17:32 ` anlauf at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-02-15 21:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104554
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:a418129273725fd02e881e6fb5e0877287a1356c
commit r13-6066-ga418129273725fd02e881e6fb5e0877287a1356c
Author: Steve Kargl <kargl@gcc.gnu.org>
Date: Wed Feb 15 22:20:22 2023 +0100
Fortran: error recovery on invalid assumed size reference [PR104554]
gcc/fortran/ChangeLog:
PR fortran/104554
* resolve.cc (check_assumed_size_reference): Avoid NULL pointer
dereference.
gcc/testsuite/ChangeLog:
PR fortran/104554
* gfortran.dg/pr104554.f90: New test.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/104554] ICE in check_assumed_size_reference, at fortran/resolve.cc:1650
2022-02-15 19:39 [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650 gscfq@t-online.de
` (3 preceding siblings ...)
2023-02-15 21:23 ` cvs-commit at gcc dot gnu.org
@ 2023-02-16 17:30 ` cvs-commit at gcc dot gnu.org
2023-02-16 17:32 ` anlauf at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-02-16 17:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104554
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:e2c6bc6bb5628bb51b56d1da3f9907ae45a3a01b
commit r12-9179-ge2c6bc6bb5628bb51b56d1da3f9907ae45a3a01b
Author: Steve Kargl <kargl@gcc.gnu.org>
Date: Wed Feb 15 22:20:22 2023 +0100
Fortran: error recovery on invalid assumed size reference [PR104554]
gcc/fortran/ChangeLog:
PR fortran/104554
* resolve.cc (check_assumed_size_reference): Avoid NULL pointer
dereference.
gcc/testsuite/ChangeLog:
PR fortran/104554
* gfortran.dg/pr104554.f90: New test.
(cherry picked from commit a418129273725fd02e881e6fb5e0877287a1356c)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug fortran/104554] ICE in check_assumed_size_reference, at fortran/resolve.cc:1650
2022-02-15 19:39 [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650 gscfq@t-online.de
` (4 preceding siblings ...)
2023-02-16 17:30 ` cvs-commit at gcc dot gnu.org
@ 2023-02-16 17:32 ` anlauf at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-02-16 17:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104554
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.3
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-13, and on 12-branch.
Given comment#2 this might be ok and not worth backporting further.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-16 17:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 19:39 [Bug fortran/104554] New: ICE in check_assumed_size_reference, at fortran/resolve.cc:1650 gscfq@t-online.de
2022-02-15 21:42 ` [Bug fortran/104554] " kargl at gcc dot gnu.org
2022-02-24 11:22 ` marxin at gcc dot gnu.org
2023-02-15 19:59 ` anlauf at gcc dot gnu.org
2023-02-15 21:23 ` cvs-commit at gcc dot gnu.org
2023-02-16 17:30 ` cvs-commit at gcc dot gnu.org
2023-02-16 17:32 ` anlauf at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).