[Bug libstdc++/104605] New: _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[Bug libstdc++/104605] New: _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

            Bug ID: 104605
           Summary: _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for
                    canadian cross freestanding C++ toolchain
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: unlvsur at live dot com
  Target Milestone: ---

#include<cstdint>

int main()
{
        std::uintptr_t p{};
}

This code works on x86_64-elf cross toolchain on linux, but fails to work after
i perform Canadian cross-compilation from linux to windows since
_GLIBCXX_USE_C99_STDINT_TR1 is not defined.

Also stdint.h in GCC is not correctly defined without -ffreestanding flag.
I believe it can be trivialized as just do this
#if __has_include_next(<stdint.h>)
# include_next <stdint.h>
#else
# include "stdint-gcc.h"
#endif

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #1 from cqwrteur <unlvsur at live dot com> ---
D:\hg\fast_io\.tmp>x86_64-elf-g++ -c canada.cc -std=c++23
canada.cc: In function 'int main()':
canada.cc:5:14: error: 'uintptr_t' is not a member of 'std'; did you mean
'uintmax_t'?
    5 |         std::uintptr_t p{};
      |              ^~~~~~~~~
      |              uintmax_t

D:\hg\fast_io\.tmp>x86_64-elf-g++ -v
Using built-in specs.
COLLECT_GCC=x86_64-elf-g++
COLLECT_LTO_WRAPPER=d:/x86_64-windows-gnu/baremetal/x86_64-elf/bin/../libexec/gcc/x86_64-elf/12.0.1/lto-wrapper.exe
Target: x86_64-elf
Configured with: ../../../../gcc/configure --disable-nls --disable-werror
--disable-hosted-libstdcxx --without-headers --disable-shared
--target=x86_64-elf
--prefix=/home/cqwrteur/toolchains/gnu/x86_64-w64-mingw32/x86_64-elf
--host=x86_64-w64-mingw32 --enable-multilib --disable-libssp
--disable-libquadmath
Thread model: single
Supported LTO compression algorithms: zlib
gcc version 12.0.1 20220219 (experimental) (GCC)

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #2 from cqwrteur <unlvsur at live dot com> ---
I just upload the toolchain to github.
https://github.com/tearosccebe/x86_64-elf-baremetal-toolchain

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #3 from cqwrteur <unlvsur at live dot com> ---
(In reply to cqwrteur from comment #2)
> I just upload the toolchain to github.
> https://github.com/tearosccebe/x86_64-elf-baremetal-toolchain

link dead. sorry.
https://bitbucket.org/ejsvifq_mabmip/x86_64-elf-baremetal-toolchain

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #4 from cqwrteur <unlvsur at live dot com> ---
error: 'uintptr_t' is not a member of 'std'; did you mean 'uintmax_t'?

The bug still exists in GCC 13.0.0

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 107133 has been marked as a duplicate of this bug. ***

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to cqwrteur from comment #0)
> Also stdint.h in GCC is not correctly defined without -ffreestanding flag.

You can just use -ffreestanding now, and you'll get GCC's own stdint header.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Created attachment 53657
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53657&action=edit
Use predefined macros to define freestanding <cstdint>

I have this patch locally, but I don't think the <stdint.h> changes are
actually necessary. Using -ffreestanding should ensure they are present
already.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #8 from cqwrteur <unlvsur at live dot com> ---
(In reply to Jonathan Wakely from comment #7)
> Created attachment 53657 [details]
> Use predefined macros to define freestanding <cstdint>
> 
> I have this patch locally, but I don't think the <stdint.h> changes are
> actually necessary. Using -ffreestanding should ensure they are present
> already.

stdint.h is a freestanding C header but not a freestanding C++ header if i
remembered correctly.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> ---
<cstdint> is freestanding, but <stdint.h> isn't listed as being required for
freestanding C++. That doesn't mean we can't provide it.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[arsen at aarsen dot me]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

Arsen Arsenović <arsen at aarsen dot me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |arsen at aarsen dot me

--- Comment #10 from Arsen Arsenović <arsen at aarsen dot me> ---
Created attachment 53661
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53661&action=edit
*-elf --without-headers --without-newlib should(?) provide stdint.h

Try applying this patch. I'll see if it's correct tomorrow and send it upstream
if it is. Also don't forget to tell GCC you don't have newlib via:
--without-newlib --without-headers.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #11 from cqwrteur <unlvsur at live dot com> ---
(In reply to Arsen Arsenović from comment #10)
> Created attachment 53661 [details]
> *-elf --without-headers --without-newlib should(?) provide stdint.h
> 
> Try applying this patch. I'll see if it's correct tomorrow and send it
> upstream if it is. Also don't forget to tell GCC you don't have newlib via:
> --without-newlib --without-headers.

can we simplify the settings here? For example --without-headers imply
--without-headers and --disable-hosted-libstdcxx and disabling other libraries
like libssp, libatomic?

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #12 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Please stop mixing separate issues together in bug reports. If you want that
change, file a separate bug report asking for it.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #53657|0                           |1
        is obsolete|                            |

--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Created attachment 53664
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53664&action=edit
Make <cstdint> work freestanding

If Arsen's patch for use_gcc_stdint isn't accepted, this will allow libstdc++
to work.

Maybe we should just do this for now anyway.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #14 from Jonathan Wakely <redi at gcc dot gnu.org> ---
*** Bug 107134 has been marked as a duplicate of this bug. ***

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #15 from cqwrteur <unlvsur at live dot com> ---
(In reply to Jonathan Wakely from comment #14)
> *** Bug 107134 has been marked as a duplicate of this bug. ***

Well. that time only canadian cross did not work. Now even cross compiler does
not work anymore. They do have differences.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

--- Comment #16 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Oops, I put the wrong PR number on this commit:

https://gcc.gnu.org/g:7cdab65f3d770345903023f357b6ca96bc85a002

commit r13-3059-g7cdab65f3d770345903023f357b6ca96bc85a002
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Oct 3 21:49:27 2022 +0100

    libstdc++: Make <cstdint> work freestanding [PR107134]

    When gcc/config.gcc defines use_gcc_stdin=wrap, GCC's <stdint.h> tries
    to use libc's <stdint.h> unless -ffreestanding is used.

    When libstdc++ is configured --disable-hosted-libstdcxx we want
    <cstdint> to work even without -ffreestanding being given. This is a
    kluge to make it include GCC's <stdint-gcc.h> directly even without
    -ffreestanding.

    libstdc++-v3/ChangeLog:

            PR libstdc++/107134
            * include/c_global/cstdint [!_GLIBCXX_HOSTED]: Include
            <stdint-gcc.h> directly.

This should be fixed now, please check.

I think we still want Arsen's patch in comment 10 for correctness, but this
makes libstdc++ cope without it.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-05-12

--- Comment #17 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #16)
> This should be fixed now, please check.

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

cqwrteur <unlvsur at live dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|WAITING                     |RESOLVED

--- Comment #18 from cqwrteur <unlvsur at live dot com> ---
(In reply to Jonathan Wakely from comment #17)
> (In reply to Jonathan Wakely from comment #16)
> > This should be fixed now, please check.

Fixed confirm

[Bug libstdc++/104605] _GLIBCXX_USE_C99_STDINT_TR1 macro is not defined for canadian cross freestanding C++ toolchain

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104605

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

--- Comment #19 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #16)
> I think we still want Arsen's patch in comment 10 for correctness, but this
> makes libstdc++ cope without it.

That was done as r13-3322-gf10b9f64133cbf