[Bug d/104739] New: gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[Bug d/104739] New: gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

            Bug ID: 104739
           Summary: gdc.test/runnable/mangle.d etc. FAIL with Solaris as
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11

Since 20211130, several tests FAIL on Solaris when /bin/as is used instead of
gas:

+UNRESOLVED: gdc.test/runnable/mangle.d   compilation failed to produce
executable
+UNRESOLVED: gdc.test/runnable/mangle.d -shared-libphobos   compilation failed
to produce executable

Assembler: mangle.d
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
[...]

+UNRESOLVED: gdc.test/runnable/testmodule.d   compilation failed to produce
executable
+UNRESOLVED: gdc.test/runnable/testmodule.d -shared-libphobos   compilation
failed to produce executable

Assembler: testmodule.d
        "/var/tmp//ccBtixAd.s", line 3 : Syntax error
        Near line: "    .globl  _D3run17unicode_06_哪里6哪里FiZi"
        "/var/tmp//ccBtixAd.s", line 3 : Syntax error
        Near line: "    .globl  _D3run17unicode_06_哪里6哪里FiZi"
        "/var/tmp//ccBtixAd.s", line 3 : Syntax error
        Near line: "    .globl  _D3run17unicode_06_哪里6哪里FiZi"
        "/var/tmp//ccBtixAd.s", line 3 : Syntax error
        Near line: "    .globl  _D3run17unicode_06_哪里6哪里FiZi"
        "/var/tmp//ccBtixAd.s", line 3 : Syntax error
[...]

+UNRESOLVED: gdc.test/runnable/ufcs.d   compilation failed to produce
executable
+UNRESOLVED: gdc.test/runnable/ufcs.d -shared-libphobos   compilation failed to
produce executable

Assembler: ufcs.d
        "/var/tmp//ccodJ7Ib.s", line 6662 : Syntax error
        Near line: "    .globl  _D4ufcs6α8503FiZv"
        "/var/tmp//ccodJ7Ib.s", line 6662 : Syntax error
        Near line: "    .globl  _D4ufcs6α8503FiZv"
        "/var/tmp//ccodJ7Ib.s", line 6662 : Syntax error
        Near line: "    .globl  _D4ufcs6α8503FiZv"

All of these happen because /bin/as lacks support for UTF-8 identifiers.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.0                        |12.2

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.3                        |12.4

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 12.3 is being released, retargeting bugs to GCC 12.4.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-02-02

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
I wonder how to handle this: while DejaGnu has an ucn effective-target keyword,
the gdc.test testsuite doesn't use those at all.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
> I wonder how to handle this: while DejaGnu has an ucn effective-target keyword,
> the gdc.test testsuite doesn't use those at all.

What I think could be done is

* Add "//UTF-8 chars" comments to testmodule.d and ufcs.d; mangle.d
  already has one.

* Make gdc-utils.exp (gdc-convert-test) check for those annotations,
  adding

  // { dg-require-effective-target ucn}

  if found.

The new annotations would have to go upstream, I believe.  WDYT?

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

--- Comment #6 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #5)
> > --- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
> > I wonder how to handle this: while DejaGnu has an ucn effective-target keyword,
> > the gdc.test testsuite doesn't use those at all.
> 
> What I think could be done is
> 
> * Add "//UTF-8 chars" comments to testmodule.d and ufcs.d; mangle.d
>   already has one.
> 
> * Make gdc-utils.exp (gdc-convert-test) check for those annotations,
>   adding
> 
>   // { dg-require-effective-target ucn}
> 
>   if found.
> 
> The new annotations would have to go upstream, I believe.  WDYT?

Can give it a go.

https://github.com/dlang/dmd/pull/16136

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

--- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #6 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
> (In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #5)
> Can give it a go.
>
> https://github.com/dlang/dmd/pull/16136

Great, thanks for doing this.  With this patch applied locally, adding
DejaGnu support for the new annotation proved to be as easy as I'd
suspected.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

--- Comment #8 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 57324
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57324&action=edit
Proposed patch

Tested on i386-pc-solaris2.11 (as and gas) and i686-pc-linux-gnu.  The affected
tests come up as UNSUPPORTED with as, but PASS with gas.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-Februar
                   |                            |y/645547.html

--- Comment #9 from Rainer Orth <ro at gcc dot gnu.org> ---
Patch now posted for real.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:a032c319cb9cf5348d71f008f311bcf95f3dac40

commit r14-8979-ga032c319cb9cf5348d71f008f311bcf95f3dac40
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Wed Feb 14 14:52:54 2024 +0100

    testsuite: gdc: Require ucn in gdc.test/runnable/mangle.d etc. [PR104739]

    gdc.test/runnable/mangle.d and two other tests come out UNRESOLVED on
    Solaris with the native assembler:

    UNRESOLVED: gdc.test/runnable/mangle.d   compilation failed to produce
executable
    UNRESOLVED: gdc.test/runnable/mangle.d -shared-libphobos compilation failed
    to produce executable
    UNRESOLVED: gdc.test/runnable/testmodule.d compilation failed to produce
    executable
    UNRESOLVED: gdc.test/runnable/testmodule.d -shared-libphobos compilation
    failed to produce executable
    UNRESOLVED: gdc.test/runnable/ufcs.d   compilation failed to produce
executable
    UNRESOLVED: gdc.test/runnable/ufcs.d -shared-libphobos compilation failed
    to produce executable

    Assembler: mangle.d
            "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
            Near line: "    movzbl 
test_ÑлÑÑийÑкие_пиÑÑмена_9, %eax"
            "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
            Near line: "    movzbl 
test_ÑлÑÑийÑкие_пиÑÑмена_9, %eax"
            "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
            Near line: "    movzbl 
test_ÑлÑÑийÑкие_пиÑÑмена_9, %eax"
            "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
            Near line: "    movzbl 
test_ÑлÑÑийÑкие_пиÑÑмена_9, %eax"
            "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
    [...]

    since /bin/as lacks UCN support.

    Iain recently added UNICODE_NAMES: annotations to the affected tests and
    those recently were imported into trunk.

    This patch handles the DejaGnu side of things, adding

            { dg-require-effective-target ucn }

    to those tests on the fly.

    Tested on i386-pc-solaris2.11, sparc-sun-solaris2.11 (as and gas each),
    and x86_64-pc-linux-gnu.

    2024-02-03  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            gcc/testsuite:
            PR d/104739
            * lib/gdc-utils.exp (gdc-convert-test) <UNICODE_NAMES>: Require
            ucn support.

[Bug d/104739] gdc.test/runnable/mangle.d etc. FAIL with Solaris as

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104739

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ibuclaw at gdcproject dot org      |ro at gcc dot gnu.org
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #11 from Rainer Orth <ro at gcc dot gnu.org> ---
Mine.  Fixed for GCC 14.0.1.