[Bug d/104749] New: [12 regression] stage1 d21 fails to link on Solaris/x86

[Bug d/104749] New: [12 regression] stage1 d21 fails to link on Solaris/x86

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

            Bug ID: 104749
           Summary: [12 regression] stage1 d21 fails to link on
                    Solaris/x86
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: d
          Assignee: ibuclaw at gdcproject dot org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: i?86-pc-solaris2.11

Between 20220228 (3f3246eb16f554c70c5ce87ad2c785f83adb4625) and 20220301
(673a10aee1aafe0c99bfadc29a7458339bdddb3a),
stage1 d21 fails to link on Solaris/x86:

ld: fatal: symbol '___s.24736' is multiply-defined:
        (file d/statementsem.o type=OBJT; file d/typesem.o type=OBJT);
ld: fatal: symbol '___s.24712' is multiply-defined:
        (file d/statementsem.o type=OBJT; file d/typesem.o type=OBJT);

This doesn't happen on Solaris/SPARC, though.

This is with gdc 9.1.0 as bootstrap compiler.  The problem seems to vanish
(haven't run a full bootstrap yet) with gdc 11.1.0, and gdc 9.1.0 -m64 (i.e.
building an amd64-pc-solaris2.11 compiler) works, too.

I'll attach the assembler output.

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 52540
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52540&action=edit
32-bit i386-pc-solaris2.11 statementsem.s with gdc 9.1.0

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 52541
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52541&action=edit
32-bit i386-pc-solaris2.11 typesem.s with gdc 9.1.0

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
So this is a gdc 9.1.0 bug then, not a GCC 12 issue?  (did you try 9.3?)

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
> So this is a gdc 9.1.0 bug then, not a GCC 12 issue?  (did you try 9.3?)

It seems so, yes.  Yet gdc 9.1.0 was good enough until now, and if
there's an issue, the requirement should at least be documented.

I'm currently running a bootstrap with gdc 11.1.0 instead, which is well
into make check.

Will try gdc 9.4.0 (which is currently building, switching from gas 2.32
to 2.38 if that matters) afterwards.

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot
> Will try gdc 9.4.0 (which is currently building, switching from gas 2.32
> to 2.38 if that matters) afterwards.

Both gdc 11.1.0 and gdc 9.4.0 work fine.

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[ibuclaw at gdcproject dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #6 from Iain Buclaw <ibuclaw at gdcproject dot org> ---
Just having a look around, I couldn't see anywhere that `___s` would be created
now.

Then I came across r9-8460, which was fixed for 10.1.0, and backported before
9.4.0 was released.  Linked bug report is pr d/94240.

In that case then, earlier versions of version 9 might not work correctly.

[Bug d/104749] [12 regression] stage1 d21 fails to link on Solaris/x86

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |documentation

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
So maybe amend install.texi

[Bug d/104749] [12/13 regression] stage1 d21 fails to link on Solaris/x86

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.0                        |12.2

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.

[Bug d/104749] [12/13 regression] stage1 d21 fails to link on Solaris/x86

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #10 from Rainer Orth <ro at gcc dot gnu.org> ---
*** Bug 107552 has been marked as a duplicate of this bug. ***

[Bug d/104749] [12/13 regression] stage1 d21 fails to link on Solaris/x86

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-11-10
                 CC|                            |tschwinge at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #11 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
I recently started running into such an issue also for x86_64-pc-linux-gnu,
which I determined to be due to recent commit
r13-3560-g7e7ebe3e350fde90fe49ab41ce3b92a811bb6370 "d: Merge upstream dmd,
druntime e4f8919591, phobos 3ad507b51" -- just like what was recently discussed
in PR107552 "[13 regression] stage 1 d21 fails to link on Linux/x86_64", which
got marked a duplicate of this PR104749.

(In reply to Iain Buclaw from comment #6)
> [...] r9-8460, which was fixed for 10.1.0, and backported before 9.4.0 was released.  Linked bug report is pr d/94240.
> 
> In that case then, earlier versions of version 9 might not work correctly.

So I understand that's what we're running into, both for the "Solaris/x86"
configuration originally reported here, and x86_64-pc-linux-gnu as per PR107552
and my own findings?

We've got a report that:

(In reply to ro@CeBiTec.Uni-Bielefeld.DE from comment #5)
> gdc 9.4.0 work fine.

..., but 'gcc/doc/install.texi' still states that "you need a working GDC
compiler (GCC version 9.1 or later)", thus:

(In reply to Richard Biener from comment #7)
> So maybe amend install.texi

... let's do that -- or is something else still to be investigated here?

[Bug d/104749] [12/13 regression] stage1 d21 fails to link with GDC 9.1

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12/13 regression] stage1   |[12/13 regression] stage1
                   |d21 fails to link on        |d21 fails to link with GDC
                   |Solaris/x86                 |9.1

--- Comment #12 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Iain Buclaw from comment #6)
> Just having a look around, I couldn't see anywhere that `___s` would be
> created now.
> 
> Then I came across r9-8460, which was fixed for 10.1.0, and backported
> before 9.4.0 was released.  Linked bug report is pr d/94240.
> 
> In that case then, earlier versions of version 9 might not work correctly.

I have, by the way, confirmed that cherry-picking commit
r9-8460-ge926d076f28a91f3ea30bd0bcfa1f25958fdb59e "d: Fix ICE in
add_symbol_to_partition_1, at lto/lto-partition.c:215" on top of GCC 9.1 does
resolve the issue discussed here (for x86_64-pc-linux-gnu).

... but for 'gcc/doc/install.texi' we'd rather state "GDC compiler (GCC version
9.4 or later)", I suppose.

[Bug d/104749] [12/13 regression] stage1 d21 fails to link with GDC 9.1

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:05b7cf52e1b640271900894a894da2d27ef90092

commit r13-4805-g05b7cf52e1b640271900894a894da2d27ef90092
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Dec 20 14:34:01 2022 +0100

    d/104749 - document host GDC version requirement

    This documents that GDC 9.4 or later is required to build the D
    language rather than GDC 9.1 which suffers from PR94240.

            PR d/104749
            * doc/install.texi (GDC): Document GDC 9.4 or later is required
            to build the D language frontend.

[Bug d/104749] [12/13 regression] stage1 d21 fails to link with GDC 9.1

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:1bdb13071f0ead3c83390ac9fcc0be73a2607a42

commit r12-9001-g1bdb13071f0ead3c83390ac9fcc0be73a2607a42
Author: Richard Biener <rguenther@suse.de>
Date:   Tue Dec 20 14:34:01 2022 +0100

    d/104749 - document host GDC version requirement

    This documents that GDC 9.4 or later is required to build the D
    language rather than GDC 9.1 which suffers from PR94240.

            PR d/104749
            * doc/install.texi (GDC): Document GDC 9.4 or later is required
            to build the D language frontend.

    (cherry picked from commit 05b7cf52e1b640271900894a894da2d27ef90092)

[Bug d/104749] [12/13 regression] stage1 d21 fails to link with GDC 9.1

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104749

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.