public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/104888] New: diagnostics use non-idiomatic '%s'
@ 2022-03-12  6:37 roland.illig at gmx dot de
  2022-03-12  6:39 ` [Bug fortran/104888] " roland.illig at gmx dot de
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-12  6:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104888

            Bug ID: 104888
           Summary: diagnostics use non-idiomatic '%s'
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---

fortran/openmp.cc says:
> selector '%s' not allowed for context selector set '%s' at %C

One year ago, the message contained the idiomatic %qs. Why was it changed in
ae3c4e521dd0b66db712639298cd08331d62f315?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/104888] diagnostics use non-idiomatic '%s'
  2022-03-12  6:37 [Bug fortran/104888] New: diagnostics use non-idiomatic '%s' roland.illig at gmx dot de
@ 2022-03-12  6:39 ` roland.illig at gmx dot de
  2022-03-12  6:46 ` roland.illig at gmx dot de
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-12  6:39 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104888

--- Comment #1 from Roland Illig <roland.illig at gmx dot de> ---
While here:
> expected : at %C

The quotes around the %<:%> are missing.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/104888] diagnostics use non-idiomatic '%s'
  2022-03-12  6:37 [Bug fortran/104888] New: diagnostics use non-idiomatic '%s' roland.illig at gmx dot de
  2022-03-12  6:39 ` [Bug fortran/104888] " roland.illig at gmx dot de
@ 2022-03-12  6:46 ` roland.illig at gmx dot de
  2022-03-12  6:53 ` roland.illig at gmx dot de
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-12  6:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104888

--- Comment #2 from Roland Illig <roland.illig at gmx dot de> ---
While here:
> "'omp_allocator_handle_kind' kind at %L"

Should this be uppercase instead?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/104888] diagnostics use non-idiomatic '%s'
  2022-03-12  6:37 [Bug fortran/104888] New: diagnostics use non-idiomatic '%s' roland.illig at gmx dot de
  2022-03-12  6:39 ` [Bug fortran/104888] " roland.illig at gmx dot de
  2022-03-12  6:46 ` roland.illig at gmx dot de
@ 2022-03-12  6:53 ` roland.illig at gmx dot de
  2022-03-12  7:01 ` roland.illig at gmx dot de
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-12  6:53 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104888

--- Comment #3 from Roland Illig <roland.illig at gmx dot de> ---
While here:
> DEPEND clause of depobj

Should DEPOBJ be uppercase?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/104888] diagnostics use non-idiomatic '%s'
  2022-03-12  6:37 [Bug fortran/104888] New: diagnostics use non-idiomatic '%s' roland.illig at gmx dot de
                   ` (2 preceding siblings ...)
  2022-03-12  6:53 ` roland.illig at gmx dot de
@ 2022-03-12  7:01 ` roland.illig at gmx dot de
  2022-03-12  7:13 ` roland.illig at gmx dot de
  2022-03-14 11:08 ` marxin at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-12  7:01 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104888

--- Comment #4 from Roland Illig <roland.illig at gmx dot de> ---
While here:
> requiries

typo: should be requires

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/104888] diagnostics use non-idiomatic '%s'
  2022-03-12  6:37 [Bug fortran/104888] New: diagnostics use non-idiomatic '%s' roland.illig at gmx dot de
                   ` (3 preceding siblings ...)
  2022-03-12  7:01 ` roland.illig at gmx dot de
@ 2022-03-12  7:13 ` roland.illig at gmx dot de
  2022-03-14 11:08 ` marxin at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: roland.illig at gmx dot de @ 2022-03-12  7:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104888

--- Comment #5 from Roland Illig <roland.illig at gmx dot de> ---
Related, in trans-openmp.cc:
> "specified at %L "

The space at the end is too much.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Bug fortran/104888] diagnostics use non-idiomatic '%s'
  2022-03-12  6:37 [Bug fortran/104888] New: diagnostics use non-idiomatic '%s' roland.illig at gmx dot de
                   ` (4 preceding siblings ...)
  2022-03-12  7:13 ` roland.illig at gmx dot de
@ 2022-03-14 11:08 ` marxin at gcc dot gnu.org
  5 siblings, 0 replies; 7+ messages in thread
From: marxin at gcc dot gnu.org @ 2022-03-14 11:08 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104888

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Roland Illig from comment #0)
> fortran/openmp.cc says:
> > selector '%s' not allowed for context selector set '%s' at %C
> 
> One year ago, the message contained the idiomatic %qs. Why was it changed in
> ae3c4e521dd0b66db712639298cd08331d62f315?

g:ae3c4e521dd0b66db712639298cd08331d62f315

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-03-14 11:08 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-12  6:37 [Bug fortran/104888] New: diagnostics use non-idiomatic '%s' roland.illig at gmx dot de
2022-03-12  6:39 ` [Bug fortran/104888] " roland.illig at gmx dot de
2022-03-12  6:46 ` roland.illig at gmx dot de
2022-03-12  6:53 ` roland.illig at gmx dot de
2022-03-12  7:01 ` roland.illig at gmx dot de
2022-03-12  7:13 ` roland.illig at gmx dot de
2022-03-14 11:08 ` marxin at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).