[Bug target/104898] New: missing %q in diagnostic

[Bug target/104898] New: missing %q in diagnostic

[roland.illig at gmx dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104898

            Bug ID: 104898
           Summary: missing %q in diagnostic
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: diagnostic
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
                CC: egallager at gcc dot gnu.org, sje at gcc dot gnu.org
  Target Milestone: ---
            Target: aarch64

>From aarch64.cc:
> invalid feature modifier %s
The %s should be %qs, like in the related messages.

The parentheses in "(%qs)" look redundant.  They are only used 18 times in
total, in the whole tree.  For comparison, "%qs" is used more than 2700 times
in the whole tree.  I would remove the parentheses.

[Bug target/104898] missing %q in diagnostic

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104898

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> ---
Last touched by Martin L. in r12-6521-g03a1a86b5ee40d

[Bug target/104898] missing %q in diagnostic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104898

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:c6e75a4a353fe36920bac34b66fca4bfb71f7d91

commit r12-7758-gc6e75a4a353fe36920bac34b66fca4bfb71f7d91
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Mar 22 13:25:57 2022 +0100

    aarch64: update error message format.

    Use 'qs' and remove usage '(%qs)'.

            PR target/104898

    gcc/ChangeLog:

            * config/aarch64/aarch64.cc (aarch64_handle_attr_arch):
            Use 'qs' and remove usage '(%qs)'.
            (aarch64_handle_attr_cpu): Likewise.
            (aarch64_handle_attr_tune): Likewise.
            (aarch64_handle_attr_isa_flags): Likewise.

    gcc/testsuite/ChangeLog:

            * gcc.target/aarch64/branch-protection-attr.c:
            Use 'qs' and remove usage '(%qs)'.
            * gcc.target/aarch64/spellcheck_1.c: Likewise.
            * gcc.target/aarch64/spellcheck_2.c: Likewise.
            * gcc.target/aarch64/spellcheck_3.c: Likewise.

[Bug target/104898] missing %q in diagnostic

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104898

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
> The parentheses in "(%qs)" look redundant.

Agree, I'm going to fix that as well.

[Bug target/104898] missing %q in diagnostic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104898

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:1c2a3aeee7dce83a9068f741162a6126a808de1d

commit r12-7759-g1c2a3aeee7dce83a9068f741162a6126a808de1d
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Mar 22 13:31:03 2022 +0100

    i386: update error message format.

    Use '%qs' instead of '(%qs)'.

            PR target/104898

    gcc/ChangeLog:

            * config/i386/i386-options.cc (ix86_option_override_internal):
              Use '%qs' instead of '(%qs)'.

    gcc/testsuite/ChangeLog:

            * gcc.target/i386/pr99753.c: Update test.
            * gcc.target/i386/spellcheck-options-1.c: Likewise.
            * gcc.target/i386/spellcheck-options-2.c: Likewise.
            * gcc.target/i386/spellcheck-options-4.c: Likewise.

[Bug target/104898] missing %q in diagnostic

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104898

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:d85a84c76bdd021df9c38955881d4b094785d2a8

commit r12-7760-gd85a84c76bdd021df9c38955881d4b094785d2a8
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Mar 22 13:33:56 2022 +0100

    rs6000: update error message format.

            PR target/104898

    gcc/ChangeLog:

            * config/rs6000/rs6000.cc (rs6000_option_override_internal):
            Use %qs instead of (%qs).

[Bug target/104898] missing %q in diagnostic

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104898

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
Should be fixed.