[Bug target/104910] New: [10/11/12 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[Bug target/104910] New: [10/11/12 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

            Bug ID: 104910
           Summary: [10/11/12 Regression] ICE: internal consistency
                    failure (error: invalid rtl sharing found in the insn)
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---
            Target: aarch64-linux-gnu

Created attachment 52621
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52621&action=edit
-freport-bug output

gcc 12.0.1 20220313 snapshot (g:7e28750395889d16a9cba49cd5935ced7dc00ce8) ICEs
when compiling the following testcase w/ -Os -fstack-protector-all
-fno-forward-propagate -fno-PIC:

void
bar (void);

void
foo (int x)
{
  if (x)
    bar ();
}

% aarch64-linux-gnu-gcc-12.0.1 -Os -fstack-protector-all -fno-forward-propagate
-fno-PIC -c k1n69laf.c
k1n69laf.c: In function 'foo':
k1n69laf.c:9:1: error: invalid rtl sharing found in the insn
    9 | }
      | ^
(insn 51 50 10 2 (set (reg/f:DI 100)
        (lo_sum:DI (reg:DI 101)
            (const:DI (unspec:DI [
                        (symbol_ref:DI ("__stack_chk_guard") [flags 0xc0]
<var_decl 0x7fb7e4364240 __stack_chk_guard>)
                        (const_int 1 [0x1])
                    ] UNSPEC_SALT_ADDR)))) -1
     (expr_list:REG_EQUAL (const:DI (unspec:DI [
                    (symbol_ref:DI ("__stack_chk_guard") [flags 0xc0] <var_decl
0x7fb7e4364240 __stack_chk_guard>)
                    (const_int 1 [0x1])
                ] UNSPEC_SALT_ADDR))
        (nil)))
k1n69laf.c:9:1: error: shared rtx
(const:DI (unspec:DI [
            (symbol_ref:DI ("__stack_chk_guard") [flags 0xc0] <var_decl
0x7fb7e4364240 __stack_chk_guard>)
            (const_int 1 [0x1])
        ] UNSPEC_SALT_ADDR))
during RTL pass: hoist
k1n69laf.c:9:1: internal compiler error: internal consistency failure
0xaf3439 verify_rtx_sharing
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-12.0.1_p20220313/work/gcc-12-20220313/gcc/emit-rtl.cc:2898
0xaf335d verify_rtx_sharing
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-12.0.1_p20220313/work/gcc-12-20220313/gcc/emit-rtl.cc:2913
0xaf335d verify_rtx_sharing
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-12.0.1_p20220313/work/gcc-12-20220313/gcc/emit-rtl.cc:2913
0xaf37cf verify_insn_sharing
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-12.0.1_p20220313/work/gcc-12-20220313/gcc/emit-rtl.cc:2984
0xaf883e verify_rtl_sharing()
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-12.0.1_p20220313/work/gcc-12-20220313/gcc/emit-rtl.cc:3007
0xe138f1 execute_function_todo
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-12.0.1_p20220313/work/gcc-12-20220313/gcc/passes.cc:2105
0xe13e4b execute_todo
       
/var/tmp/portage/cross-aarch64-linux-gnu/gcc-12.0.1_p20220313/work/gcc-12-20220313/gcc/passes.cc:2138

[Bug target/104910] [10/11/12 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-03-14
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52623
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52623&action=edit
gcc12-pr104910.patch

Untested fix.

[Bug target/104910] [10/11/12 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.4

[Bug target/104910] [10/11/12 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:952155629ca1a4dfe7c7b26e53d118a9b853ed4a

commit r12-7666-g952155629ca1a4dfe7c7b26e53d118a9b853ed4a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Mar 16 11:04:16 2022 +0100

    aarch64: Fix up RTL sharing bug in aarch64_load_symref_appropriately
[PR104910]

    We unshare all RTL created during expansion, but when
    aarch64_load_symref_appropriately is called after expansion like in the
    following testcases, we use imm in both HIGH and LO_SUM operands.
    If imm is some RTL that shouldn't be shared like a non-sharable CONST,
    we get at least with --enable-checking=rtl a checking ICE, otherwise might
    just get silently wrong code.

    The following patch fixes that by copying it if it can't be shared.

    2022-03-16  Jakub Jelinek  <jakub@redhat.com>

            PR target/104910
            * config/aarch64/aarch64.cc (aarch64_load_symref_appropriately):
Copy
            imm rtx.

            * gcc.dg/pr104910.c: New test.

[Bug target/104910] [10/11 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11/12 Regression] ICE:  |[10/11 Regression] ICE:
                   |internal consistency        |internal consistency
                   |failure (error: invalid rtl |failure (error: invalid rtl
                   |sharing found in the insn)  |sharing found in the insn)

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug target/104910] [10/11 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:9c3225c8b7c7f74a53aaae6ed5b6463b55bf7a92

commit r11-9728-g9c3225c8b7c7f74a53aaae6ed5b6463b55bf7a92
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Mar 16 11:04:16 2022 +0100

    aarch64: Fix up RTL sharing bug in aarch64_load_symref_appropriately
[PR104910]

    We unshare all RTL created during expansion, but when
    aarch64_load_symref_appropriately is called after expansion like in the
    following testcases, we use imm in both HIGH and LO_SUM operands.
    If imm is some RTL that shouldn't be shared like a non-sharable CONST,
    we get at least with --enable-checking=rtl a checking ICE, otherwise might
    just get silently wrong code.

    The following patch fixes that by copying it if it can't be shared.

    2022-03-16  Jakub Jelinek  <jakub@redhat.com>

            PR target/104910
            * config/aarch64/aarch64.c (aarch64_load_symref_appropriately):
Copy
            imm rtx.

            * gcc.dg/pr104910.c: New test.

    (cherry picked from commit 952155629ca1a4dfe7c7b26e53d118a9b853ed4a)

[Bug target/104910] [10 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11 Regression] ICE:     |[10 Regression] ICE:
                   |internal consistency        |internal consistency
                   |failure (error: invalid rtl |failure (error: invalid rtl
                   |sharing found in the insn)  |sharing found in the insn)

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.3 too.

[Bug target/104910] [10 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:c9b590a80fbe16a118acdbab15e6f82853db6806

commit r10-10695-gc9b590a80fbe16a118acdbab15e6f82853db6806
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Mar 16 11:04:16 2022 +0100

    aarch64: Fix up RTL sharing bug in aarch64_load_symref_appropriately
[PR104910]

    We unshare all RTL created during expansion, but when
    aarch64_load_symref_appropriately is called after expansion like in the
    following testcases, we use imm in both HIGH and LO_SUM operands.
    If imm is some RTL that shouldn't be shared like a non-sharable CONST,
    we get at least with --enable-checking=rtl a checking ICE, otherwise might
    just get silently wrong code.

    The following patch fixes that by copying it if it can't be shared.

    2022-03-16  Jakub Jelinek  <jakub@redhat.com>

            PR target/104910
            * config/aarch64/aarch64.c (aarch64_load_symref_appropriately):
Copy
            imm rtx.

            * gcc.dg/pr104910.c: New test.

    (cherry picked from commit 952155629ca1a4dfe7c7b26e53d118a9b853ed4a)

[Bug target/104910] [10 Regression] ICE: internal consistency failure (error: invalid rtl sharing found in the insn)

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104910

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 10.4 too.