public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/104970] [12 Regression] ICE in execute_todo, at passes.cc:2133 since r12-6480-gea19c8f33a3a8d2b
Date: Wed, 23 Mar 2022 07:28:19 +0000 [thread overview]
Message-ID: <bug-104970-4-ufUdAvCPxh@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-104970-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104970
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
If that works, please add at least a check that TREE_CODE (typesize) ==
INTEGER_CST (or perhaps also POLY_INT_CST) if it really needs to be multiplied
by the size of what the pointer points to. In which case the question is also
what should happen for void * parameters, the code right now doesn't multiply
it by anything in that case:
if (typesize)
sz = size_binop (MULT_EXPR, sz, typesize);
but IMHO it should give up for arbitrary incomplete types and just handle the
void * case (so punt on !typesize unless TREE_CODE (TREE_TYPE (TREE_TYPE
(parm))) == VOID_TYPE?).
The documentation says:
"The optional @var{size-index} positional argument denotes a function
argument of integer type that specifies the maximum size of the access.
The size is the number of elements of the type referenced by @var{ref-index},
or the number of bytes when the pointer type is @code{void*}."
so if you have struct S; void foo (struct S *p, int sz) with access attribute
I think you just want to punt.
next prev parent reply other threads:[~2022-03-23 7:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 15:24 [Bug tree-optimization/104970] New: " marxin at gcc dot gnu.org
2022-03-17 15:24 ` [Bug tree-optimization/104970] " marxin at gcc dot gnu.org
2022-03-17 17:50 ` siddhesh at gcc dot gnu.org
2022-03-21 11:59 ` [Bug tree-optimization/104970] [12 Regression] " jakub at gcc dot gnu.org
2022-03-21 12:19 ` jakub at gcc dot gnu.org
2022-03-21 17:19 ` msebor at gcc dot gnu.org
2022-03-21 17:22 ` msebor at gcc dot gnu.org
2022-03-21 18:18 ` jakub at gcc dot gnu.org
2022-03-22 0:25 ` msebor at gcc dot gnu.org
2022-03-23 5:56 ` siddhesh at gcc dot gnu.org
2022-03-23 7:28 ` jakub at gcc dot gnu.org [this message]
2022-03-23 15:34 ` msebor at gcc dot gnu.org
2022-03-24 9:40 ` cvs-commit at gcc dot gnu.org
2022-03-24 9:42 ` siddhesh at gcc dot gnu.org
2023-03-28 21:53 ` muecker at gwdg dot de
2023-03-29 11:15 ` siddhesh at gcc dot gnu.org
2023-03-30 17:17 ` muecker at gwdg dot de
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-104970-4-ufUdAvCPxh@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).