[Bug target/105002] New: [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[Bug target/105002] New: [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

            Bug ID: 105002
           Summary: [12 regression] gcc.target/powerpc/float128-minmax-3.c
                    fails starting with r12-7687-g3a7ba8fd0cda38
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:3a7ba8fd0cda387809e4902328af2473662b6a4a, r12-7687-g3a7ba8fd0cda38
make  -k check-gcc
RUNTESTFLAGS="powerpc.exp=gcc.target/powerpc/float128-minmax-3.c"
FAIL: gcc.target/powerpc/float128-minmax-3.c scan-assembler \\mxsmaxcqp\\M
FAIL: gcc.target/powerpc/float128-minmax-3.c scan-assembler \\mxsmincqp\\M

The new generated code is worse I believe.

seurer@rain6p1:~/gcc/git/build/gcc-test$ diff float128-minmax-3.s.r12-7686
float128-minmax-3.s.r12-7687
13c13,14
<       xsmincqp 2,2,3
---
> 	xscmpgtqp 0,3,2
> 	xxsel 34,35,34,32
28c29,30
<       xsmaxcqp 2,3,2
---
> 	xscmpgtqp 0,3,2
> 	xxsel 34,34,35,32

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Host|                            |powerpc64le-linux-gnu
                 CC|                            |bergner at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org
             Target|                            |powerpc64le-linux-gnu

--- Comment #1 from seurer at gcc dot gnu.org ---
Note:  Saw this on power 9 and power 10 LE machines.

commit 3a7ba8fd0cda387809e4902328af2473662b6a4a (HEAD, refs/bisect/bad)
Author: Richard Biener <rguenther@suse.de>
Date:   Thu Mar 17 08:10:59 2022 +0100

    tree-optimization/104960 - unsplit edges after late sinking

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |missed-optimization
   Target Milestone|---                         |12.0

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Sth similar as PR104982?  Thus likely a target pattern issue.  ppc folks should
investigate.

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |linkw at gcc dot gnu.org
                 CC|                            |linkw at gcc dot gnu.org

--- Comment #3 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #2)
> Sth similar as PR104982?  Thus likely a target pattern issue.  ppc folks
> should investigate.

Thanks for the hint, I'll have a look.

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

--- Comment #4 from Kewen Lin <linkw at gcc dot gnu.org> ---
Created attachment 52668
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52668&action=edit
Untested patch

Putting it through testing.

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-03-23
             Status|UNCONFIRMED                 |ASSIGNED

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

--- Comment #5 from Kewen Lin <linkw at gcc dot gnu.org> ---
Patch was just posted at
https://gcc.gnu.org/pipermail/gcc-patches/2022-March/592204.html.

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kewen Lin <linkw@gcc.gnu.org>:

https://gcc.gnu.org/g:83b43c74bbbdc6b6903350b220b932c6f774bdfd

commit r12-8010-g83b43c74bbbdc6b6903350b220b932c6f774bdfd
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Tue Apr 5 22:18:30 2022 -0500

    rs6000: Support UN[GL][ET] in rs6000_maybe_emit_maxc_minc [PR105002]

    Commit r12-7687 exposed one miss optimization chance in function
    rs6000_maybe_emit_maxc_minc, for now it only considers comparison
    codes GE/GT/LE/LT, but it can support more variants with codes
    UNLT/UNLE/UNGT/UNGE by reversing them into the equivalent ones
    with GE/GT/LE/LT.

    gcc/ChangeLog:

            PR target/105002
            * config/rs6000/rs6000.cc (rs6000_maybe_emit_maxc_minc): Support
more
            comparison codes UNLT/UNLE/UNGT/UNGE.

[Bug target/105002] [12 regression] gcc.target/powerpc/float128-minmax-3.c fails starting with r12-7687-g3a7ba8fd0cda38

[linkw at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105002

Kewen Lin <linkw at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Kewen Lin <linkw at gcc dot gnu.org> ---
Should be fixed on latest trunk.