[Bug other/105114] New: [12 regression] contrib/gcc_update hangs

[Bug other/105114] New: [12 regression] contrib/gcc_update hangs

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

            Bug ID: 105114
           Summary: [12 regression] contrib/gcc_update hangs
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

On one of our older, power 7 BE machines this starting happening recently:

seurer@bns:~/gcc/git/gcc-test$ ./contrib/gcc_update
Updating GIT tree
remote: Enumerating objects: 208, done.
remote: Counting objects: 100% (208/208), done.
remote: Compressing objects: 100% (122/122), done.
remote: Total 153 (delta 122), reused 43 (delta 30), pack-reused 0
Receiving objects: 100% (153/153), 29.38 KiB | 0 bytes/s, done.
Resolving deltas: 100% (122/122), completed with 53 local objects.
>From git://gcc.gnu.org/git/gcc
   eb59ddf..5db9ce1  master     -> origin/master
First, rewinding head to replay your work on top of it...
Fast-forwarded master to 5db9ce171019f8915885cebd5cc5f4101bb926e6.
Adjusting file timestamps
Touching gcc/config.in...
Touching gcc/config/loongarch/loongarch-str.h...
Touching gcc/config/loongarch/loongarch-str.h...
Touching gcc/config/loongarch/loongarch-str.h...
Touching gcc/config/loongarch/loongarch-str.h...
Touching gcc/config/loongarch/loongarch-str.h...
...etc. forever...


Looking at the script it is getting caught here:

    while ${MAKE-make} -s -f Makefile.$$ all | grep Touching > /dev/null; do
      sleep 1
    done 2>&1

If I run the make command by hand I do indeed just get that Touching message:

seurer@bns:~/gcc/git/gcc-test$ make -s -f Makefile.28475 all
Touching gcc/config/loongarch/loongarch-str.h...
Touching gcc/config/loongarch/loongarch-str.h...
seurer@bns:~/gcc/git/gcc-test$ make -s -f Makefile.28475 all
Touching gcc/config/loongarch/loongarch-str.h...
Touching gcc/config/loongarch/loongarch-str.h...

This works fine on all our other machines, even other older power 7s.  Any
ideas what might be going wrong?

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
I suggest to ping the loongarch folks.  Did you inspect the generated Makefile
to see if there's anything obviously "odd"?

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
This is just weird, all the files in question:
gcc/config/loongarch/loongarch-str.h
gcc/config/loongarch/genopts/genstr.sh
gcc/config/loongarch/genopts/loongarch-string
gcc/config/loongarch/loongarch.opt
gcc/config/loongarch/genopts/loongarch.opt.in
have been added in the same commit as
contrib/gcc_update has been updated.
So, if you still have a tree where it hangs, can you
ls -l gcc/config/loongarch/loongarch-str.h
gcc/config/loongarch/genopts/genstr.sh
gcc/config/loongarch/genopts/loongarch-string
gcc/config/loongarch/loongarch.opt
gcc/config/loongarch/genopts/loongarch.opt.in
?

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

--- Comment #3 from seurer at gcc dot gnu.org ---
I did look at the Makefile and didn't see anything that jumped out as weird.  I
will try comparing it to one that works.


Those files all exist.

-rwxr-xr-x 1 seurer users 2954 Mar 30 10:16
gcc/config/loongarch/genopts/genstr.sh
-rw-r--r-- 1 seurer users 5231 Mar 30 10:16
gcc/config/loongarch/genopts/loongarch.opt.in
-rw-r--r-- 1 seurer users 1756 Mar 30 15:14
gcc/config/loongarch/loongarch-str.h
-rw-r--r-- 1 seurer users 5011 Mar 30 10:16 gcc/config/loongarch/loongarch.opt

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Mar 30 15:14 is certainly much newer than Mar 30 10:16.
Perhaps try make -d -f Makefile.28475 all
?

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

--- Comment #5 from seurer at gcc dot gnu.org ---
The makefiles between systems were the same.

One thing that is different is make itself.  On another system where this was
working make was a later release.  So I grabbed the latest release of make on
the failing system, built and installed it, and the problem went away.

The failing make was 3.81.  I am going to try make 3.81 on a working system to
see if it then fails.

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #6 from seurer at gcc dot gnu.org ---
On a system where things were working I built and installed make 3.81.  Using
that I now get the same failure.

I will just use the newer make on the old system where things were failing.

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

--- Comment #7 from Andreas Schwab <schwab@linux-m68k.org> ---
contrib/gcc_update is supposed to work with any make, even non-GNU ones,
though.

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
One possibility would be 32-bit make binary using 32-bit stat syscalls and the
new files having non-representable ino_t values, so stat on those would appear
to fail.  But that is just a wild guess...

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[joseph at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

--- Comment #9 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
The dependencies in gcc_update refer to 
gcc/config/loongarch/genopts/loongarch-string which doesn't exist (should 
be loongarch-strings not loongarch-string, I suppose).  Maybe that's 
causing the problem?

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-03-31
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Sharp eyes...

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:562d014efadfef6628ae670049c2d92ff6b166f0

commit r12-7941-g562d014efadfef6628ae670049c2d92ff6b166f0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 31 19:21:00 2022 +0200

    contrib: Fix up spelling of loongarch-str.h dependency [PR105114]

    As found by Joseph, the dependency of
    gcc/config/loongarch/loongarch-str.h is spelled incorrectly,
    it should be
    gcc/config/loongarch/genopts/loongarch-strings
    but was using
    gcc/config/loongarch/genopts/loongarch-string

    2022-03-31  Jakub Jelinek  <jakub@redhat.com>
                Joseph Myers  <joseph@codesourcery.com>

            PR other/105114
            * gcc_update: Fix up spelling of
            gcc/config/loongarch/genopts/loongarch-strings dependency.

[Bug other/105114] [12 regression] contrib/gcc_update hangs

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105114

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Now fixed, thanks Joseph.