[Bug rtl-optimization/105333] New: [10/11/12 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre

[Bug rtl-optimization/105333] New: [10/11/12 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

            Bug ID: 105333
           Summary: [10/11/12 Regression] ICE: in simplify_subreg, at
                    simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars
                    -fno-tree-fre
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: rtl-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu

Created attachment 52845
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52845&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -Og -fno-tree-coalesce-vars -fno-tree-fre testcase.c 
during RTL pass: combine
testcase.c: In function 'foo':
testcase.c:17:1: internal compiler error: in simplify_subreg, at
simplify-rtx.cc:7346
   17 | }
      | ^
0x78410d simplify_context::simplify_subreg(machine_mode, rtx_def*,
machine_mode, poly_int<1u, unsigned long>)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:7346
0x136f624 simplify_context::simplify_subreg(machine_mode, rtx_def*,
machine_mode, poly_int<1u, unsigned long>)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:7444
0x1370958 simplify_context::simplify_gen_subreg(machine_mode, rtx_def*,
machine_mode, poly_int<1u, unsigned long>)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:7624
0xf6dbed lowpart_subreg(machine_mode, rtx_def*, machine_mode)
        /repo/gcc-trunk/gcc/rtl.h:3547
0xf6dbed gen_lowpart_common(machine_mode, rtx_def*)
        /repo/gcc-trunk/gcc/emit-rtl.cc:1617
0x22914bb gen_lowpart_for_combine
        /repo/gcc-trunk/gcc/combine.cc:11682
0x136ad76 simplify_context::simplify_unary_operation_1(rtx_code, machine_mode,
rtx_def*)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:1243
0x136e44f simplify_context::simplify_unary_operation(rtx_code, machine_mode,
rtx_def*, machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:893
0x136e44f simplify_context::simplify_gen_unary(rtx_code, machine_mode,
rtx_def*, machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:360
0x136aaf0 simplify_context::simplify_unary_operation_1(rtx_code, machine_mode,
rtx_def*)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:1232
0x136e44f simplify_context::simplify_unary_operation(rtx_code, machine_mode,
rtx_def*, machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:893
0x136e44f simplify_context::simplify_gen_unary(rtx_code, machine_mode,
rtx_def*, machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:360
0x136e5f8 simplify_context::simplify_truncation(machine_mode, rtx_def*,
machine_mode)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:652
0x136fb0e simplify_context::simplify_subreg(machine_mode, rtx_def*,
machine_mode, poly_int<1u, unsigned long>)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:7595
0x1370958 simplify_context::simplify_gen_subreg(machine_mode, rtx_def*,
machine_mode, poly_int<1u, unsigned long>)
        /repo/gcc-trunk/gcc/simplify-rtx.cc:7624
0x2291531 lowpart_subreg(machine_mode, rtx_def*, machine_mode)
        /repo/gcc-trunk/gcc/rtl.h:3547
0x2291531 gen_lowpart_for_combine
        /repo/gcc-trunk/gcc/combine.cc:11726
0x2288ee4 if_then_else_cond
        /repo/gcc-trunk/gcc/combine.cc:9357
0x2288fe5 if_then_else_cond
        /repo/gcc-trunk/gcc/combine.cc:9207
0x2288fe5 if_then_else_cond
        /repo/gcc-trunk/gcc/combine.cc:9207
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r12-8210-20220420174944-g6a4e9934545-checking-yes-rtl-df-extra-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/12.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=x86_64-pc-linux-gnu
--with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r12-8210-20220420174944-g6a4e9934545-checking-yes-rtl-df-extra-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.0.1 20220421 (experimental) (GCC)

[Bug rtl-optimization/105333] [10/11/12 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-04-21
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |segher at gcc dot gnu.org
   Target Milestone|---                         |10.4
           Priority|P3                          |P2

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

#1  0x000000000142c6af in simplify_context::simplify_subreg (
    this=0x7fffffffb3b8, outermode=E_SImode, op=0x7ffff668b5d0, 
    innermode=E_VOIDmode, byte=...)
(gdb) p debug_rtx( op)
(const_wide_int 0x0fffffffffffffffe)

(gdb) bt
#0  fancy_abort (
    file=0x2e7a200 "/home/rguenther/src/gcc3/gcc/simplify-rtx.cc", line=7346, 
    function=0x2e7e100 <simplify_context::simplify_subreg(machine_mode,
rtx_def*, machine_mode, poly_int<1u, unsigned long>)::__FUNCTION__>
"simplify_subreg")
    at /home/rguenther/src/gcc3/gcc/diagnostic.cc:2024
#1  0x000000000142c6af in simplify_context::simplify_subreg (
    this=0x7fffffffb3b8, outermode=E_SImode, op=0x7ffff668b5d0, 
    innermode=E_VOIDmode, byte=...)
    at /home/rguenther/src/gcc3/gcc/simplify-rtx.cc:7346
#2  0x000000000142cf56 in simplify_context::simplify_subreg (
    this=0x7fffffffb3b8, outermode=E_SImode, op=0x7ffff668b660, 
    innermode=E_DImode, byte=...)
    at /home/rguenther/src/gcc3/gcc/simplify-rtx.cc:7444
#3  0x000000000142dfd9 in simplify_context::simplify_gen_subreg (
    this=0x7fffffffb3b8, outermode=E_SImode, op=0x7ffff668b660, 
    innermode=E_DImode, byte=...)
    at /home/rguenther/src/gcc3/gcc/simplify-rtx.cc:7624
...
#7  0x00000000028becb7 in gen_lowpart_for_combine (omode=E_SImode, 
    x=0x7ffff668b660) at /home/rguenther/src/gcc3/gcc/combine.cc:11684
11684     result = gen_lowpart_common (omode, x);
#8  0x0000000001410622 in simplify_context::simplify_unary_operation_1 (
    this=0x7fffffffc988, code=TRUNCATE, mode=E_SImode, op=0x7ffff668b660)
    at /home/rguenther/src/gcc3/gcc/simplify-rtx.cc:1243

which does

      if (GET_MODE (op) != VOIDmode)
        {
          temp = simplify_truncation (mode, op, GET_MODE (op));
          if (temp)
            return temp;
        }

      /* If we know that the value is already truncated, we can
         replace the TRUNCATE with a SUBREG.  */
      if (known_eq (GET_MODE_NUNITS (mode), 1)
          && (TRULY_NOOP_TRUNCATION_MODES_P (mode, GET_MODE (op))
              || truncated_to_mode (mode, op)))
        {
          temp = rtl_hooks.gen_lowpart_no_emit (mode, op);

so we know 'op' is VOIDmode here but gen_lowpart_for_combine isn't
prepared for this?

[Bug rtl-optimization/105333] [10/11/12 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |ubizjak at gmail dot com
            Summary|[10/11/12 Regression] ICE:  |[10/11/12 Regression] ICE:
                   |in simplify_subreg, at      |in simplify_subreg, at
                   |simplify-rtx.cc:7346 with   |simplify-rtx.cc:7346 with
                   |-Og -fno-tree-coalesce-vars |-Og -fno-tree-coalesce-vars
                   |-fno-tree-fre               |-fno-tree-fre since
                   |                            |r10-1094-g9919f5fe87a3def1

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r10-1094-g9919f5fe87a3def1.

[Bug rtl-optimization/105333] [10/11/12 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52846
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52846&action=edit
gcc12-pr105333.patch

Untested fix.

[Bug rtl-optimization/105333] [10/11/12 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:7092b7aea122a91824d048aeb23834cf1d19b1a1

commit r12-8224-g7092b7aea122a91824d048aeb23834cf1d19b1a1
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Apr 22 13:38:11 2022 +0200

    rtlanal: Fix up replace_rtx [PR105333]

    The following testcase FAILs, because replace_rtx replaces a REG with
    CONST_WIDE_INT inside of a SUBREG, which is an invalid transformation
    because a SUBREG relies on SUBREG_REG having non-VOIDmode but
    CONST_WIDE_INT has VOIDmode.

    replace_rtx already has code to deal with it, but it was doing
    it only for CONST_INTs.  The following patch does it also for
    VOIDmode CONST_DOUBLE or CONST_WIDE_INT.

    2022-04-22  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/105333
            * rtlanal.cc (replace_rtx): Use simplify_subreg or
            simplify_unary_operation if CONST_SCALAR_INT_P rather than just
            CONST_INT_P.

            * gcc.dg/pr105333.c: New test.

[Bug rtl-optimization/105333] [10/11 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11/12 Regression] ICE:  |[10/11 Regression] ICE: in
                   |in simplify_subreg, at      |simplify_subreg, at
                   |simplify-rtx.cc:7346 with   |simplify-rtx.cc:7346 with
                   |-Og -fno-tree-coalesce-vars |-Og -fno-tree-coalesce-vars
                   |-fno-tree-fre since         |-fno-tree-fre since
                   |r10-1094-g9919f5fe87a3def1  |r10-1094-g9919f5fe87a3def1

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug rtl-optimization/105333] [10/11 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:70d8bd6edae08bfc520dfb4b455b4592e3e2afe9

commit r11-9962-g70d8bd6edae08bfc520dfb4b455b4592e3e2afe9
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Apr 22 13:38:11 2022 +0200

    rtlanal: Fix up replace_rtx [PR105333]

    The following testcase FAILs, because replace_rtx replaces a REG with
    CONST_WIDE_INT inside of a SUBREG, which is an invalid transformation
    because a SUBREG relies on SUBREG_REG having non-VOIDmode but
    CONST_WIDE_INT has VOIDmode.

    replace_rtx already has code to deal with it, but it was doing
    it only for CONST_INTs.  The following patch does it also for
    VOIDmode CONST_DOUBLE or CONST_WIDE_INT.

    2022-04-22  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/105333
            * rtlanal.c (replace_rtx): Use simplify_subreg or
            simplify_unary_operation if CONST_SCALAR_INT_P rather than just
            CONST_INT_P.

            * gcc.dg/pr105333.c: New test.

    (cherry picked from commit 7092b7aea122a91824d048aeb23834cf1d19b1a1)

[Bug rtl-optimization/105333] [10 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[10/11 Regression] ICE: in  |[10 Regression] ICE: in
                   |simplify_subreg, at         |simplify_subreg, at
                   |simplify-rtx.cc:7346 with   |simplify-rtx.cc:7346 with
                   |-Og -fno-tree-coalesce-vars |-Og -fno-tree-coalesce-vars
                   |-fno-tree-fre since         |-fno-tree-fre since
                   |r10-1094-g9919f5fe87a3def1  |r10-1094-g9919f5fe87a3def1

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 11.4 too.

[Bug rtl-optimization/105333] [10 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:daf9bd6c5c7835bdbca47c8f798bd110cc8f5be8

commit r10-10711-gdaf9bd6c5c7835bdbca47c8f798bd110cc8f5be8
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Apr 22 13:38:11 2022 +0200

    rtlanal: Fix up replace_rtx [PR105333]

    The following testcase FAILs, because replace_rtx replaces a REG with
    CONST_WIDE_INT inside of a SUBREG, which is an invalid transformation
    because a SUBREG relies on SUBREG_REG having non-VOIDmode but
    CONST_WIDE_INT has VOIDmode.

    replace_rtx already has code to deal with it, but it was doing
    it only for CONST_INTs.  The following patch does it also for
    VOIDmode CONST_DOUBLE or CONST_WIDE_INT.

    2022-04-22  Jakub Jelinek  <jakub@redhat.com>

            PR rtl-optimization/105333
            * rtlanal.c (replace_rtx): Use simplify_subreg or
            simplify_unary_operation if CONST_SCALAR_INT_P rather than just
            CONST_INT_P.

            * gcc.dg/pr105333.c: New test.

    (cherry picked from commit 7092b7aea122a91824d048aeb23834cf1d19b1a1)

[Bug rtl-optimization/105333] [10 Regression] ICE: in simplify_subreg, at simplify-rtx.cc:7346 with -Og -fno-tree-coalesce-vars -fno-tree-fre since r10-1094-g9919f5fe87a3def1

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105333

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 10.4 too.