[Bug plugins/105364] New: lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[Bug plugins/105364] New: lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[wavexx at thregr dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

            Bug ID: 105364
           Summary: lto-wrapper generates URLs escape sequences despite
                    -fdiagnostic-urls=never
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: plugins
          Assignee: unassigned at gcc dot gnu.org
          Reporter: wavexx at thregr dot org
  Target Milestone: ---

Warnings generated by lto-wrapper do not seem to check the current terminal
settings (TERM=dumb doesn't do anything useful) and/or even respect
-fdiagnostics-urls=never provided while linking:

gcc -Wl,--as-needed -fdiagnostics-urls=never -fPIE -pie -fuse-ld=mold -flto -o
spectrwm spectrwm.o linux.o -lX11-xcb -lX11 -lxcb-icccm -lxcb-keysyms
-lxcb-randr -lxcb-util -lxcb -lxcb-xinput -lxcb-xtest -lXcursor -lXft 
lto-wrapper: warning: using serial compilation of 3 LTRANS jobs
lto-wrapper: note: see the
]8;;https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#index-flto‘-flto’
option documentation]8;; for more information

(note the inline escape ESC ] 8)

% gcc --version
gcc (Debian 12-20220319-1) 12.0.1 20220319 (experimental) [master
r12-7719-g8ca61ad148f]

[Bug lto/105364] lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
          Component|plugins                     |lto

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug lto/105364] lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2022-04-25
     Ever confirmed|0                           |1

[Bug lto/105364] lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Let me fix that.

[Bug lto/105364] lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:cd4acb8cd9e45fd35664baa5b0a3150e479aae32

commit r12-8269-gcd4acb8cd9e45fd35664baa5b0a3150e479aae32
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Apr 26 09:56:37 2022 +0200

    lto: use diagnostics_context in print_lto_docs_link

    Properly parse OPT_fdiagnostics_urls_ and then initialize both urls
    and colors for global_dc. Doing that we would follow the configure
    option --with-documentation-root-url, -fdiagnostics-urls is respected.
    Plus we'll print colored warning and note messages.

            PR lto/105364

    gcc/ChangeLog:

            * lto-wrapper.cc (print_lto_docs_link): Use global_dc.
            (run_gcc): Parse OPT_fdiagnostics_urls_.
            (main): Initialize global_dc.

[Bug lto/105364] lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.

[Bug lto/105364] lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[wavexx at thregr dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

--- Comment #5 from wavexx at thregr dot org ---
Verified today on debian unstable which just updated the gcc12 snapshot.
Thx for the quick fix to all.

[Bug lto/105364] lto-wrapper generates URLs escape sequences despite -fdiagnostic-urls=never

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105364

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0