public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/105415] [9/10/11/12 Regression] '-fcompare-debug' failure w/ -O2 -ftree-parallelize-loops=2 since r7-4900-g59ec925b1199f9
Date: Thu, 28 Apr 2022 10:04:48 +0000	[thread overview]
Message-ID: <bug-105415-4-TCYzgOAkje@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105415-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105415

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Wonder about:
--- gcc/alias.cc.jj     2022-02-21 16:51:50.261232505 +0100
+++ gcc/alias.cc        2022-04-28 11:57:18.940425126 +0200
@@ -2219,8 +2219,10 @@ compare_base_symbol_refs (const_rtx x_ba
          || (!TREE_STATIC (x_decl) && !TREE_PUBLIC (x_decl)))
        return 0;

-      symtab_node *x_node = symtab_node::get_create (x_decl)
-                           ->ultimate_alias_target ();
+      symtab_node *x_node = symtab_node::get (x_decl);
+      if (x_node == NULL)
+       return 0;
+      x_node = x_node->ultimate_alias_target ();
       /* External variable cannot be in section anchor.  */
       if (!x_node->definition)
        return 0;
It would surprise me if we needed to create varpool nodes so late, if they
don't exist, with the exception of DEBUG_INSNs referencing already removed
symbols I don't see the reason why the varpool nodes wouldn't be present.
Another option would be for the x_node == NULL case to use x_decl rather than
x_node->decl, i.e. just assume x_decl isn't an alias if it doesn't have a
varpool node.

  parent reply	other threads:[~2022-04-28 10:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  2:43 [Bug debug/105415] New: [10/11/12 Regression] '-fcompare-debug' failure w/ -O2 -ftree-parallelize-loops=2 asolokha at gmx dot com
2022-04-28  7:08 ` [Bug debug/105415] " rguenth at gcc dot gnu.org
2022-04-28  7:34 ` marxin at gcc dot gnu.org
2022-04-28  8:24 ` [Bug debug/105415] [9/10/11/12 Regression] '-fcompare-debug' failure w/ -O2 -ftree-parallelize-loops=2 since r7-4900-g59ec925b1199f9 marxin at gcc dot gnu.org
2022-04-28  9:57 ` jakub at gcc dot gnu.org
2022-04-28 10:04 ` jakub at gcc dot gnu.org [this message]
2022-04-28 11:51 ` jakub at gcc dot gnu.org
2022-05-02  9:34 ` [Bug debug/105415] [9/10/11/12/13 " cvs-commit at gcc dot gnu.org
2022-05-02  9:36 ` [Bug debug/105415] [9/10/11/12 " jakub at gcc dot gnu.org
2022-05-17 12:08 ` [Bug debug/105415] [9/10/11/12/13 " asolokha at gmx dot com
2022-05-17 12:24 ` jakub at gcc dot gnu.org
2022-06-28 10:49 ` [Bug debug/105415] [10/11/12 " jakub at gcc dot gnu.org
2022-07-26 11:44 ` rguenth at gcc dot gnu.org
2023-07-07 10:43 ` [Bug middle-end/105415] [11/12 " rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105415-4-TCYzgOAkje@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).