[Bug tree-optimization/105458] New: [12/13 Regression] ICE in set_relation, at value-relation.cc:609

[Bug tree-optimization/105458] New: [12/13 Regression] ICE in set_relation, at value-relation.cc:609

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105458

            Bug ID: 105458
           Summary: [12/13 Regression] ICE in set_relation, at
                    value-relation.cc:609
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc 12.0.1 20220424 snapshot (g:6b7441a46c771aa6ecdc0c8ed96197417d036b9a) ICEs
when compiling gcc/testsuite/gcc.dg/torture/pr83418.c w/ -O1
-fexpensive-optimizations -fno-tree-dominator-opts:

% gcc-12.0.1 -O1 -fexpensive-optimizations -fno-tree-dominator-opts -c
gcc/testsuite/gcc.dg/torture/pr83418.c
during GIMPLE pass: threadfull
gcc/testsuite/gcc.dg/torture/pr83418.c: In function 'yj':
gcc/testsuite/gcc.dg/torture/pr83418.c:4:1: internal compiler error: in
set_relation, at value-relation.cc:609
    4 | yj (int j4)
      | ^~
0x7a2b0b value_relation::set_relation(tree_code, tree_node*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/value-relation.cc:609
0x7a2b0b value_relation::value_relation(tree_code, tree_node*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/value-relation.cc:630
0x7a2b0b path_oracle::register_relation(basic_block_def*, tree_code,
tree_node*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/value-relation.cc:1385
0x1c84309 fur_source::register_outgoing_edges(gcond*, irange&, edge_def*,
edge_def*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/gimple-range-fold.cc:1522
0x1c85106 fold_using_range::range_of_range_op(irange&, gimple*, fur_source&)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/gimple-range-fold.cc:665
0x1c87005 fold_using_range::fold_stmt(irange&, gimple*, fur_source&,
tree_node*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/gimple-range-fold.cc:554
0x1082e93 path_range_query::range_of_stmt(irange&, gimple*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/gimple-range-path.cc:767
0x110a659 back_threader::find_taken_edge_cond(vec<basic_block_def*, va_heap,
vl_ptr> const&, gcond*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/tree-ssa-threadbackward.cc:320
0x110b01f back_threader::maybe_register_path()
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/tree-ssa-threadbackward.cc:232
0x110b7c4 back_threader::find_paths_to_names(basic_block_def*, bitmap_head*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/tree-ssa-threadbackward.cc:419
0x110b762 back_threader::find_paths_to_names(basic_block_def*, bitmap_head*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/tree-ssa-threadbackward.cc:459
0x110bb22 back_threader::find_paths(basic_block_def*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/tree-ssa-threadbackward.cc:493
0x110bd41 back_threader::thread_blocks()
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/tree-ssa-threadbackward.cc:901
0x110be23 execute
       
/var/tmp/portage/sys-devel/gcc-12.0.1_p20220424/work/gcc-12-20220424/gcc/tree-ssa-threadbackward.cc:1031

[Bug tree-optimization/105458] [12/13 Regression] ICE in set_relation, at value-relation.cc:609

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105458

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-05-03
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |amacleod at redhat dot com
     Ever confirmed|0                           |1
   Target Milestone|---                         |12.0
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |ice-checking

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.  There is the unfolded t3_t > t3_6 which eventually makes us run
into
the assert.  We shouldn't assert that everything is correctly folded so we have
to be forgiving here (maybe just not registering anything here).  It might be
that when setting name1 == name2 that we'd run into compile-time issues.
Andrew should know how to avoid this ICE best.

<bb 3> [local count: 117688337]:
_7 = t3_6 > t3_6;
_8 = t3_6 == j4_5(D);
_9 = _8 | _7;
if (_9 != 0)
  goto <bb 4>; [7.19%]
else
  goto <bb 10>; [92.81%]

[Bug tree-optimization/105458] [12/13 Regression] ICE in set_relation, at value-relation.cc:609 since r12-4790-g4b3a325f07acebf4

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105458

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org
            Summary|[12/13 Regression] ICE in   |[12/13 Regression] ICE in
                   |set_relation, at            |set_relation, at
                   |value-relation.cc:609       |value-relation.cc:609 since
                   |                            |r12-4790-g4b3a325f07acebf4

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r12-4790-g4b3a325f07acebf4.

[Bug tree-optimization/105458] [12/13 Regression] ICE in set_relation, at value-relation.cc:609 since r12-4790-g4b3a325f07acebf4

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105458

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.0                        |12.2

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
GCC 12.1 is being released, retargeting bugs to GCC 12.2.

[Bug tree-optimization/105458] [12/13 Regression] ICE in set_relation, at value-relation.cc:609 since r12-4790-g4b3a325f07acebf4

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105458

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:6101a276c34b94f692206739d98aa7faf2e7b2ad

commit r13-564-g6101a276c34b94f692206739d98aa7faf2e7b2ad
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Mon May 16 21:39:30 2022 -0400

    Check for equivalence after merging relations.

    When registering a relation, we need to merge with any existing relation
    before checking if it was an equivalence... otherwise it was not being
    handled properly.

            gcc/
            PR tree-optimization/105458
            * value-relation.cc (path_oracle::register_relation): Merge, then
check
            for equivalence.

            gcc/testsuite/
            * gcc.dg/pr105458.c: New.

[Bug tree-optimization/105458] [12/13 Regression] ICE in set_relation, at value-relation.cc:609 since r12-4790-g4b3a325f07acebf4

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105458

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Andrew Macleod
<amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:9c8125b98cdd406fbad09995529a5c6acffdd928

commit r12-8393-g9c8125b98cdd406fbad09995529a5c6acffdd928
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Tue May 17 09:36:39 2022 -0400

    Check for equivalence after merging relations.

    When registering a relation, we need to merge with any existing relation
    before checking if it was an equivalence... otherwise it was not being
    handled properly.

            gcc/
            PR tree-optimization/105458
            * value-relation.cc (path_oracle::register_relation): Merge, then
check
            for equivalence.

            gcc/testsuite/
            * gcc.dg/pr105458.c: New.

[Bug tree-optimization/105458] [12/13 Regression] ICE in set_relation, at value-relation.cc:609 since r12-4790-g4b3a325f07acebf4

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105458

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|                            |12.1.0
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.