[Bug tree-optimization/105484] New: [12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop

[Bug tree-optimization/105484] New: [12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

            Bug ID: 105484
           Summary: [12/13 Regression] ICE: verify_flow_info failed: BB 2
                    cannot throw but has an EH edge with -Os
                    -march=cannonlake -fnon-call-exceptions -fno-tree-dce
                    -fno-tree-forwprop
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu

Created attachment 52927
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52927&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -Os -march=cannonlake -fnon-call-exceptions
-fno-tree-dce -fno-tree-forwprop testcase.c 
testcase.c: In function 'foo':
testcase.c:6:1: error: BB 2 cannot throw but has an EH edge
    6 | foo (int i)
      | ^~~
during GIMPLE pass: isel
testcase.c:6:1: internal compiler error: verify_flow_info failed
0xee6463 verify_flow_info()
        /repo/gcc-trunk/gcc/cfghooks.cc:284
0x12f730a execute_function_todo
        /repo/gcc-trunk/gcc/passes.cc:2097
0x12f788b execute_todo
        /repo/gcc-trunk/gcc/passes.cc:2139
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r13-112-20220504095402-g9c6a4beeed5-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/13.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-112-20220504095402-g9c6a4beeed5-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20220504 (experimental) (GCC)

[Bug tree-optimization/105484] [11/12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
            Summary|[12/13 Regression] ICE:     |[11/12/13 Regression] ICE:
                   |verify_flow_info failed: BB |verify_flow_info failed: BB
                   |2 cannot throw but has an   |2 cannot throw but has an
                   |EH edge with -Os            |EH edge with -Os
                   |-march=cannonlake           |-march=cannonlake
                   |-fnon-call-exceptions       |-fnon-call-exceptions
                   |-fno-tree-dce               |-fno-tree-dce
                   |-fno-tree-forwprop          |-fno-tree-forwprop since
                   |                            |r11-5074-g287cc750b0887e86
                 CC|                            |crazylht at gmail dot com,
                   |                            |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2022-05-04
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
With -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce
-fno-tree-forwprop -c -fexceptions it started with r11-5074-g287cc750b0887e86.

[Bug target/105484] [11/12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

--- Comment #2 from Hongtao.liu <crazylht at gmail dot com> ---
I'll take a look.

[Bug target/105484] [11/12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[crazylht at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

--- Comment #3 from Hongtao.liu <crazylht at gmail dot com> ---
Similar like PR104450, don't expand stmt to vec_set when there's EH on it.

[Bug target/105484] [11/12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.4
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
@@ -8,11 +21,15 @@
   int _1;
   complex int _4;
   void * _10;
+  vector(4) int _12;
+  vector(4) int _13;

   <bb 2> [local count: 1073741824]:
   _4 = .MUL_OVERFLOW (i_3(D), 7);
   _1 = REALPART_EXPR <_4>;
-  VIEW_CONVERT_EXPR<int[4]>(v)[i_3(D)] = _1;
+  _12 = v;
+  _13 = .VEC_SET (_12, _1, i_3(D));
+  v = _13;

   <bb 3> [local count: 1073741824]:
   bar (0);


now I think in this case we can simply clear EH since the replacement can
no longer throw.

[Bug target/105484] [11/12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Created attachment 52929
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52929&action=edit
patch in testing

[Bug target/105484] [11/12/13 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:e1a41143a2e24c65d94364fd82b165ff71a759d8

commit r13-129-ge1a41143a2e24c65d94364fd82b165ff71a759d8
Author: Richard Biener <rguenther@suse.de>
Date:   Thu May 5 09:34:59 2022 +0200

    tree-optimization/105484 - VEC_SET and EH

    When the IL representation of VEC_SET is marked as throwing
    (unnecessarily), we need to clean that when replacing it with
    the .VEC_SET internal function call which cannot throw.

    2022-05-05  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/105484
            * gimple-isel.cc (gimple_expand_vec_set_expr): Clean EH, return
            whether the CFG changed.
            (gimple_expand_vec_exprs): When the CFG changed, clean it up.

            * gcc.dg/torture/pr105484.c: New testcase.

[Bug target/105484] [11/12 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|13.0                        |
           Priority|P3                          |P2
      Known to work|                            |13.0
            Summary|[11/12/13 Regression] ICE:  |[11/12 Regression] ICE:
                   |verify_flow_info failed: BB |verify_flow_info failed: BB
                   |2 cannot throw but has an   |2 cannot throw but has an
                   |EH edge with -Os            |EH edge with -Os
                   |-march=cannonlake           |-march=cannonlake
                   |-fnon-call-exceptions       |-fnon-call-exceptions
                   |-fno-tree-dce               |-fno-tree-dce
                   |-fno-tree-forwprop since    |-fno-tree-forwprop since
                   |r11-5074-g287cc750b0887e86  |r11-5074-g287cc750b0887e86

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug target/105484] [11/12 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:f2c2ebb9eed4fa38a3e56dad4a2339a989b11e87

commit r12-8345-gf2c2ebb9eed4fa38a3e56dad4a2339a989b11e87
Author: Richard Biener <rguenther@suse.de>
Date:   Thu May 5 09:34:59 2022 +0200

    tree-optimization/105484 - VEC_SET and EH

    When the IL representation of VEC_SET is marked as throwing
    (unnecessarily), we need to clean that when replacing it with
    the .VEC_SET internal function call which cannot throw.

    2022-05-05  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/105484
            * gimple-isel.cc (gimple_expand_vec_set_expr): Clean EH, return
            whether the CFG changed.
            (gimple_expand_vec_exprs): When the CFG changed, clean it up.

            * gcc.dg/torture/pr105484.c: New testcase.

    (cherry picked from commit e1a41143a2e24c65d94364fd82b165ff71a759d8)

[Bug target/105484] [11 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:caf0a30b17a639ee19ff4c138d3be0325d0be745

commit r11-10632-gcaf0a30b17a639ee19ff4c138d3be0325d0be745
Author: Richard Biener <rguenther@suse.de>
Date:   Thu May 5 09:34:59 2022 +0200

    tree-optimization/105484 - VEC_SET and EH

    When the IL representation of VEC_SET is marked as throwing
    (unnecessarily), we need to clean that when replacing it with
    the .VEC_SET internal function call which cannot throw.

    2022-05-05  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/105484
            * gimple-isel.cc (gimple_expand_vec_set_expr): Clean EH, return
            whether the CFG changed.
            (gimple_expand_vec_exprs): When the CFG changed, clean it up.

            * gcc.dg/torture/pr105484.c: New testcase.

    (cherry picked from commit e1a41143a2e24c65d94364fd82b165ff71a759d8)

[Bug target/105484] [11 Regression] ICE: verify_flow_info failed: BB 2 cannot throw but has an EH edge with -Os -march=cannonlake -fnon-call-exceptions -fno-tree-dce -fno-tree-forwprop since r11-5074-g287cc750b0887e86

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105484

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to fail|                            |11.3.0
         Resolution|---                         |FIXED
      Known to work|                            |11.3.1

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.