public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/105513] [10/11/12/13 Regression] Unnecessary SSE spill since r9-5748-g1d4b4f4979171ef0 Date: Wed, 08 Jun 2022 03:24:53 +0000 [thread overview] Message-ID: <bug-105513-4-HIxgX7bqx1@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-105513-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105513 --- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>: https://gcc.gnu.org/g:5e005393d4ff0a428c5f55b9ba7f65d6078a7cf5 commit r13-1009-g5e005393d4ff0a428c5f55b9ba7f65d6078a7cf5 Author: liuhongt <hongtao.liu@intel.com> Date: Mon May 30 15:30:51 2022 +0800 Disparages SSE_REGS alternatives sligntly with ?v instead of *v in *mov{si,di}_internal. So alternative v won't be igored in record_reg_classess. Similar for *r alternatives in some vector patterns. It helps testcase in the PR, also RA now makes better decisions for gcc.target/i386/extract-insert-combining.c movd %esi, %xmm0 movd %edi, %xmm1 - movl %esi, -12(%rsp) paddd %xmm0, %xmm1 pinsrd $0, %esi, %xmm0 paddd %xmm1, %xmm0 The patch has no big impact on SPEC2017 for both O2 and Ofast march=native run. And I noticed there's some changes in SPEC2017 from code like mov mem, %eax vmovd %eax, %xmm0 .. mov %eax, 64(%rsp) to vmovd mem, %xmm0 .. vmovd %xmm0, 64(%rsp) Which should be exactly what we want? gcc/ChangeLog: PR target/105513 PR target/105504 * config/i386/i386.md (*movsi_internal): Change alternative from *v to ?v. (*movdi_internal): Ditto. * config/i386/sse.md (vec_set<mode>_0): Change alternative *r to ?r. (*vec_extractv4sf_mem): Ditto. (*vec_extracthf): Ditto. gcc/testsuite/ChangeLog: * gcc.target/i386/pr105513-1.c: New test. * gcc.target/i386/extract-insert-combining.c: Add new scan-assembler-not for spill.
next prev parent reply other threads:[~2022-06-08 3:24 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-07 8:24 [Bug rtl-optimization/105513] New: [9/10/11/12/13 Regression] Unnecessary SSE spill amonakov at gcc dot gnu.org 2022-05-09 6:50 ` [Bug rtl-optimization/105513] [9/10/11/12/13 Regression] Unnecessary SSE spill since r9-5748-g1d4b4f4979171ef0 marxin at gcc dot gnu.org 2022-05-09 6:57 ` [Bug target/105513] " pinskia at gcc dot gnu.org 2022-05-09 8:05 ` rguenth at gcc dot gnu.org 2022-05-09 13:32 ` crazylht at gmail dot com 2022-05-10 7:24 ` ubizjak at gmail dot com 2022-05-13 7:10 ` crazylht at gmail dot com 2022-05-16 3:06 ` crazylht at gmail dot com 2022-05-20 8:29 ` crazylht at gmail dot com 2022-05-20 9:02 ` amonakov at gcc dot gnu.org 2022-05-20 9:12 ` crazylht at gmail dot com 2022-05-27 9:48 ` [Bug target/105513] [10/11/12/13 " rguenth at gcc dot gnu.org 2022-06-08 3:24 ` cvs-commit at gcc dot gnu.org [this message] 2022-06-28 10:49 ` jakub at gcc dot gnu.org 2023-07-07 10:43 ` [Bug target/105513] [11/12/13/14 " rguenth at gcc dot gnu.org 2024-02-21 4:52 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-105513-4-HIxgX7bqx1@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).