[Bug target/105602] New: [OpenMP][gcn] — Support multiple arch in gcc/config/gcn/t-omp-device? Add 'amdgcn' (additionally to/instead of 'amd')

[Bug target/105602] New: [OpenMP][gcn] — Support multiple arch in gcc/config/gcn/t-omp-device? Add 'amdgcn' (additionally to/instead of 'amd')

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105602

            Bug ID: 105602
           Summary: [OpenMP][gcn] — Support multiple arch in
                    gcc/config/gcn/t-omp-device? Add 'amdgcn'
                    (additionally to/instead of 'amd')
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: burnus at gcc dot gnu.org
                CC: ams at gcc dot gnu.org, jakub at gcc dot gnu.org
  Target Milestone: ---

I note that GCC has in gcc/config/gcn/t-omp-device:
        echo kind: gpu > $@
        echo arch: gcn >> $@
        echo isa: fiji gfx900 gfx906 gfx908 >> $@

That is, GCC supports as context selector:
   match(construct={target},device={arch(gcn)})

In contrast, llvm has, e.g. in clang/lib/Headers/openmp_wrappers/cmath:
   #pragma omp begin declare variant match(device = {arch(amdgcn)})

Thus: LLVM uses 'amdgcn'.

Expected: arch = 'amdgcn' (also) works in GCC for better compatibility. I did
not find a documentation and I think either variant is fine – albeit 'amdgcn'
seems to be more natural.

[Bug target/105602] [OpenMP][gcn] — Support multiple arch in gcc/config/gcn/t-omp-device? Add 'amdgcn' (additionally to/instead of 'amd')

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105602

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:ebe5dace8c318b38f42cfe1d148e90dcdfadb31e

commit r13-557-gebe5dace8c318b38f42cfe1d148e90dcdfadb31e
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue May 17 15:48:40 2022 +0200

    gcn/t-omp-device: Add 'amdgcn' as 'arch' [PR105602]

    Improve cross-compiler handling.

    gcc/ChangeLog:

            PR target/105602
            * config/gcn/t-omp-device (arch): Add 'amdgcn' besides existing
'gcn'.
            * config/gcn/gcn.cc (gcn_omp_device_kind_arch_isa): Likewise.

[Bug target/105602] [OpenMP][gcn] — Support multiple arch in gcc/config/gcn/t-omp-device? Add 'amdgcn' (additionally to/instead of 'amd')

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105602

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
FIXED – by now supporting both 'amdgcn' besides 'gcn'.

Side the permitted values are now also documented in
  https://gcc.gnu.org/onlinedocs/libgomp/
via/since commit r13-558-g61fe7b7d463f2f6bbeb175c345a68b844b396d56