[Bug c/105635] New: [12/13 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592

[Bug c/105635] New: [12/13 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592

[gscfq@t-online.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

            Bug ID: 105635
           Summary: [12/13 Regression] ICE in gimple_parm_array_size, at
                    pointer-query.cc:592
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: gscfq@t-online.de
  Target Milestone: ---

Started between 20220109 and 20220116 :


$ cat z1.c
void f (int, int[*]);
f (int x, int y)
{
  return (x >= 0) != (y < 0);
}


$ gcc-13-20220515 -c z1.c -Wall
z1.c:2:1: warning: return type defaults to 'int' [-Wimplicit-int]
    2 | f (int x, int y)
      | ^
z1.c:2:1: warning: conflicting types for 'f'
z1.c:1:6: note: previous declaration of 'f' with type 'void(int,  int *)'
    1 | void f (int, int[*]);
      |      ^
z1.c: In function 'f':
z1.c:4:19: warning: 'return' with a value, in function returning void
[-Wreturn-type]
    4 |   return (x >= 0) != (y < 0);
      |          ~~~~~~~~~^~~~~~~~~~
z1.c:2:1: note: declared here
    2 | f (int x, int y)
      | ^
during GIMPLE pass: waccess
z1.c:5:1: internal compiler error: Segmentation fault
    5 | }
      | ^
0xc23a6f crash_signal
        ../../gcc/toplev.cc:322
0xb5ba8b gimple_parm_array_size
        ../../gcc/pointer-query.cc:592
0xb5ba8b handle_ssa_name
        ../../gcc/pointer-query.cc:2087
0xb5d3ec compute_objsize_r
        ../../gcc/pointer-query.cc:2322
0xb6047a compute_objsize(tree_node*, gimple*, int, access_ref*, pointer_query*)
        ../../gcc/pointer-query.cc:2356
0xb60625 pointer_query::get_ref(tree_node*, gimple*, access_ref*, int)
        ../../gcc/pointer-query.cc:1506
0x9624a9 check_dangling_stores
        ../../gcc/gimple-ssa-warn-access.cc:4573
0x962350 check_dangling_stores
        ../../gcc/gimple-ssa-warn-access.cc:4605
0x962350 check_dangling_stores
        ../../gcc/gimple-ssa-warn-access.cc:4605
0x9690a4 check_dangling_stores
        ../../gcc/gimple-ssa-warn-access.cc:4617
0x9690a4 execute
        ../../gcc/gimple-ssa-warn-access.cc:4748

[Bug c/105635] [12/13 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592 since r12-6606-g9d6a0f388eb048f8

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |msebor at gcc dot gnu.org
   Last reconfirmed|                            |2022-05-18
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
            Summary|[12/13 Regression] ICE in   |[12/13 Regression] ICE in
                   |gimple_parm_array_size, at  |gimple_parm_array_size, at
                   |pointer-query.cc:592        |pointer-query.cc:592 since
                   |                            |r12-6606-g9d6a0f388eb048f8

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
It's there since -Wdangling-pointer revision (r12-6606-g9d6a0f388eb048f8).

[Bug c/105635] [12/13 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592 since r12-6606-g9d6a0f388eb048f8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 52989
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52989&action=edit
gcc13-pr105635.patch

Only lightly tested so far.  The function comment talks about pointers only,
TREE_TYPE (TREE_TYPE (var)) means it would work only for pointers/references,
array types and vector/complex somehow, but for vector/complex would certainly
do something the code doesn't expect and for array types at least in C/C++ no
arguments should have array type and the attribute is only done for c-family.

[Bug c/105635] [12/13 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592 since r12-6606-g9d6a0f388eb048f8

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
   Target Milestone|---                         |12.2

[Bug c/105635] [12/13 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592 since r12-6606-g9d6a0f388eb048f8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:3b4daa0b3c3d8eb2ac3b40ad6898f314ed4d7919

commit r13-630-g3b4daa0b3c3d8eb2ac3b40ad6898f314ed4d7919
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu May 19 11:56:21 2022 +0200

    pointer-query: Fix ICE with non-pointer param [PR105635]

    The gimple_parm_array_size function comment talks about pointe parameters
    but doesn't actually verify it, it checks whether an attribute is present
    on the function and then just uses TREE_TYPE (TREE_TYPE (var)) which
    assumes a pointer type (or in theory could work for ARRAY_TYPE but
    c-family languages which only have that attribute will never have
ARRAY_TYPE
    parameters; and for VECTOR_TYPE/COMPLEX_TYPE it would mean something quite
    different).

    So, this patch punts early if var doesn't have pointer/reference type.

    2022-05-19  Jakub Jelinek  <jakub@redhat.com>

            PR c/105635
            * pointer-query.cc (gimple_parm_array_size): Return NULL if var
            doesn't have pointer or reference type.

            * gcc.dg/pr105635.c: New test.

[Bug c/105635] [12 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592 since r12-6606-g9d6a0f388eb048f8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[12/13 Regression] ICE in   |[12 Regression] ICE in
                   |gimple_parm_array_size, at  |gimple_parm_array_size, at
                   |pointer-query.cc:592 since  |pointer-query.cc:592 since
                   |r12-6606-g9d6a0f388eb048f8  |r12-6606-g9d6a0f388eb048f8

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed on the trunk so far.

[Bug c/105635] [12 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592 since r12-6606-g9d6a0f388eb048f8

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:7b88f9b8881b7653b5a834da1b2b8fda463e61c0

commit r12-8432-g7b88f9b8881b7653b5a834da1b2b8fda463e61c0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu May 19 11:56:21 2022 +0200

    pointer-query: Fix ICE with non-pointer param [PR105635]

    The gimple_parm_array_size function comment talks about pointe parameters
    but doesn't actually verify it, it checks whether an attribute is present
    on the function and then just uses TREE_TYPE (TREE_TYPE (var)) which
    assumes a pointer type (or in theory could work for ARRAY_TYPE but
    c-family languages which only have that attribute will never have
ARRAY_TYPE
    parameters; and for VECTOR_TYPE/COMPLEX_TYPE it would mean something quite
    different).

    So, this patch punts early if var doesn't have pointer/reference type.

    2022-05-19  Jakub Jelinek  <jakub@redhat.com>

            PR c/105635
            * pointer-query.cc (gimple_parm_array_size): Return NULL if var
            doesn't have pointer or reference type.

            * gcc.dg/pr105635.c: New test.

    (cherry picked from commit 3b4daa0b3c3d8eb2ac3b40ad6898f314ed4d7919)

[Bug c/105635] [12 Regression] ICE in gimple_parm_array_size, at pointer-query.cc:592 since r12-6606-g9d6a0f388eb048f8

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105635

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed for 12.2 too.