[Bug c/105660] New: ICE on aarch64 in warn_parm_array_mismatch

[Bug c/105660] New: ICE on aarch64 in warn_parm_array_mismatch

[julie.gaspar at sipearl dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

            Bug ID: 105660
           Summary: ICE on aarch64 in warn_parm_array_mismatch
           Product: gcc
           Version: 12.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: julie.gaspar at sipearl dot com
  Target Milestone: ---

Created attachment 52998
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=52998&action=edit
preprocessed file of conservar.c

//--Description--//

While testing the Hydro benchmark on Arm architecture, building the version in
Hydro/HydroC/HydroC99_2DMpi from: https://github.com/HydroBench/Hydro.git with
gcc 12.1.0, the compilation generates an ICE. Gcc version 11.2.0 can compile
this without issue.

//--Environnement information--//

Target: aarch64-unknown-linux-gnu
Configured with: ../gcc-12.1.0/configure
--prefix=/opt/local/gcc-12.1.0-full+isl+binutils
--with-gmp=/opt/local/gcc-12.1.0-full+isl+binutils
--with-mpfr=/opt/local/gcc-12.1.0-full+isl+binutils
--with-mpc=/opt/local/gcc-12.1.0-full+isl+binutils
--with-isl=/opt/local/gcc-12.1.0-full+isl+binutils --disable-multilib
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 12.1.0 (GCC)
GNU C17 (GCC) version 12.1.0 (aarch64-unknown-linux-gnu)
        compiled by GNU C version 12.1.0, GMP version 6.2.1, MPFR version
4.1.0, MPC version 1.2.1, isl version isl-0.24-GMP
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
GNU C17 (GCC) version 12.1.0 (aarch64-unknown-linux-gnu)
        compiled by GNU C version 12.1.0, GMP version 6.2.1, MPFR version
4.1.0, MPC version 1.2.1, isl version isl-0.24-GMP
GGC heuristics: --param ggc-min-expand=100 --param ggc-min-heapsize=131072
Compiler executable checksum: 42e82fd3c52b7c6fb0e0f63d24249e6a

//--Compiler options--//

COLLECT_GCC_OPTIONS='-O3' '-fopenmp' '-g' '-c' '-mlittle-endian' '-mabi=lp64'
'-pthread'

//--Error output--//

$ make hydro

/opt/local/gcc-12.1.0-full+isl+binutils/bin/gcc -O3 -save-temps -freport-bug  
-fopenmp -g  -c SplitSurface.c
/opt/local/gcc-12.1.0-full+isl+binutils/bin/gcc -O3 -save-temps -freport-bug  
-fopenmp -g  -c cmpflx.c
/opt/local/gcc-12.1.0-full+isl+binutils/bin/gcc -O3 -save-temps -freport-bug  
-fopenmp -g  -c compute_deltat.c
/opt/local/gcc-12.1.0-full+isl+binutils/bin/gcc -O3 -save-temps -freport-bug  
-fopenmp -g  -c conservar.c
conservar.c:65:24: internal compiler error: Segmentation fault
   65 |                        ) {
      |                        ^
0xbeee33 crash_signal
        ../../gcc-12.1.0/gcc/toplev.cc:322
0x7849bc warn_parm_array_mismatch(unsigned int, tree_node*, tree_node*)
        ../../gcc-12.1.0/gcc/c-family/c-warn.cc:3607
0x6be303 start_function(c_declspecs*, c_declarator*, tree_node*)
        ../../gcc-12.1.0/gcc/c/c-decl.cc:9699
0x70ad67 c_parser_declaration_or_fndef
        ../../gcc-12.1.0/gcc/c/c-parser.cc:2445
0x71212f c_parser_external_declaration
        ../../gcc-12.1.0/gcc/c/c-parser.cc:1779
0x712c5f c_parser_translation_unit
        ../../gcc-12.1.0/gcc/c/c-parser.cc:1652
0x712c5f c_parse_file()
        ../../gcc-12.1.0/gcc/c/c-parser.cc:23357
0x75f5af c_common_parse_file()
        ../../gcc-12.1.0/gcc/c-family/c-opts.cc:1240
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
Makefile:53: recipe for target 'conservar.o' failed
make: *** [conservar.o] Error 1

//--Steps to reproduce--//

$ git clone https://github.com/HydroBench/Hydro.git
$ cd Hydro/
$ git checkout 7934330edc7f464298bbc25e58e69d1dcfe4d82c
$ ln Arch/make_gcc_nompi HydroC/HydroC99_2DMpi/Src/make.inc
$ cd HydroC/HydroC99_2DMpi/Src/

#removing unwanted options specific to intel

$ sed -i -e 's/-march=corei7-avx//g' make.inc
$ sed -i -e 's/CFLAGS += -vec-report3/#CFLAGS += -vec-report3/g' Makefile

#making sure of the version of gcc
#you can use the following command if needed and replace with the path to your
gcc version 12.1.0
# $ sed -i -e 's/= gcc/= path\/to\/wanted\/gcc/g' make.inc

$ make hydro

[Bug c/105660] ICE on aarch64 in warn_parm_array_mismatch

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-05-19
             Status|UNCONFIRMED                 |NEW
                 CC|                            |marxin at gcc dot gnu.org

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Confirmed, reducing and bisecting right now..

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch since r12-1218-gc6503fa93b5565c9

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gcc dot gnu.org
            Summary|ICE on aarch64 in           |[12/13 Regression] ICE in
                   |warn_parm_array_mismatch    |warn_parm_array_mismatch
                   |                            |since
                   |                            |r12-1218-gc6503fa93b5565c9

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
Reduced test-case:

$ cat conservar.i
void gatherConservativeVars(int, int, int, int, int, int, int Hnvar, int,
                            int Hnyt, int Hnxyt, int, int Hstep, double[Hnyt],
                            double[Hnvar][Hstep][Hnxyt]);
void gatherConservativeVars(int, int, int, int, int, int, int Hnvar, int, int,
                            int Hnxyt, int, int Hstep, double[],
                            double[Hnvar][Hstep][Hnxyt]);

$ gcc conservar.i -c
conservar.i:6:29: internal compiler error: Segmentation fault
    6 |                             double[Hnvar][Hstep][Hnxyt]);
      |                             ^~~~~~
0xf4e44a crash_signal
        /home/marxin/Programming/gcc/gcc/toplev.cc:322
0x7ffff78b57bf ???
       
/usr/src/debug/glibc-2.35-2.4.x86_64/signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x9f8d7b tree_check(tree_node*, char const*, int, char const*, tree_code)
        /home/marxin/Programming/gcc/gcc/tree.h:3506
0x9f8d7b warn_parm_array_mismatch(unsigned int, tree_node*, tree_node*)
        /home/marxin/Programming/gcc/gcc/c-family/c-warn.cc:3620
0x95cfdd c_parser_declaration_or_fndef
        /home/marxin/Programming/gcc/gcc/c/c-parser.cc:2355
0x96500b c_parser_external_declaration
        /home/marxin/Programming/gcc/gcc/c/c-parser.cc:1787
0x965873 c_parser_translation_unit
        /home/marxin/Programming/gcc/gcc/c/c-parser.cc:1660
0x965873 c_parse_file()
        /home/marxin/Programming/gcc/gcc/c/c-parser.cc:23388
0x9ca445 c_common_parse_file()
        /home/marxin/Programming/gcc/gcc/c-family/c-opts.cc:1235
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

Started with r12-1218-gc6503fa93b5565c9.

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch since r12-1218-gc6503fa93b5565c9

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.2

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[romain at dolbeau dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

Romain Dolbeau <romain at dolbeau dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |romain at dolbeau dot org

--- Comment #3 from Romain Dolbeau <romain at dolbeau dot org> ---
Created attachment 53191
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53191&action=edit
Patch to resolve the issue by moving strchr to strrchr

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[romain at dolbeau dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

--- Comment #4 from Romain Dolbeau <romain at dolbeau dot org> ---
It seems the issue was an 'r' dropped from the name of 'strrchr' in the
offending commit. Fixing this resolves the bug for us. See the attached patch.

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

Alex Coplan <acoplan at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |acoplan at gcc dot gnu.org

--- Comment #7 from Alex Coplan <acoplan at gcc dot gnu.org> ---
(In reply to Romain Dolbeau from comment #3)
> Created attachment 53191 [details]
> Patch to resolve the issue by moving strchr to strrchr

Hi Romain, have you submitted the patch to the gcc-patches mailing list for
review?

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[romain at dolbeau dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

--- Comment #8 from Romain Dolbeau <romain at dolbeau dot org> ---
Hello,

I only posted the patch to the (web) bug report, I'm not sure if that
automatically notify the ML or not...

Cordially,

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

--- Comment #9 from Alex Coplan <acoplan at gcc dot gnu.org> ---
(In reply to Romain Dolbeau from comment #8)
> Hello,
> 
> I only posted the patch to the (web) bug report, I'm not sure if that
> automatically notify the ML or not...

No, you will need to submit the patch yourself to gcc-patches@gcc.gnu.org, see
the contribution guidelines here: https://gcc.gnu.org/contribute.html

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[muecker at gwdg dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

--- Comment #10 from Martin Uecker <muecker at gwdg dot de> ---
I do not think the suggested change is correct. I am looking into it.

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[muecker at gwdg dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

--- Comment #11 from Martin Uecker <muecker at gwdg dot de> ---
PATCH: https://gcc.gnu.org/pipermail/gcc-patches/2023-February/611817.html

[Bug c/105660] [12/13 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Uecker <uecker@gcc.gnu.org>:

https://gcc.gnu.org/g:3057d7928c0dbc78dbf748c9621ccd102e06beee

commit r13-6127-g3057d7928c0dbc78dbf748c9621ccd102e06beee
Author: Martin Uecker <uecker@tugraz.at>
Date:   Wed Feb 8 15:02:43 2023 +0100

    Fix ICE related to implicit access attributes for VLA arguments [PR105660]

    When constructing the specifier string when merging an access attribute
    that encodes information about VLA arguments, the string was constructed
    in random order by iterating through a hash table. Fix this by iterating
    though the list of arguments.

    gcc/c-family/Changelog:
            PR c/105660
            * c-attribs.cc (append_access_attr): Use order of arguments when
            construction string.
            (append_access_attr_idxs): Rename and make static.
            * c-warn.cc (warn_parm_array_mismatch): Add assertion.

    gcc/testsuite/ChangeLog:
            PR c/105660
            * gcc.dg/pr105660-1.c: New test.
            * gcc.dg/pr105660-2.c: New test.

[Bug c/105660] [12 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|12.3                        |12.4

--- Comment #13 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 12.3 is being released, retargeting bugs to GCC 12.4.

[Bug c/105660] [12 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

--- Comment #14 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Martin Uecker
<uecker@gcc.gnu.org>:

https://gcc.gnu.org/g:a4308f9d432a108026d6ae8ad99d40a52eea341f

commit r12-9522-ga4308f9d432a108026d6ae8ad99d40a52eea341f
Author: Martin Uecker <uecker@tugraz.at>
Date:   Wed Feb 8 15:02:43 2023 +0100

    Fix ICE related to implicit access attributes for VLA arguments [PR105660]

    When constructing the specifier string when merging an access attribute
    that encodes information about VLA arguments, the string was constructed
    in random order by iterating through a hash table. Fix this by iterating
    though the list of arguments.

    gcc/c-family/Changelog:
            PR c/105660
            * c-attribs.cc (append_access_attr): Use order of arguments when
            construction string.
            (append_access_attr_idxs): Rename and make static.
            * c-warn.cc (warn_parm_array_mismatch): Add assertion.

    gcc/testsuite/ChangeLog:
            PR c/105660
            * gcc.dg/pr105660-1.c: New test.
            * gcc.dg/pr105660-2.c: New test.

    (cherry picked from commit 3057d7928c0dbc78dbf748c9621ccd102e06beee)

[Bug c/105660] [12 Regression] ICE in warn_parm_array_mismatch when merging two function decls and VLA arguments since r12-1218-gc6503fa93b5565c9

[uecker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105660

uecker at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |uecker at gcc dot gnu.org
         Resolution|---                         |FIXED

--- Comment #15 from uecker at gcc dot gnu.org ---
fixed for 12.4 (and 13)