public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug ipa/105685] [10/11 Regression] Bogus `-Wsuggest-attribute=cold` on function already marked as `__attribute__((cold))`
Date: Tue, 02 May 2023 20:16:19 +0000 [thread overview]
Message-ID: <bug-105685-4-RcOm1UlRNv@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105685-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105685
--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:c448f0d85c778eade1d8ae597744f6455285346f
commit r11-10730-gc448f0d85c778eade1d8ae597744f6455285346f
Author: Jakub Jelinek <jakub@redhat.com>
Date: Sun Mar 26 20:15:05 2023 +0200
predict: Don't emit -Wsuggest-attribute=cold warning for functions which
already have that attribute [PR105685]
In the following testcase, we predict baz to have cold
entry regardless of the user supplied attribute (as it call
unconditionally a cold function), but still issue
a -Wsuggest-attribute=cold warning despite it having that attribute
already.
The following patch avoids that.
2023-03-26 Jakub Jelinek <jakub@redhat.com>
PR ipa/105685
* predict.c (compute_function_frequency): Don't call
warn_function_cold if function already has cold attribute.
* c-c++-common/cold-2.c: New test.
(cherry picked from commit 7eca91d4781bb3df941f25c30b971dac66ba1b3d)
next prev parent reply other threads:[~2023-05-02 20:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-21 11:17 [Bug ipa/105685] New: Still " sagebar at web dot de
2022-05-21 21:41 ` [Bug ipa/105685] [10/11/12 Regression] " pinskia at gcc dot gnu.org
2022-05-23 7:04 ` rguenth at gcc dot gnu.org
2022-06-28 10:49 ` jakub at gcc dot gnu.org
2022-07-15 10:36 ` marxin at gcc dot gnu.org
2023-03-24 16:10 ` [Bug ipa/105685] [10/11/12/13 " jakub at gcc dot gnu.org
2023-03-26 18:15 ` cvs-commit at gcc dot gnu.org
2023-03-26 18:43 ` [Bug ipa/105685] [10/11/12 " jakub at gcc dot gnu.org
2023-04-18 7:15 ` cvs-commit at gcc dot gnu.org
2023-04-18 7:20 ` [Bug ipa/105685] [10/11 " jakub at gcc dot gnu.org
2023-05-02 20:16 ` cvs-commit at gcc dot gnu.org [this message]
2023-05-03 9:26 ` [Bug ipa/105685] [10 " jakub at gcc dot gnu.org
2023-05-03 15:22 ` cvs-commit at gcc dot gnu.org
2023-05-04 7:17 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-105685-4-RcOm1UlRNv@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).