[Bug bootstrap/105831] New: Nonportable syntax in "test" and "[" commands.

[Bug bootstrap/105831] New: Nonportable syntax in "test" and "[" commands.

[micha at NetBSD dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

            Bug ID: 105831
           Summary: Nonportable syntax in "test" and "[" commands.
           Product: gcc
           Version: 12.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
          Assignee: unassigned at gcc dot gnu.org
          Reporter: micha at NetBSD dot org
  Target Milestone: ---

Created attachment 53076
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53076&action=edit
Patches for portable string comparison (POSIX shell)

Nonportable string comparisons in files "gcc/configure.ac" and
"gcc/config/nvptx/gen-opt.sh".

Patches attached for portable POSIX syntax.

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[egallager at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |egallager at gcc dot gnu.org

--- Comment #1 from Eric Gallager <egallager at gcc dot gnu.org> ---
Hi, please send the patch to the gcc-patches mailing list for review.

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Right. The patch looks correct, but patches should be sent to the list, not
added to bugzilla:
https://gcc.gnu.org/contribute.html#patches

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note I think most folks on AIX, uses CONFIG_SHELL=bash due to the speed of
/bin/sh and configure :
https://gcc.gnu.org/install/specific.html#x-ibm-aix

So the patch to configure.ac while good does not do much.

And IIRC nvptx target is really only tested on GNU/Linux so nvptx/gen-opt.sh
will most likely only be invoked with bash (dash?).

So while good, will not do much.

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-05-18
             Status|UNCONFIRMED                 |NEW

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The == syntax also fails with dash, which is used as the default /bin/sh on
debian:

$ /bin/sh -c "test foo = foo && echo y"
y
$ /bin/sh -c "test foo == foo && echo y"
/bin/sh: 1: test: foo: unexpected operator

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |redi at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
== does work with ksh, which is used as /bin/sh on AIX, Solaris, and OpenBSD,
and works with FreeBSD sh (derived from ask, I think).

It doesn't work with dash, or NetBSD sh (also derived from ash, I think), or
with zsh (unless you quote it as "==").

So I think we do want this change. I'll get it pushed.

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Submitted as https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618914.html

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:95b93adcac69536bab617e045149719ec69099ae

commit r14-968-g95b93adcac69536bab617e045149719ec69099ae
Author: Michael Bäuerle <micha@NetBSD.org>
Date:   Thu May 18 10:15:49 2023 +0100

    gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831]

    POSIX sh does not support the == for string comparisons, use = instead.

    gcc/ChangeLog:

            PR bootstrap/105831
            * config/nvptx/gen-opt.sh: Use = operator instead of ==.
            * configure.ac: Likewise.
            * configure: Regenerate.

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:6e2fbe4f345f48ae3c8ba5bfbc1a7b783b398614

commit r14-969-g6e2fbe4f345f48ae3c8ba5bfbc1a7b783b398614
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu May 18 10:18:19 2023 +0100

    gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831]

    POSIX sh does not support the == for string comparisons, use = instead.

    The gen_directive_tests script uses a bash shebang so == does work, but
    there's no reason this script can't just use the more portable form
    anyway.

            PR bootstrap/105831

    gcc/ChangeLog:

            * config.gcc: Use = operator instead of ==.

    gcc/testsuite/ChangeLog:

            * gcc.test-framework/gen_directive_tests: Use = operator instead
            of ==.

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:120e444974e12eb727eea170a3bfd80783e3851f

commit r14-970-g120e444974e12eb727eea170a3bfd80783e3851f
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu May 18 10:18:19 2023 +0100

    contrib: Fix nonportable shell syntax in "test" and "[" commands [PR105831]

    POSIX sh does not support the == for string comparisons, use = instead.

    These contrib scripts all use a bash shebang so == does work, but
    there's no reason they can't just use the more portable form anyway.

            PR bootstrap/105831

    contrib/ChangeLog:

            * bench-stringop: Use = operator instead of ==.
            * repro_fail: Likewise.

    contrib/reghunt/ChangeLog:

            * bin/reg-hunt: Use = operator instead of ==.

[Bug bootstrap/105831] Nonportable syntax in "test" and "[" commands.

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105831

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |14.0
         Resolution|---                         |FIXED

--- Comment #10 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed on trunk (and some other cases of == elsewhere). Thanks for the patch and
report.