[Bug c/105960] New: Crash in 32-bit mode

[Bug c/105960] New: Crash in 32-bit mode

[terra at gnome dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

            Bug ID: 105960
           Summary: Crash in 32-bit mode
           Product: gcc
           Version: 12.1.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: terra at gnome dot org
  Target Milestone: ---

Created attachment 53130
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53130&action=edit
Source files and compile script

The attached archive shows a crash when running 32-bit binaries compiled with
gcc 12.1

I am preliminarily blaming the C compiler.




0. Unpack tar file

1. Edit "compile" to point at the desired compiler

2. ./compile

3. ./crash32

Expected: immediate return
Observed: Segmentation fault (core dumped)

(gdb) where
#0  0xf7fc73d0 in *ABS*@plt () from /home/welinder/crash32/liboink32.so
#1  0x0804841d in main ()


Observations (probably more "anecdote" than "data"):

* Doesn't happen in 64-bit mode
* Doesn't happen without optimization
* The shared library appears to be a required part
* The use target_clones appears to be a required part
* This did not happen with gcc 11.1


# uname -a
Linux xxxxxxxxxx 5.3.18-150300.59.63-default #1 SMP Tue Apr 5 12:47:31 UTC 2022
(d77db66) x86_64 x86_64 x86_64 GNU/Linux


# /usr/local/products/gcc/12.1.0/bin/gcc --version
gcc (GCC) 12.1.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

[Bug target/105960] Crash in 32-bit mode

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
```
COMPILE="$CC -m32 -O2 -I. -Wall"

# Preprocessed files were created thus:
# $COMPILE -E crash32.c > crash32-preprocessed.c
# $COMPILE -E expref.c > expref-preprocessed.c

$COMPILE -c -o crash32.o crash32.c
$COMPILE -c -o expref.o expref.c

$CC -m32 -o liboink32.so   -shared expref.o

$CC -m32 -o crash32 -g crash32.o $PWD/liboink32.so -lm
```

[Bug target/105960] Crash in 32-bit mode

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
> $COMPILE -c -o crash32.o crash32.c
> $COMPILE -c -o expref.o expref.c

> $CC -m32 -o liboink32.so   -shared expref.o

You didn't use -fPIC which is required if you are compiling a shared library.

[Bug target/105960] Crash in 32-bit mode

[terra at gnome dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

M Welinder <terra at gnome dot org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |---

--- Comment #3 from M Welinder <terra at gnome dot org> ---
This happens with -fPIC added to COMPILE too.  (It got dropped somewhere in the
minimization of the sample.)

[Bug target/105960] Crash in 32-bit mode

[terra at gnome dot org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

--- Comment #4 from M Welinder <terra at gnome dot org> ---
And added to the link lines too, btw.

[Bug target/105960] Crash in 32-bit mode

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64                      |i?86-*-*
   Last reconfirmed|                            |2022-06-14
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |hjl.tools at gmail dot com

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.  Something is wrong with either ld.so or GCC.  We end up with

        .globl  exp_ref
        .type   exp_ref, @function
exp_ref:
.LFB1:
        .cfi_startproc
        pushl   %ebx
        .cfi_def_cfa_offset 8
        .cfi_offset 3, -8
        popl    %ebx
        .cfi_restore 3
        .cfi_def_cfa_offset 4
        jmp     expfull_ref@PLT

^^^ this crashes

        .type   expfull_ref, @gnu_indirect_function
        .set    expfull_ref,expfull_ref.resolver

        .type   expfull_ref.resolver, @function
expfull_ref.resolver:
.LFB4:
        .cfi_startproc
        pushl   %ebx

but expfull_ref isn't .globl!?


#define TARGET_CLONES  __attribute__((target_clones("default","fma")))
TARGET_CLONES
static inline double
expfull_ref(double x)
{
  return __builtin_pow(x, 0.1234);
}

double
exp_ref(double x)
{
  return expfull_ref(x);
}

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2
           Keywords|                            |needs-bisection, wrong-code
            Summary|Crash in 32-bit mode        |[12/13 Regression] Crash in
                   |                            |32-bit mode
      Known to work|                            |11.3.0
      Known to fail|                            |12.1.0
   Target Milestone|---                         |12.2

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
This is caused by r12-5771.

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |hjl.tools at gmail dot com

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 53135
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53135&action=edit
A patch

Try this.

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[wwcsmail at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

Wolfgang Wander <wwcsmail at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wwcsmail at gmail dot com

--- Comment #8 from Wolfgang Wander <wwcsmail at gmail dot com> ---
Thanks H.J,

tried and this indeed fixes the issue!

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:fe9765c0b97e6b4ce2cd226631d329fc05ba2aa5

commit r13-1180-gfe9765c0b97e6b4ce2cd226631d329fc05ba2aa5
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Jun 14 08:20:16 2022 -0700

    i386: Disallow sibcall for calling ifunc functions with PIC register

    Disallow siball when calling ifunc functions with PIC register so that
    PIC register can be restored.

    gcc/

            PR target/105960
            * config/i386/i386.cc (ix86_function_ok_for_sibcall): Return
            false if PIC register is used when calling ifunc functions.

    gcc/testsuite/

            PR target/105960
            * gcc.target/i386/pr105960.c: New test.

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:2474c8e09a93027cde39ecb6a53742142c8496ed

commit r12-8501-g2474c8e09a93027cde39ecb6a53742142c8496ed
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Tue Jun 14 08:20:16 2022 -0700

    i386: Disallow sibcall for calling ifunc functions with PIC register

    Disallow siball when calling ifunc functions with PIC register so that
    PIC register can be restored.

    gcc/

            PR target/105960
            * config/i386/i386.cc (ix86_function_ok_for_sibcall): Return
            false if PIC register is used when calling ifunc functions.

    gcc/testsuite/

            PR target/105960
            * gcc.target/i386/pr105960.c: New test.

    (cherry picked from commit fe9765c0b97e6b4ce2cd226631d329fc05ba2aa5)

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

--- Comment #11 from Martin Liška <marxin at gcc dot gnu.org> ---
Can we close it now?

[Bug target/105960] [12/13 Regression] Crash in 32-bit mode

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105960

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #12 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.