public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hjl.tools at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/105980] [11/12/13 Regression] ICE in final_scan_insn_1, at final.cc:2811
Date: Fri, 29 Jul 2022 20:37:45 +0000	[thread overview]
Message-ID: <bug-105980-4-5WDQhghhg1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-105980-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105980

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Jakub Jelinek from comment #5)
> So, shall we temporarily disable -mforce-indirect-call during the mi thunk
> output?

Something like this

diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
index e03f86d4a23..394fcac53a2 100644
--- a/gcc/config/i386/i386.cc
+++ b/gcc/config/i386/i386.cc
@@ -21382,6 +21382,7 @@ x86_output_mi_thunk (FILE *file, tree thunk_fndecl,
HOST_WIDE_INT delta,
   rtx this_reg, tmp, fnaddr;
   unsigned int tmp_regno;
   rtx_insn *insn;
+  int saved_flag_force_indirect_call = flag_force_indirect_call;

   if (TARGET_64BIT)
     tmp_regno = R10_REG;
@@ -21394,6 +21395,9 @@ x86_output_mi_thunk (FILE *file, tree thunk_fndecl,
HOST_WIDE_INT delta,
   tmp_regno = DX_REG;
       else
   tmp_regno = CX_REG;
+
+      if (flag_pic)
+  flag_force_indirect_call = 0;
     }

   emit_note (NOTE_INSN_PROLOGUE_END);
@@ -21561,6 +21565,8 @@ x86_output_mi_thunk (FILE *file, tree thunk_fndecl,
HOST_WIDE_INT delta,
   final (insn, file, 1);
   final_end_function ();
   assemble_end_function (thunk_fndecl, fnname);
+
+  flag_force_indirect_call = saved_flag_force_indirect_call;
 }

 static void

  parent reply	other threads:[~2022-07-29 20:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 17:53 [Bug c++/105980] New: " gscfq@t-online.de
2022-06-15  9:13 ` [Bug target/105980] " rguenth at gcc dot gnu.org
2022-06-16 14:03 ` marxin at gcc dot gnu.org
2022-06-17 10:21 ` ubizjak at gmail dot com
2022-07-25 16:00 ` rguenth at gcc dot gnu.org
2022-07-29 13:46 ` jakub at gcc dot gnu.org
2022-07-29 18:41 ` hjl.tools at gmail dot com
2022-07-29 20:10 ` jakub at gcc dot gnu.org
2022-07-29 20:37 ` hjl.tools at gmail dot com [this message]
2023-01-16 18:02 ` jakub at gcc dot gnu.org
2023-01-16 19:00 ` hjl.tools at gmail dot com
2023-01-16 22:11 ` cvs-commit at gcc dot gnu.org
2023-03-24 16:15 ` [Bug target/105980] [11/12 " jakub at gcc dot gnu.org
2023-04-27 13:18 ` cvs-commit at gcc dot gnu.org
2023-05-29 10:07 ` [Bug target/105980] [11 " jakub at gcc dot gnu.org
2024-02-10 18:19 ` fxcoudert at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-105980-4-5WDQhghhg1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).