* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
@ 2022-06-17 17:19 ` segher at gcc dot gnu.org
2022-06-17 17:33 ` bergner at gcc dot gnu.org
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: segher at gcc dot gnu.org @ 2022-06-17 17:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2022-06-17
--- Comment #1 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Confirmed. Thanks for reporting these bugs!
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
2022-06-17 17:19 ` [Bug target/106016] " segher at gcc dot gnu.org
@ 2022-06-17 17:33 ` bergner at gcc dot gnu.org
2022-06-17 17:39 ` segher at gcc dot gnu.org
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu.org @ 2022-06-17 17:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #2 from Peter Bergner <bergner at gcc dot gnu.org> ---
Given where this is ICEing, I'm guessing this is non-target specific issue in
handling opaque types.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
2022-06-17 17:19 ` [Bug target/106016] " segher at gcc dot gnu.org
2022-06-17 17:33 ` bergner at gcc dot gnu.org
@ 2022-06-17 17:39 ` segher at gcc dot gnu.org
2022-06-17 19:30 ` bergner at gcc dot gnu.org
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: segher at gcc dot gnu.org @ 2022-06-17 17:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #3 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Yeah. It should just return 1 like the other scalar types?
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (2 preceding siblings ...)
2022-06-17 17:39 ` segher at gcc dot gnu.org
@ 2022-06-17 19:30 ` bergner at gcc dot gnu.org
2022-06-17 19:37 ` bergner at gcc dot gnu.org
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu.org @ 2022-06-17 19:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #4 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #3)
> Yeah. It should just return 1 like the other scalar types?
So the code did look for OPAQUE_TYPE and expected never to see it, so it was on
an error path. I agree with your comment above and I'm guessing we want
something like:
diff --git a/gcc/expr.cc b/gcc/expr.cc
index 78c839ab425..1675198a146 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -6423,13 +6423,13 @@ count_type_elements (const_tree type, bool for_ctor_p)
case OFFSET_TYPE:
case REFERENCE_TYPE:
case NULLPTR_TYPE:
+ case OPAQUE_TYPE:
return 1;
case ERROR_MARK:
return 0;
case VOID_TYPE:
- case OPAQUE_TYPE:
case METHOD_TYPE:
case FUNCTION_TYPE:
case LANG_TYPE:
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (3 preceding siblings ...)
2022-06-17 19:30 ` bergner at gcc dot gnu.org
@ 2022-06-17 19:37 ` bergner at gcc dot gnu.org
2022-06-17 19:53 ` segher at gcc dot gnu.org
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu.org @ 2022-06-17 19:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #5 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #4)
> diff --git a/gcc/expr.cc b/gcc/expr.cc
> index 78c839ab425..1675198a146 100644
> --- a/gcc/expr.cc
> +++ b/gcc/expr.cc
> @@ -6423,13 +6423,13 @@ count_type_elements (const_tree type, bool
> for_ctor_p)
> case OFFSET_TYPE:
> case REFERENCE_TYPE:
> case NULLPTR_TYPE:
> + case OPAQUE_TYPE:
> return 1;
>
> case ERROR_MARK:
> return 0;
>
> case VOID_TYPE:
> - case OPAQUE_TYPE:
> case METHOD_TYPE:
> case FUNCTION_TYPE:
> case LANG_TYPE:
It does fix the ICE.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (4 preceding siblings ...)
2022-06-17 19:37 ` bergner at gcc dot gnu.org
@ 2022-06-17 19:53 ` segher at gcc dot gnu.org
2022-06-17 21:51 ` bergner at gcc dot gnu.org
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: segher at gcc dot gnu.org @ 2022-06-17 19:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #6 from Segher Boessenkool <segher at gcc dot gnu.org> ---
Like that yes. Pre-approved if it survives regcheck, too. Thanks!
Please add the testcase as well of course :-)
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (5 preceding siblings ...)
2022-06-17 19:53 ` segher at gcc dot gnu.org
@ 2022-06-17 21:51 ` bergner at gcc dot gnu.org
2022-06-18 0:15 ` bergner at gcc dot gnu.org
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu.org @ 2022-06-17 21:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
Peter Bergner <bergner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |bergner at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #7 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Segher Boessenkool from comment #6)
> Like that yes. Pre-approved if it survives regcheck, too. Thanks!
>
> Please add the testcase as well of course :-)
Ok, bootstrap and regtests are running.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug target/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (6 preceding siblings ...)
2022-06-17 21:51 ` bergner at gcc dot gnu.org
@ 2022-06-18 0:15 ` bergner at gcc dot gnu.org
2022-06-18 4:33 ` [Bug c/106016] " bergner at gcc dot gnu.org
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu.org @ 2022-06-18 0:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #8 from Peter Bergner <bergner at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #7)
> (In reply to Segher Boessenkool from comment #6)
> > Like that yes. Pre-approved if it survives regcheck, too. Thanks!
> >
> > Please add the testcase as well of course :-)
>
> Ok, bootstrap and regtests are running.
Bootstrap and regression testing were clean.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug c/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (7 preceding siblings ...)
2022-06-18 0:15 ` bergner at gcc dot gnu.org
@ 2022-06-18 4:33 ` bergner at gcc dot gnu.org
2022-06-20 18:46 ` [Bug middle-end/106016] " segher at gcc dot gnu.org
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu.org @ 2022-06-18 4:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
Peter Bergner <bergner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|target |c
--- Comment #9 from Peter Bergner <bergner at gcc dot gnu.org> ---
This is not a target issue, so changing the Component to C.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug middle-end/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (8 preceding siblings ...)
2022-06-18 4:33 ` [Bug c/106016] " bergner at gcc dot gnu.org
@ 2022-06-20 18:46 ` segher at gcc dot gnu.org
2022-07-26 15:05 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: segher at gcc dot gnu.org @ 2022-06-20 18:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
Segher Boessenkool <segher at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|target |middle-end
--- Comment #10 from Segher Boessenkool <segher at gcc dot gnu.org> ---
No, this is *not* a target issue. Let's try middle-end, then.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug middle-end/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (9 preceding siblings ...)
2022-06-20 18:46 ` [Bug middle-end/106016] " segher at gcc dot gnu.org
@ 2022-07-26 15:05 ` cvs-commit at gcc dot gnu.org
2022-08-12 0:26 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-07-26 15:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Peter Bergner <bergner@gcc.gnu.org>:
https://gcc.gnu.org/g:975658b782f36dcf6eb190966d5b705977bfd5eb
commit r13-1845-g975658b782f36dcf6eb190966d5b705977bfd5eb
Author: Peter Bergner <bergner@linux.ibm.com>
Date: Fri Jun 17 23:43:23 2022 -0500
c: Handle initializations of opaque types [PR106016]
The initial commit that added opaque types thought that there couldn't
be any valid initializations for variables of these types, but the test
case in the bug report shows that isn't true. The solution is to handle
OPAQUE_TYPE initializations like the other scalar types.
2022-06-17 Peter Bergner <bergner@linux.ibm.com>
gcc/
PR c/106016
* expr.cc (count_type_elements): Handle OPAQUE_TYPE.
gcc/testsuite/
PR c/106016
* gcc.target/powerpc/pr106016.c: New test.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug middle-end/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (10 preceding siblings ...)
2022-07-26 15:05 ` cvs-commit at gcc dot gnu.org
@ 2022-08-12 0:26 ` cvs-commit at gcc dot gnu.org
2022-08-12 2:09 ` cvs-commit at gcc dot gnu.org
2022-08-12 2:12 ` bergner at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-08-12 0:26 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:
https://gcc.gnu.org/g:6aaaf20ee4ad9c85f3099ef425720547644fb08d
commit r12-8682-g6aaaf20ee4ad9c85f3099ef425720547644fb08d
Author: Peter Bergner <bergner@linux.ibm.com>
Date: Fri Jun 17 23:43:23 2022 -0500
c: Handle initializations of opaque types [PR106016]
The initial commit that added opaque types thought that there couldn't
be any valid initializations for variables of these types, but the test
case in the bug report shows that isn't true. The solution is to handle
OPAQUE_TYPE initializations like the other scalar types.
2022-06-17 Peter Bergner <bergner@linux.ibm.com>
gcc/
PR c/106016
* expr.cc (count_type_elements): Handle OPAQUE_TYPE.
gcc/testsuite/
PR c/106016
* gcc.target/powerpc/pr106016.c: New test.
(cherry picked from commit 975658b782f36dcf6eb190966d5b705977bfd5eb)
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug middle-end/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (11 preceding siblings ...)
2022-08-12 0:26 ` cvs-commit at gcc dot gnu.org
@ 2022-08-12 2:09 ` cvs-commit at gcc dot gnu.org
2022-08-12 2:12 ` bergner at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-08-12 2:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Peter Bergner
<bergner@gcc.gnu.org>:
https://gcc.gnu.org/g:df8567535a1f3eaa20b700be62374b2fb4f09204
commit r11-10201-gdf8567535a1f3eaa20b700be62374b2fb4f09204
Author: Peter Bergner <bergner@linux.ibm.com>
Date: Fri Jun 17 23:43:23 2022 -0500
c: Handle initializations of opaque types [PR106016]
The initial commit that added opaque types thought that there couldn't
be any valid initializations for variables of these types, but the test
case in the bug report shows that isn't true. The solution is to handle
OPAQUE_TYPE initializations like the other scalar types.
2022-06-17 Peter Bergner <bergner@linux.ibm.com>
gcc/
PR c/106016
* expr.c (count_type_elements): Handle OPAQUE_TYPE.
gcc/testsuite/
PR c/106016
* gcc.target/powerpc/pr106016.c: New test.
(cherry picked from commit 975658b782f36dcf6eb190966d5b705977bfd5eb)
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Bug middle-end/106016] [PowerPC] crash with attempt to initialize array of MMA accumulators
2022-06-17 14:29 [Bug c/106016] New: [PowerPC] crash with attempt to initialize array of MMA accumulators nemanja.i.ibm at gmail dot com
` (12 preceding siblings ...)
2022-08-12 2:09 ` cvs-commit at gcc dot gnu.org
@ 2022-08-12 2:12 ` bergner at gcc dot gnu.org
13 siblings, 0 replies; 15+ messages in thread
From: bergner at gcc dot gnu.org @ 2022-08-12 2:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106016
Peter Bergner <bergner at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #14 from Peter Bergner <bergner at gcc dot gnu.org> ---
Fixed everywhere.
^ permalink raw reply [flat|nested] 15+ messages in thread