public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/106032] [10/11/12/13 Regression] wrong code at -Os and above on x86_64-linux-gnu Date: Tue, 28 Jun 2022 15:38:48 +0000 [thread overview] Message-ID: <bug-106032-4-DOonOf6RJm@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106032-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106032 --- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:9e72a522dd9f835dd159fe3aff493eee001be0d4 commit r12-8523-g9e72a522dd9f835dd159fe3aff493eee001be0d4 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Jun 21 11:40:16 2022 +0200 ifcvt: Don't introduce trapping or faulting reads in noce_try_sign_mask [PR106032] noce_try_sign_mask as documented will optimize if (c < 0) x = t; else x = 0; into x = (c >> bitsm1) & t; The optimization is done if either t is unconditional (e.g. for x = t; if (c >= 0) x = 0; ) or if it is cheap. We already check that t doesn't have side-effects, but if t is conditional, we need to punt also if it may trap or fault, as we make it unconditional. I've briefly skimmed other noce_try* optimizations and didn't find one that would suffer from the same problem. 2022-06-21 Jakub Jelinek <jakub@redhat.com> PR rtl-optimization/106032 * ifcvt.cc (noce_try_sign_mask): Punt if !t_unconditional, and t may_trap_or_fault_p, even if it is cheap. * gcc.c-torture/execute/pr106032.c: New test. (cherry picked from commit a0c30fe3b888f20215f3e040d21b62b603804ca9)
next prev parent reply other threads:[~2022-06-28 15:38 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-19 20:52 [Bug tree-optimization/106032] New: " zhendong.su at inf dot ethz.ch 2022-06-19 20:53 ` [Bug tree-optimization/106032] " zhendong.su at inf dot ethz.ch 2022-06-19 20:57 ` [Bug tree-optimization/106032] [12/13 Regression] " pinskia at gcc dot gnu.org 2022-06-19 21:04 ` [Bug rtl-optimization/106032] " pinskia at gcc dot gnu.org 2022-06-19 21:08 ` [Bug rtl-optimization/106032] [10/11/12/13 " pinskia at gcc dot gnu.org 2022-06-20 8:04 ` marxin at gcc dot gnu.org 2022-06-20 8:09 ` pinskia at gcc dot gnu.org 2022-06-20 11:45 ` rguenth at gcc dot gnu.org 2022-06-20 15:09 ` jakub at gcc dot gnu.org 2022-06-20 15:58 ` jakub at gcc dot gnu.org 2022-06-20 16:08 ` jakub at gcc dot gnu.org 2022-06-21 9:40 ` cvs-commit at gcc dot gnu.org 2022-06-28 10:49 ` jakub at gcc dot gnu.org 2022-06-28 15:38 ` cvs-commit at gcc dot gnu.org [this message] 2022-06-28 15:47 ` [Bug rtl-optimization/106032] [10/11 " jakub at gcc dot gnu.org 2022-11-04 8:30 ` cvs-commit at gcc dot gnu.org 2022-11-04 11:00 ` [Bug rtl-optimization/106032] [10 " jakub at gcc dot gnu.org 2023-05-03 15:18 ` cvs-commit at gcc dot gnu.org 2023-05-04 7:18 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106032-4-DOonOf6RJm@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).