public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/106032] [12/13 Regression] wrong code at -Os and above on x86_64-linux-gnu
Date: Sun, 19 Jun 2022 21:04:37 +0000	[thread overview]
Message-ID: <bug-106032-4-trBzxStecl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106032-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106032

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |rtl-optimization

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The tree level looks ok. THe only difference is 12/13 has:

  if (c.0_1 < 0)
    goto <bb 3>; [67.00%]
  else
    goto <bb 4>; [33.00%]

  <bb 3> [local count: 679839639]:
  e_15 = *d.1_2;

  <bb 4> [local count: 59055800]:

While 11 does:
  if (c.0_1 < 0)
    goto <bb 3>; [67.00%]
  else
    goto <bb 4>; [33.00%]

  <bb 3> [local count: 679839639]:
  d.1_2 = d;
  e_15 = *d.1_2;

  <bb 4> [local count: 59055800]:

That is the load from the global d is now unconditional but the load from *d is
still conditional.

I see ce2 is doing ifcvt on that and changing it to be an unconditional load.
IF-THEN-JOIN block found, pass 1, test 3, then 4, join 5

(insn 57 56 58 2 (parallel [
            (set (reg:SI 89)
                (ashiftrt:SI (reg:SI 90 [ c ])
                    (const_int 31 [0x1f])))
            (clobber (reg:CC 17 flags))
        ]) "/app/example.cpp":7:9 758 {ashrsi3_cvt}
     (expr_list:REG_DEAD (reg:SI 90 [ c ])
        (expr_list:REG_UNUSED (reg:CC 17 flags)
            (expr_list:REG_EQUAL (ashiftrt:SI (mem/c:SI (symbol_ref:DI ("c")
[flags 0x2]  <var_decl 0x7ff174377d80 c>) [1 c+0 S4 A32])
                    (const_int 31 [0x1f]))
                (nil)))))
(insn 58 57 16 2 (parallel [
            (set (reg:SI 91)
                (and:SI (reg:SI 89)
                    (mem:SI (reg/f:DI 83 [ d.1_2 ]) [1 *d.1_2+0 S4 A32])))
            (clobber (reg:CC 17 flags))
        ]) "/app/example.cpp":7:9 533 {*andsi_1}
     (expr_list:REG_DEAD (reg:SI 89)
        (expr_list:REG_DEAD (reg/f:DI 83 [ d.1_2 ])
            (expr_list:REG_UNUSED (reg:CC 17 flags)
                (nil)))))

  parent reply	other threads:[~2022-06-19 21:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-19 20:52 [Bug tree-optimization/106032] New: " zhendong.su at inf dot ethz.ch
2022-06-19 20:53 ` [Bug tree-optimization/106032] " zhendong.su at inf dot ethz.ch
2022-06-19 20:57 ` [Bug tree-optimization/106032] [12/13 Regression] " pinskia at gcc dot gnu.org
2022-06-19 21:04 ` pinskia at gcc dot gnu.org [this message]
2022-06-19 21:08 ` [Bug rtl-optimization/106032] [10/11/12/13 " pinskia at gcc dot gnu.org
2022-06-20  8:04 ` marxin at gcc dot gnu.org
2022-06-20  8:09 ` pinskia at gcc dot gnu.org
2022-06-20 11:45 ` rguenth at gcc dot gnu.org
2022-06-20 15:09 ` jakub at gcc dot gnu.org
2022-06-20 15:58 ` jakub at gcc dot gnu.org
2022-06-20 16:08 ` jakub at gcc dot gnu.org
2022-06-21  9:40 ` cvs-commit at gcc dot gnu.org
2022-06-28 10:49 ` jakub at gcc dot gnu.org
2022-06-28 15:38 ` cvs-commit at gcc dot gnu.org
2022-06-28 15:47 ` [Bug rtl-optimization/106032] [10/11 " jakub at gcc dot gnu.org
2022-11-04  8:30 ` cvs-commit at gcc dot gnu.org
2022-11-04 11:00 ` [Bug rtl-optimization/106032] [10 " jakub at gcc dot gnu.org
2023-05-03 15:18 ` cvs-commit at gcc dot gnu.org
2023-05-04  7:18 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106032-4-trBzxStecl@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).