[Bug tree-optimization/106055] New: [13 Regression] ICE in replace_uses_by, at tree-cfg.cc:1989

[Bug tree-optimization/106055] New: [13 Regression] ICE in replace_uses_by, at tree-cfg.cc:1989

[asolokha at gmx dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106055

            Bug ID: 106055
           Summary: [13 Regression] ICE in replace_uses_by, at
                    tree-cfg.cc:1989
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: asolokha at gmx dot com
  Target Milestone: ---

gcc 13.0.0 20220619 snapshot (g:4390e7bfbc641a52c6192b448768dafdf4565527) ICEs
when compiling the following testcase w/ -Os -floop-parallelize-all
-fno-tree-dce:

__attribute__ ((returns_twice)) int
bar (void);

void
quux (void);

void
empty (void)
{
}

unsigned int
choose (unsigned int x, unsigned int y)
{
  return y ? x : 0;
}

int
foo (int *p, unsigned int x, int y)
{
  unsigned int acc = 0;

  empty ();

  while (x)
    {
      bar ();
      ++x;
    }

  while (y)
    acc += y;

  *p = choose (acc, 1);
  quux ();

  return x;
}

% gcc-13.0.0 -Os -floop-parallelize-all -fno-tree-dce -c e2hatkyd.c
during GIMPLE pass: graphite
e2hatkyd.c: In function 'foo':
e2hatkyd.c:19:1: internal compiler error: in replace_uses_by, at
tree-cfg.cc:1989
   19 | foo (int *p, unsigned int x, int y)
      | ^~~
0x73a403 replace_uses_by(tree_node*, tree_node*)
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220619/work/gcc-13-20220619/gcc/tree-cfg.cc:1989
0x1d361b2 canonicalize_loop_closed_ssa
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220619/work/gcc-13-20220619/gcc/graphite.cc:342
0x1d361b2 canonicalize_loop_form
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220619/work/gcc-13-20220619/gcc/graphite.cc:386
0x1d361b2 graphite_transform_loops()
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220619/work/gcc-13-20220619/gcc/graphite.cc:435
0x1d376c0 graphite_transforms
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220619/work/gcc-13-20220619/gcc/graphite.cc:536
0x1d376c0 execute
       
/var/tmp/portage/sys-devel/gcc-13.0.0_p20220619/work/gcc-13-20220619/gcc/graphite.cc:613

[Bug tree-optimization/106055] [13 Regression] ICE in replace_uses_by with -floop-parallelize-all and returns_twice

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106055

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13 Regression] ICE in      |[13 Regression] ICE in
                   |replace_uses_by, at         |replace_uses_by with
                   |tree-cfg.cc:1989            |-floop-parallelize-all and
                   |                            |returns_twice
   Target Milestone|---                         |13.0

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I suspect this is a latent bug with -floop-parallelize-all which does not get
much testing at all.

[Bug tree-optimization/106055] [13 Regression] ICE in replace_uses_by with -floop-parallelize-all and returns_twice

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106055

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2022-06-24

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
I will have a look.

[Bug tree-optimization/106055] [13 Regression] ICE in replace_uses_by with -floop-parallelize-all and returns_twice

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106055

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:d74d98784a9d0101aad8095d692193a74a2f62f6

commit r13-1419-gd74d98784a9d0101aad8095d692193a74a2f62f6
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Jul 1 15:32:30 2022 +0200

    tree-optimization/106055 - issue with autopar

    When autopar uses graphites canonicalize_loop_closed_ssa it fails to
    check whether propagation is allowed and thus it ends up messing up
    abnormal constraints.

    2022-07-01  Richard Biener  <rguenther@suse.de>

            PR tree-optimization/106055
            * graphite.cc (canonicalize_loop_closed_ssa): Check whether
            we can propagate.

            * gcc.dg/graphite/pr106055.c: New testcase.

[Bug tree-optimization/106055] [13 Regression] ICE in replace_uses_by with -floop-parallelize-all and returns_twice

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106055

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.