public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "krebbel at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/106101] [12/13 Regression] ICE in reg_bitfield_target_p since r12-4428-g147ed0184f403b Date: Thu, 25 Aug 2022 13:55:09 +0000 [thread overview] Message-ID: <bug-106101-4-797ojurRCc@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-106101-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106101 --- Comment #22 from Andreas Krebbel <krebbel at gcc dot gnu.org> --- The longer a have been looking at these STRICT_LOW_PART issue the more I think that STRICT_LOW_PART is an awful way to express what we need: - the information needed to understand what it is doing is distributed across 3 RTXs (strict_low_part (subreg:mode1 (reg:mode2 xx) OFS)) - the big problems arise since the involved RTXs are separately optimized and we might end up with partial information without a clear definition of how to deal with that - actually it is really hard to handle the RTXs as one unit. Recursively walking RTXs needs to record whether we are in a STRICT_LOW_PART or not. I think it might make sense to explore other ways to express this: 1. SUBREG flag - Looks easy, but it would be hard to catch all places which should care about that flag. 2. Introduce a new RTX code which has a mode and an offset attached but does not require an additional SUBREG anymore. 3. Since a STRICT_LOW_PART is essentially a bit insertion operation we could express it always with a ZERO_EXTRACT target operand and get rid of STRICT_LOW_PART entirely. A ZERO_EXTRACT would be somewhat more cumbersome to deal with, since it would always require to check the bit width and offset for all the cases which just use mode boundaries. But at least most passes know how to deal with them already.
next prev parent reply other threads:[~2022-08-25 13:55 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-27 9:22 [Bug rtl-optimization/106101] New: [12/13 Regression] ICE in reg_bitfield_target_p rguenth at gcc dot gnu.org 2022-06-27 9:22 ` [Bug rtl-optimization/106101] " rguenth at gcc dot gnu.org 2022-06-27 9:22 ` rguenth at gcc dot gnu.org 2022-06-27 9:26 ` rguenth at gcc dot gnu.org 2022-06-27 15:10 ` segher at gcc dot gnu.org 2022-06-28 6:57 ` [Bug target/106101] " rguenth at gcc dot gnu.org 2022-06-28 15:03 ` segher at gcc dot gnu.org 2022-06-28 16:58 ` segher at gcc dot gnu.org 2022-06-29 9:11 ` rguenth at gcc dot gnu.org 2022-06-29 15:48 ` segher at gcc dot gnu.org 2022-07-08 13:56 ` [Bug target/106101] [12/13 Regression] ICE in reg_bitfield_target_p since r12-4428-g147ed0184f403b marxin at gcc dot gnu.org 2022-07-14 10:02 ` krebbel at gcc dot gnu.org 2022-07-19 11:53 ` krebbel at gcc dot gnu.org 2022-08-24 6:46 ` krebbel at gcc dot gnu.org 2022-08-24 11:57 ` segher at gcc dot gnu.org 2022-08-25 12:40 ` cvs-commit at gcc dot gnu.org 2022-08-25 13:02 ` krebbel at gcc dot gnu.org 2022-08-25 13:55 ` krebbel at gcc dot gnu.org [this message] 2022-08-25 15:03 ` segher at gcc dot gnu.org 2023-01-17 15:25 ` [Bug target/106101] [12 " rguenth at gcc dot gnu.org 2023-01-17 15:26 ` rguenth at gcc dot gnu.org 2023-01-23 7:58 ` cvs-commit at gcc dot gnu.org 2023-03-01 13:28 ` rguenth at gcc dot gnu.org 2023-10-10 14:29 ` fw at gcc dot gnu.org 2023-10-10 17:36 ` pinskia at gcc dot gnu.org 2023-10-10 17:39 ` pinskia at gcc dot gnu.org 2023-10-11 6:46 ` fw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-106101-4-797ojurRCc@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).