[Bug lto/106118] New: lto-plugin/lto-plugin.c: -pthread not passed to AM_LDFLAGS

[Bug lto/106118] New: lto-plugin/lto-plugin.c: -pthread not passed to AM_LDFLAGS

[pexu@gcc-bugzilla.mail.kapsi.fi]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106118

            Bug ID: 106118
           Summary: lto-plugin/lto-plugin.c: -pthread not passed to
                    AM_LDFLAGS
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: lto
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pexu@gcc-bugzilla.mail.kapsi.fi
                CC: marxin at gcc dot gnu.org
  Target Milestone: ---

Created attachment 53216
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53216&action=edit
move -pthread from LDFLAGS to AM_LDFLAGS (prior autoreconf)

Hi.

"lto-plugin: make claim_file_handler thread-safe" [1] uses LDFLAGS="-pthread"
at configure.ac.  Unfortunately, LDFLAGS is not passed from configure to the
Makefile recipe that links liblto_plugin.la.

Perhaps just move -pthread to AM_LDFLAGS at Makefile.in?  AC_CHECK_HEADER does
not use LDFLAGS anyway.  It is implicitly used by other checks but I wonder if
that just makes things more misleading (a missing pthread library, that is).

Also, it seems that pretty much every library has a different way of checking
and setting -pthread, -lpthread et. al.

[1]
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=2669cae081c852bc8bde1647d671aa66930cc556

[Bug lto/106118] lto-plugin/lto-plugin.c: -pthread not passed to AM_LDFLAGS

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106118

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-06-28
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Thanks for the fix, please send the patch to gcc-patches mailing list.

[Bug lto/106118] lto-plugin/lto-plugin.c: -pthread not passed to AM_LDFLAGS

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106118

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:51debf7f857dddfb4dd2493867d2648041e7d8de

commit r13-1377-g51debf7f857dddfb4dd2493867d2648041e7d8de
Author: Pekka Seppänen <pexu@gcc.mail.kapsi.fi>
Date:   Tue Jun 28 17:14:09 2022 +0300

    lto: pass -pthread to AM_LDFLAGS [PR 106118]

    Move -pthread from configure.ac to Makefile.in so that it is passed to
AM_LDFLAGS.

            PR lto/106118

    lto-plugin/ChangeLog:

            * configure.ac: Move -pthread from here...
            * Makefile.am: ...to here.
            * configure: Regenerate.
            * Makefile.in: Likewise.

[Bug lto/106118] lto-plugin/lto-plugin.c: -pthread not passed to AM_LDFLAGS

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106118

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Should be fixed now.

[Bug lto/106118] lto-plugin/lto-plugin.c: -pthread not passed to AM_LDFLAGS

[unlvsur at live dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106118

cqwrteur <unlvsur at live dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |unlvsur at live dot com

--- Comment #4 from cqwrteur <unlvsur at live dot com> ---
(In reply to Martin Liška from comment #3)
> Should be fixed now.

This patch is just wrong. Since windows simply does not provide libpthread.a

you have win32, posix, and mcf 3 kinds of threads.

Plus a lot of single-thread targets.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106170