[Bug analyzer/106184] New: gcc/analyzer/sm-fd.cc:545: ordering problem ?

[Bug analyzer/106184] New: gcc/analyzer/sm-fd.cc:545: ordering problem ?

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106184

            Bug ID: 106184
           Summary: gcc/analyzer/sm-fd.cc:545: ordering problem ?
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

I just did a gcc trunk build with clang. It said:

gcc/analyzer/sm-fd.cc:545:7: warning: field 'm_invalid' will be initialized
after field 'm_valid_read_write' [-Wreorder-ctor]

I suggest conforming with standard practice in C++.

[Bug analyzer/106184] gcc/analyzer/sm-fd.cc:545: ordering problem ?

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106184

David Binderman <dcb314 at hotmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mir at gcc dot gnu.org

--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
Adding author.

[Bug analyzer/106184] gcc/analyzer/sm-fd.cc:545: ordering problem ?

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106184

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Immad Mir <mir@gcc.gnu.org>:

https://gcc.gnu.org/g:3a6de2b2db500d76ac141a6ef85d336bd0f8430b

commit r13-1540-g3a6de2b2db500d76ac141a6ef85d336bd0f8430b
Author: Immad Mir <mirimmad@outlook.com>
Date:   Wed Jul 6 21:37:14 2022 +0530

    analyzer: reorder initialization of state m_invalid in sm-fd.cc [PR106184]

    This patch reorders the initialization of state m_invalid in sm-fd.cc
    so that the order of initializers is same as the ordering of the fields
    in the class decl.

    gcc/analyzer/ChangeLog:
            PR analyzer/106184
            * sm-fd.cc (fd_state_machine): Change ordering of initialization
            of state m_invalid so that the order of initializers is same as
            the ordering of the fields in the class decl.

    Signed-off-by: Immad Mir <mirimmad@outlook.com>

[Bug analyzer/106184] gcc/analyzer/sm-fd.cc:545: ordering problem ?

[mir at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106184

Immad Mir <mir at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Immad Mir <mir at gcc dot gnu.org> ---
The issue was resolved: see the commit above.