public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/106201] filesystem::directory_iterator is a borrowable range?
Date: Tue, 05 Jul 2022 14:11:33 +0000 [thread overview]
Message-ID: <bug-106201-4-MpVXtKPvpE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106201-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106201
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |redi at gcc dot gnu.org
Last reconfirmed| |2022-07-05
Keywords| |rejects-valid
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Patrick Welche from comment #0)
> Oh: https://cplusplus.github.io/LWG/issue3480
> But: it says "could be fixed ... (as libstdc++ currently does anyway)"
> Issue looks resolved?
That ensures that directory iterators are ranges, which is what your second
for_each call depends on.
The third one fails but not because of anything to do with borrowable ranges.
The problem is that the filesystem::swap(path&, path&) overload is found by ADL
and considered by overload resolution when checking whether
counted_iterator<filesystem::directory_iterator> is swappable. Overload
resolution checks whether the iterator can be converted to a path, which causes
constraint recursion.
The following change fixes this by removing filesystem::swap(path&, path&) from
the ADL result set:
--- a/libstdc++-v3/include/bits/fs_path.h
+++ b/libstdc++-v3/include/bits/fs_path.h
@@ -591,6 +591,8 @@ namespace __detail
return __result;
}
+ friend void swap(path& __lhs, path& __rhs) noexcept { __lhs.swap(__rhs); }
+
private:
enum class _Type : unsigned char {
_Multi = 0, _Root_name, _Root_dir, _Filename
@@ -732,8 +734,6 @@ namespace __detail
/// @{
/// @relates std::filesystem::path
- inline void swap(path& __lhs, path& __rhs) noexcept { __lhs.swap(__rhs); }
-
size_t hash_value(const path& __p) noexcept;
/// @}
next prev parent reply other threads:[~2022-07-05 14:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 13:28 [Bug libstdc++/106201] New: " prlw1 at cam dot ac.uk
2022-07-05 14:11 ` redi at gcc dot gnu.org [this message]
2022-07-05 15:23 ` [Bug libstdc++/106201] " redi at gcc dot gnu.org
2022-07-05 15:31 ` redi at gcc dot gnu.org
2022-07-05 15:59 ` redi at gcc dot gnu.org
2022-07-19 18:05 ` cvs-commit at gcc dot gnu.org
2022-07-21 14:51 ` prlw1 at cam dot ac.uk
2022-07-21 14:52 ` redi at gcc dot gnu.org
2022-07-21 14:54 ` redi at gcc dot gnu.org
2022-07-21 14:59 ` prlw1 at cam dot ac.uk
2022-11-22 12:33 ` redi at gcc dot gnu.org
2022-11-22 17:54 ` cvs-commit at gcc dot gnu.org
2022-11-22 21:49 ` cvs-commit at gcc dot gnu.org
2022-11-25 0:21 ` cvs-commit at gcc dot gnu.org
2023-10-04 9:18 ` redi at gcc dot gnu.org
2024-03-08 21:47 ` ppalka at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-106201-4-MpVXtKPvpE@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).