public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/106201] filesystem::directory_iterator is a borrowable range?
Date: Tue, 22 Nov 2022 21:49:06 +0000	[thread overview]
Message-ID: <bug-106201-4-mOLTfjtPdC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106201-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106201

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Jonathan Wakely
<redi@gcc.gnu.org>:

https://gcc.gnu.org/g:477b3f9d58589b3af7a5a7d038d78352ad66406e

commit r12-8927-g477b3f9d58589b3af7a5a7d038d78352ad66406e
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 22 18:15:56 2022 +0000

    libstdc++: Add workaround for fs::path constraint recursion [PR106201]

    This works around a compiler bug where overload resolution attempts
    implicit conversion to path in order to call a function with a path&
    parameter. Such conversion would produce a prvalue, which would not be
    able to bind to the lvalue reference anyway. Attempting to check the
    conversion causes a constraint recursion because the arguments to the
    path constructor are checked to see if they're iterators, which checks
    if they're swappable, which tries to use the swap function that
    triggered the conversion in the first place.

    This replaces the swap function with an abbreviated function template
    that is constrained with same_as<path> auto& so that the invalid
    conversion is never considered.

    libstdc++-v3/ChangeLog:

            PR libstdc++/106201
            * include/bits/fs_path.h (filesystem::swap(path&, path&)):
            Replace with abbreviated function template.
            * include/experimental/bits/fs_path.h (filesystem::swap):
            Likewise.
            * testsuite/27_io/filesystem/iterators/106201.cc: New test.
            * testsuite/experimental/filesystem/iterators/106201.cc: New test.

  parent reply	other threads:[~2022-11-22 21:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 13:28 [Bug libstdc++/106201] New: " prlw1 at cam dot ac.uk
2022-07-05 14:11 ` [Bug libstdc++/106201] " redi at gcc dot gnu.org
2022-07-05 15:23 ` redi at gcc dot gnu.org
2022-07-05 15:31 ` redi at gcc dot gnu.org
2022-07-05 15:59 ` redi at gcc dot gnu.org
2022-07-19 18:05 ` cvs-commit at gcc dot gnu.org
2022-07-21 14:51 ` prlw1 at cam dot ac.uk
2022-07-21 14:52 ` redi at gcc dot gnu.org
2022-07-21 14:54 ` redi at gcc dot gnu.org
2022-07-21 14:59 ` prlw1 at cam dot ac.uk
2022-11-22 12:33 ` redi at gcc dot gnu.org
2022-11-22 17:54 ` cvs-commit at gcc dot gnu.org
2022-11-22 21:49 ` cvs-commit at gcc dot gnu.org [this message]
2022-11-25  0:21 ` cvs-commit at gcc dot gnu.org
2023-10-04  9:18 ` redi at gcc dot gnu.org
2024-03-08 21:47 ` ppalka at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106201-4-mOLTfjtPdC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).