[Bug c++/106213] New: -Werror=deprecated-copy-dtor does not trigger warning and error

[Bug c++/106213] New: -Werror=deprecated-copy-dtor does not trigger warning and error

[federico.kircheis at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106213

            Bug ID: 106213
           Summary: -Werror=deprecated-copy-dtor does not trigger warning
                    and error
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: federico.kircheis at gmail dot com
  Target Milestone: ---

Consider

struct s{
    int* i;
    s();
    ~s(){ delete i;}
};


void bar(){
    s instance;
    s instance2 = instance;
}

This code compiles without warnings (gcc12) unless using
"-Wdeprecated-copy-dtor"

I would like it to be an error, so I've used "-Werror=deprecated-copy-dtor",
but
 * it does not trigger an error
 * it does not even trigger a warning(!!!)

The minimal example

https://godbolt.org/z/9b98Gsz1n

"-Werror -Wdeprecated-copy-dtor" works, but it might turn other warnings into
error, so it is not desirable.
Also the output of "-Werror -Wdeprecated-copy-dtor" mentions
"-Werror=deprecated-copy-dtor", so it should work.

A possible workaround is using "-Werror=deprecated-copy-dtor
-Wdeprecated-copy-dtor", but it should not be necessary.

Other flags, like Wreorder, works correclty: https://godbolt.org/z/zrr1GbK4K

As far as I've tested, "-Werror=deprecated-copy-dtor" never worked.

[Bug c++/106213] -Werror=deprecated-copy-dtor does not trigger warning and error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106213

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-07-06
           Keywords|                            |diagnostic
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug c++/106213] -Werror=deprecated-copy-dtor does not trigger warning and error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106213

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=94492

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
      /* Don't warn if the flag was disabled around the class definition
         (c++/94492).  */
      if (warning_enabled_at (DECL_SOURCE_LOCATION (decl),
                              OPT_Wdeprecated_copy))
        {
          auto_diagnostic_group d;
          tree ctx = DECL_CONTEXT (decl);
          tree other = classtype_has_depr_implicit_copy (ctx);
          int opt = (DECL_DESTRUCTOR_P (other)
                     ? OPT_Wdeprecated_copy_dtor
                     : OPT_Wdeprecated_copy);

[Bug c++/106213] -Werror=deprecated-copy-dtor does not trigger warning and error

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106213

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=88136

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Not a regression though, it was introduced when -Wdeprecated-copy-dtor was
introduced (PR 88136).

It is another one of these option oddities as  -Wdeprecated-copy-dtor also
enables -Wdeprecated-copy but sets the variable to 2 and such.

[Bug c++/106213] -Werror=deprecated-copy-dtor does not trigger warning and error

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106213

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
                 CC|                            |jason at gcc dot gnu.org

[Bug c++/106213] -Werror=deprecated-copy-dtor does not trigger warning and error

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106213

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:32bab8b57ddf0df727f5eaf99a77e70882c4e6e2

commit r14-6764-g32bab8b57ddf0df727f5eaf99a77e70882c4e6e2
Author: Jason Merrill <jason@redhat.com>
Date:   Tue Dec 19 15:33:07 2023 -0500

    opts: -Werror=foo always implies -Wfoo [PR106213]

    -Werror=foo implying -Wfoo wasn't working for -Wdeprecated-copy-dtor,
    because it is specified as the value 2 of warn_deprecated_copy, which shows
    up as CLVC_EQUAL, which is not one of the three var_types handled by
    control_warning_option.  It seems to me that we can just unconditionally
    handle_generated_option, and only have special argument handling for those
    types.

            PR c++/106213

    gcc/ChangeLog:

            * opts-common.cc (control_warning_option): Call
            handle_generated_option for all cl_var_types.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/depr-copy5.C: New test.

[Bug c++/106213] -Werror=deprecated-copy-dtor does not trigger warning and error

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106213

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.0
             Status|ASSIGNED                    |RESOLVED

--- Comment #5 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for GCC 14.