[Bug target/106282] New: m68k: Problem with thread-local storage and -mcpu=5206

[Bug target/106282] New: m68k: Problem with thread-local storage and -mcpu=5206

[sebastian.huber@embedded-brains.de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106282

            Bug ID: 106282
           Summary: m68k: Problem with thread-local storage and -mcpu=5206
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sebastian.huber@embedded-brains.de
  Target Milestone: ---

The following test code (derived from Newlib l64a.c):

_Thread_local char _tls_l64a_buf[8];

static const char R64_ARRAY[] =
"./0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";

char *
_l64a_r (long value)
{
  char *ptr;
  char *result;
  int i, index;
  unsigned long tmp = (unsigned long)value & 0xffffffff;

  result = _tls_l64a_buf;
  ptr = result;

  for (i = 0; i < 6; ++i)
    {
      if (tmp == 0)
        {
          *ptr = '\0';
          break;
        }

      index = tmp & (64 - 1);
      *ptr++ = R64_ARRAY[index];
      tmp >>= 6;
    }

  return result;
}

compiled with

m68k-rtems6-gcc -mcpu=5206 -O2 -c test.c

fails with

/tmp/ccO3QdNm.s: Assembler messages:
/tmp/ccO3QdNm.s:24: Error: syntax error -- statement `lea
(_tls_l64a_buf@TLSLE+6,%a0),%a0' ignored

[Bug target/106282] m68k: Problem with thread-local storage and -mcpu=5206 since r9-2326-gede9446c26a929

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106282

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-07-14
             Status|UNCONFIRMED                 |NEW
                 CC|                            |marxin at gcc dot gnu.org,
                   |                            |schwab at gcc dot gnu.org
            Summary|m68k: Problem with          |m68k: Problem with
                   |thread-local storage and    |thread-local storage and
                   |-mcpu=5206                  |-mcpu=5206 since
                   |                            |r9-2326-gede9446c26a929
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r9-2326-gede9446c26a929.

[Bug target/106282] [10/11/12/13 Regression] m68k: Problem with thread-local storage and -mcpu=5206 since r9-2326-gede9446c26a929

[jsm28 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106282

Joseph S. Myers <jsm28 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |10.5
            Summary|m68k: Problem with          |[10/11/12/13 Regression]
                   |thread-local storage and    |m68k: Problem with
                   |-mcpu=5206 since            |thread-local storage and
                   |r9-2326-gede9446c26a929     |-mcpu=5206 since
                   |                            |r9-2326-gede9446c26a929
                 CC|                            |jsm28 at gcc dot gnu.org

--- Comment #2 from Joseph S. Myers <jsm28 at gcc dot gnu.org> ---
My glibc bot has been failing for ColdFire since some time between commits
79d38dd46e6b07e5a90ab25df1438eb0918eb475 and
f56d48b2471c388401174029324e1f4c4b84fcdb, with an assembler error building
libgomp (affinity-fmt.c) that looks just like the one in this bug.

affinity-fmt.s: Assembler messages:
affinity-fmt.s:4062: Error: syntax error -- statement `lea
(gomp_tls_data@TLSLE+8,%a0),%a0' ignored

https://sourceware.org/pipermail/libc-testresults/2022q4/010394.html

Although that's from October 2022, I expect it's the same underlying issue, and
just was latent building libgomp until some other change exposed it there.

Note: soft-float ColdFire now fails earlier in my bot, failing to build glibc
with bug 103370 (also an assembler error, also probably latent for some time
before being exposed by an unrelated change).

[Bug target/106282] [10/11/12/13 Regression] m68k: Problem with thread-local storage and -mcpu=5206 since r9-2326-gede9446c26a929

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106282

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug target/106282] [10/11/12/13 Regression] m68k: Problem with thread-local storage and -mcpu=5206 since r9-2326-gede9446c26a929

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106282

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andreas Schwab <schwab@gcc.gnu.org>:

https://gcc.gnu.org/g:55bc61a75a68d1a8d1e4df170b4beef1020f1e55

commit r13-6867-g55bc61a75a68d1a8d1e4df170b4beef1020f1e55
Author: Andreas Schwab <schwab@linux-m68k.org>
Date:   Sun Jul 17 23:35:05 2022 +0200

    m68k: handle TLS access with offset

    This reinstates FINAL_PRESCAN_INSN, and the calls in handle_move_double,
    so that access to TLS variables with offset are properly handled.

    gcc:
            PR target/106282
            * config/m68k/m68k.h (FINAL_PRESCAN_INSN): Define.
            * config/m68k/m68k.cc (m68k_final_prescan_insn): Define.
            (handle_move_double): Call it before handle_movsi.
            * config/m68k/m68k-protos.h: Declare it.

    gcc/testsuite:
            PR target/106282
            * gcc.target/m68k/tls-gd-off.c: New.
            * gcc.target/m68k/tls-ie-off.c: New.
            * gcc.target/m68k/tls-ld-off.c: New.
            * gcc.target/m68k/tls-ld-xtls-off.c: New.
            * gcc.target/m68k/tls-le-off.c: New.
            * gcc.target/m68k/tls-le-xtls-off.c: New.
            * gcc.target/m68k/tls-ld.c: Make pattern less strict.
            * gcc.target/m68k/tls-le.c: Likewise.

[Bug target/106282] [10/11/12/13 Regression] m68k: Problem with thread-local storage and -mcpu=5206 since r9-2326-gede9446c26a929

[schwab@linux-m68k.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106282

Andreas Schwab <schwab@linux-m68k.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |13.0

--- Comment #4 from Andreas Schwab <schwab@linux-m68k.org> ---
Fixed for 13.

[Bug target/106282] [11/12 Regression] m68k: Problem with thread-local storage and -mcpu=5206 since r9-2326-gede9446c26a929

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106282

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.