[Bug analyzer/106286] New: fd_diagnostic should implement get_meaning_for_state_change vfunc

[Bug analyzer/106286] New: fd_diagnostic should implement get_meaning_for_state_change vfunc

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106286

            Bug ID: 106286
           Summary: fd_diagnostic should implement
                    get_meaning_for_state_change vfunc
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: dmalcolm at gcc dot gnu.org
            Blocks: 106003
  Target Milestone: ---

A minor nit: I added pending_diagnostic::get_meaning_for_state_change after
Immad started working on sm-fd.cc; so fd_diagnostic currently fails to
implement the get_meaning_for_state_change vfunc.

It's used by the SARIF output.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106003
[Bug 106003] RFE: -fanalyzer could complain about misuse of file-descriptors

[Bug analyzer/106286] fd_diagnostic should implement get_meaning_for_state_change vfunc

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106286

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Compare with e.g.:
  gcc/testsuite/gcc.dg/analyzer/file-meaning-1.c
which tests this for the sm-file.cc

[Bug analyzer/106286] fd_diagnostic should implement get_meaning_for_state_change vfunc

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106286

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Immad Mir <mir@gcc.gnu.org>:

https://gcc.gnu.org/g:0f82c0ea8d86ee3bb404c460a04ff2ccfb56d2a0

commit r13-1860-g0f82c0ea8d86ee3bb404c460a04ff2ccfb56d2a0
Author: Immad Mir <mirimmad@outlook.com>
Date:   Wed Jul 27 19:16:36 2022 +0530

    analyzer: add get_meaning_for_state_change vfunc to fd_diagnostic in
sm-fd.cc [PR106286]

    This patch adds get_meaning_for_state_change vfunc to
    fd_diagnostic in sm-fd.cc which could be used by SARIF output.

    Lightly tested on x86_64 Linux.

    gcc/analyzer/ChangeLog:
            PR analyzer/106286
            * sm-fd.cc:
            (fd_diagnostic::get_meaning_for_state_change): New.

    gcc/testsuite/ChangeLog:
            PR analyzer/106286
            * gcc.dg/analyzer/fd-meaning.c: New test.

    Signed-off-by: Immad Mir <mirimmad@outlook.com>

[Bug analyzer/106286] fd_diagnostic should implement get_meaning_for_state_change vfunc

[mir at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106286

Immad Mir <mir at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mir at gcc dot gnu.org
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Immad Mir <mir at gcc dot gnu.org> ---
Issue resolved.