public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/106387] New: [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92
@ 2022-07-21 17:00 seurer at gcc dot gnu.org
  2022-07-22  7:02 ` [Bug tree-optimization/106387] " rguenth at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: seurer at gcc dot gnu.org @ 2022-07-21 17:00 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106387

            Bug ID: 106387
           Summary: [13 regression] ICE when building gcc after
                    r13-1764-g5f59d0f2d9fa92
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: seurer at gcc dot gnu.org
  Target Milestone: ---

g:5f59d0f2d9fa921c04d75c39592e603cfa2b1324, r13-1764-g5f59d0f2d9fa92 

This commit causes an ICE when building gcc on power 7 machines.  It works OK
on power 8 BE and LE and beyond.

/home/seurer/gcc/git/build/gcc-trunk/./gcc/xgcc
-B/home/seurer/gcc/git/build/gcc-trunk/./gcc/
-B/home/seurer/gcc/git/install/gcc-trunk/powerpc64-unknown-linux-gnu/bin/
-B/home/seurer/gcc/git/install/gcc-trunk/powerpc64-unknown-linux-gnu/lib/
-isystem
/home/seurer/gcc/git/install/gcc-trunk/powerpc64-unknown-linux-gnu/include
-isystem
/home/seurer/gcc/git/install/gcc-trunk/powerpc64-unknown-linux-gnu/sys-include 
  -g -O2 -m32 -O2  -g -O2 -DIN_GCC    -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wstrict-prototypes -Wmissing-prototypes -Wold-style-definition 
-isystem ./include   -fPIC -mlong-double-128 -mno-minimal-toc -g -DIN_LIBGCC2
-fbuilding-libgcc -fno-stack-protector   -fPIC -mlong-double-128
-mno-minimal-toc -I. -I. -I../../.././gcc
-I/home/seurer/gcc/git/gcc-trunk/libgcc
-I/home/seurer/gcc/git/gcc-trunk/libgcc/.
-I/home/seurer/gcc/git/gcc-trunk/libgcc/../gcc
-I/home/seurer/gcc/git/gcc-trunk/libgcc/../include
-I/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/dpd
-I/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber -DHAVE_CC_TLS   -o
decQuad.o -MT decQuad.o -MD -MP -MF decQuad.dep -c
/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/decQuad.c
during GIMPLE pass: slp
In file included from
/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/decQuad.h:92,
                 from
/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/decQuad.c:33:
/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/decBasic.c: In function
'__decQuadAdd':
/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/decQuadSymbols.h:6:20:
internal compiler error: tree check: expected ssa_name, have addr_expr in
copy_ssa_name_fn, at tree-ssanames.cc:710
    6 | #define decQuadAdd __decQuadAdd
      |                    ^~~~~~~~~~~~
/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/decQuad.c:76:36: note: in
expansion of macro 'decQuadAdd'
   76 | #define decFloatAdd                decQuadAdd
      |                                    ^~~~~~~~~~
/home/seurer/gcc/git/gcc-trunk/libgcc/../libdecnumber/decBasic.c:1112:12: note:
in expansion of macro 'decFloatAdd'
 1112 | decFloat * decFloatAdd(decFloat *result,
      |            ^~~~~~~~~~~
0x10268063 tree_check_failed(tree_node const*, char const*, int, char const*,
...)
        /home/seurer/gcc/git/gcc-trunk/gcc/tree.cc:8817
0x10f65417 tree_check(tree_node*, char const*, int, char const*, tree_code)
        /home/seurer/gcc/git/gcc-trunk/gcc/tree.h:3508
0x10f65417 copy_ssa_name_fn(function*, tree_node*, gimple*)
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-ssanames.cc:710
0x11de4b0b copy_ssa_name
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-ssanames.h:106
0x11de4b0b vectorizable_load
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-stmts.cc:10020
0x11df5b6b vect_transform_stmt(vec_info*, _stmt_vec_info*,
gimple_stmt_iterator*, _slp_tree*, _slp_instance*)
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-stmts.cc:11332
0x10fcdc17 vect_schedule_slp_node
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:7438
0x10fcdc17 vect_schedule_slp_node
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:7252
0x10fe3083 vect_schedule_scc
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:7633
0x10fe2e63 vect_schedule_scc
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:7614
0x10fe2e63 vect_schedule_scc
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:7614
0x10fe385b vect_schedule_slp(vec_info*, vec<_slp_instance*, va_heap, vl_ptr>
const&)
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:7750
0x10fe576f vect_slp_region
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:6056
0x10fe6777 vect_slp_bbs
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:6168
0x10fe6dd3 vect_slp_function(function*)
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vect-slp.cc:6256
0x10ff4327 execute
        /home/seurer/gcc/git/gcc-trunk/gcc/tree-vectorizer.cc:1532


commit 5f59d0f2d9fa921c04d75c39592e603cfa2b1324
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Jul 20 11:02:03 2022 +0200

    Improve SLP codegen, avoiding unnecessary TREE_ADDRESSABLE

    The following adjusts vectorizer code generation to avoid splitting
    out address increments for invariant addresses which causes objects
    to get TREE_ADDRESSABLE when not necessary.

        * tree-vect-data-refs.cc (bump_vector_ptr): Return an
        invariant updated address when the input was invariant.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug tree-optimization/106387] [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92
  2022-07-21 17:00 [Bug tree-optimization/106387] New: [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92 seurer at gcc dot gnu.org
@ 2022-07-22  7:02 ` rguenth at gcc dot gnu.org
  2022-07-22  7:33 ` cvs-commit at gcc dot gnu.org
  2022-07-22  7:34 ` rguenth at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-07-22  7:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106387

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Last reconfirmed|                            |2022-07-22

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.  The following should fix it:

diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc
index 01d982eea98..f582d238984 100644
--- a/gcc/tree-vect-stmts.cc
+++ b/gcc/tree-vect-stmts.cc
@@ -10017,7 +10017,10 @@ vectorizable_load (vec_info *vinfo,
                                 (NULL_TREE, BIT_AND_EXPR, ptr,
                                  build_int_cst
                                  (TREE_TYPE (ptr), -(HOST_WIDE_INT) align));
-                   ptr = copy_ssa_name (ptr, new_stmt);
+                   if (TREE_CODE (ptr) == SSA_NAME)
+                     ptr = copy_ssa_name (ptr, new_stmt);
+                   else
+                     ptr = make_ssa_name (TREE_TYPE (ptr), new_stmt);
                    gimple_assign_set_lhs (new_stmt, ptr);
                    vect_finish_stmt_generation (vinfo, stmt_info,
                                                 new_stmt, gsi);

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug tree-optimization/106387] [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92
  2022-07-21 17:00 [Bug tree-optimization/106387] New: [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92 seurer at gcc dot gnu.org
  2022-07-22  7:02 ` [Bug tree-optimization/106387] " rguenth at gcc dot gnu.org
@ 2022-07-22  7:33 ` cvs-commit at gcc dot gnu.org
  2022-07-22  7:34 ` rguenth at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2022-07-22  7:33 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106387

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:3c4af0f0549a07799d76e9e48d3d3bd85197b92a

commit r13-1793-g3c4af0f0549a07799d76e9e48d3d3bd85197b92a
Author: Richard Biener <rguenther@suse.de>
Date:   Fri Jul 22 09:00:37 2022 +0200

    tree-optimization/106387 - properly create SSA name for realigned load

    The following fixes an oversight triggering after the recent change
    to bump_vector_ptr.

            PR tree-optimization/106387
            * tree-vect-stmts.cc (vectorizable_load): Use make_ssa_name
            if ptr is not an SSA name.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug tree-optimization/106387] [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92
  2022-07-21 17:00 [Bug tree-optimization/106387] New: [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92 seurer at gcc dot gnu.org
  2022-07-22  7:02 ` [Bug tree-optimization/106387] " rguenth at gcc dot gnu.org
  2022-07-22  7:33 ` cvs-commit at gcc dot gnu.org
@ 2022-07-22  7:34 ` rguenth at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: rguenth at gcc dot gnu.org @ 2022-07-22  7:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106387

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Should be fixed.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-22  7:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 17:00 [Bug tree-optimization/106387] New: [13 regression] ICE when building gcc after r13-1764-g5f59d0f2d9fa92 seurer at gcc dot gnu.org
2022-07-22  7:02 ` [Bug tree-optimization/106387] " rguenth at gcc dot gnu.org
2022-07-22  7:33 ` cvs-commit at gcc dot gnu.org
2022-07-22  7:34 ` rguenth at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).