[Bug analyzer/106401] New: [13 Regression] ICE: in binding_cluster, at analyzer/store.cc:1110 with -fanalyzer

[Bug analyzer/106401] New: [13 Regression] ICE: in binding_cluster, at analyzer/store.cc:1110 with -fanalyzer

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106401

            Bug ID: 106401
           Summary: [13 Regression] ICE: in binding_cluster, at
                    analyzer/store.cc:1110 with -fanalyzer
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: analyzer
          Assignee: dmalcolm at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 53333
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53333&action=edit
reduced testcase

The original testcase (from openssl sources) had:
memcpy(c, ctext_ex, sizeof(ctext_ex) - 1);
and was failing with the same ICE

Compiler output:
$ x86_64-pc-linux-gnu-gcc -fanalyzer testcase.c 
during IPA pass: analyzer
testcase.c: In function 'main':
testcase.c:5:3: internal compiler error: in binding_cluster, at
analyzer/store.cc:1110
    5 |   __builtin_memcpy (v, a, -1);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
0x83fff9 ana::binding_cluster::binding_cluster(ana::region const*)
        /repo/gcc-trunk/gcc/analyzer/store.cc:1110
0x83fff9 ana::binding_cluster::binding_cluster(ana::region const*)
        /repo/gcc-trunk/gcc/analyzer/store.cc:1106
0x1794eca ana::region_model::get_initial_value_for_global(ana::region const*)
const
        /repo/gcc-trunk/gcc/analyzer/region-model.cc:2401
0x17ab1a4 ana::region_model::impl_call_memcpy(ana::call_details const&)
        /repo/gcc-trunk/gcc/analyzer/region-model-impl-calls.cc:526
0x179d4ff ana::region_model::on_call_pre(gcall const*,
ana::region_model_context*, bool*)
        /repo/gcc-trunk/gcc/analyzer/region-model.cc:1430
0x17a61a2 ana::region_model::on_stmt_pre(gimple const*, bool*, bool*,
ana::region_model_context*)
        /repo/gcc-trunk/gcc/analyzer/region-model.cc:1257
0x1774e58 ana::exploded_node::on_stmt(ana::exploded_graph&, ana::supernode
const*, gimple const*, ana::program_state*, ana::uncertainty_t*,
ana::path_context*)
        /repo/gcc-trunk/gcc/analyzer/engine.cc:1430
0x1777b39 ana::exploded_graph::process_node(ana::exploded_node*)
        /repo/gcc-trunk/gcc/analyzer/engine.cc:3828
0x1778afa ana::exploded_graph::process_worklist()
        /repo/gcc-trunk/gcc/analyzer/engine.cc:3271
0x177ae40 ana::impl_run_checkers(ana::logger*)
        /repo/gcc-trunk/gcc/analyzer/engine.cc:5863
0x177bde3 ana::run_checkers()
        /repo/gcc-trunk/gcc/analyzer/engine.cc:5937
0x176be48 execute
        /repo/gcc-trunk/gcc/analyzer/analyzer-pass.cc:87
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r13-1791-20220722100642-g1cc0e9a46e7-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/13.0.0/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r13-1791-20220722100642-g1cc0e9a46e7-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 13.0.0 20220722 (experimental) (GCC)

[Bug analyzer/106401] [13 Regression] ICE: in binding_cluster, at analyzer/store.cc:1110 with -fanalyzer

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106401

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.0

[Bug analyzer/106401] [13 Regression] ICE: in binding_cluster, at analyzer/store.cc:1110 with -fanalyzer since r13-1761-g68871a008e686dbe

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106401

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |marxin at gcc dot gnu.org
   Last reconfirmed|                            |2022-07-22
            Summary|[13 Regression] ICE: in     |[13 Regression] ICE: in
                   |binding_cluster, at         |binding_cluster, at
                   |analyzer/store.cc:1110 with |analyzer/store.cc:1110 with
                   |-fanalyzer                  |-fanalyzer since
                   |                            |r13-1761-g68871a008e686dbe
     Ever confirmed|0                           |1

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-1761-g68871a008e686dbe.

[Bug analyzer/106401] [13 Regression] ICE: in binding_cluster, at analyzer/store.cc:1110 with -fanalyzer since r13-1761-g68871a008e686dbe

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106401

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:0fb35a45a28c674d5d420528f7dec629e42b4850

commit r13-1806-g0fb35a45a28c674d5d420528f7dec629e42b4850
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Fri Jul 22 19:50:37 2022 -0400

    analyzer: fix ICE in binding_cluster ctor [PR106401]

    gcc/analyzer/ChangeLog:
            PR analyzer/106401
            * store.cc (binding_cluster::binding_cluster): Remove overzealous
            assertion; we're checking for tracked_p in
            store::get_or_create_cluster.

    gcc/testsuite/ChangeLog:
            PR analyzer/106401
            * gcc.dg/analyzer/memcpy-2.c: New test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

[Bug analyzer/106401] [13 Regression] ICE: in binding_cluster, at analyzer/store.cc:1110 with -fanalyzer since r13-1761-g68871a008e686dbe

[dmalcolm at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106401

David Malcolm <dmalcolm at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Should be fixed by the above commit.