[Bug middle-end/106492] New: ICE in #pragma omp for simd

[Bug middle-end/106492] New: ICE in #pragma omp for simd

[sandra at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106492

            Bug ID: 106492
           Summary: ICE in #pragma omp for simd
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sandra at gcc dot gnu.org
  Target Milestone: ---

This is similar to PR106449; adding the simd keyword to an existing omp for
test case causes an ICE related to incompatible types.

Test case is derived from g++.dg/gomp/pr95063.C:

// PR c++/95063

template <typename T>
struct S {
  T a : 12;
  S () : a(0)
  {
#pragma omp for simd linear(a)
    for (int k = 0; k < 64; ++k)
      a++;
  }
};
struct U {
  int a : 12;
  U () : a(0)
  {
#pragma omp for simd linear(a)
    for (int k = 0; k < 64; ++k)
      a++;
  }
};

S<int> s;
U u;

$ x86_64-none-linux-gnu-g++ -fopenmp pr95063.C -S
pr95063.C: In constructor 'U::U()':
pr95063.C:19:8: error: type mismatch in binary expression
   19 |       a++;
      |       ~^~
<unnamed-signed:12>

<unnamed-signed:12>

int

a = a + D.2648;
during GIMPLE pass: omplower
pr95063.C:19:8: internal compiler error: 'verify_gimple' failed
0x1295c9d verify_gimple_in_seq(gimple*)
        /path/to/gcc/tree-cfg.cc:5220
0x1167b60 execute_function_todo
        /path/to/gcc/passes.cc:2093
0x1167fdb execute_todo
        /path/to/gcc/passes.cc:2145
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug middle-end/106492] [OpenMP] ICE in #pragma omp for simd and bitfields

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106492

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-08-01
           Keywords|                            |ice-on-valid-code, openmp
             Status|UNCONFIRMED                 |NEW
                 CC|                            |burnus at gcc dot gnu.org,
                   |                            |jakub at gcc dot gnu.org
            Summary|ICE in #pragma omp for simd |[OpenMP] ICE in #pragma omp
                   |and bitfields               |for simd and bitfields
     Ever confirmed|0                           |1

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The ICE occurs for the second SIMD loop (in U::U()) – it compiles when
commenting the U::U()  loops out - but it still has an ICE with only the S::S()
body commented out.

 * * *

pr95063.C:19:8: error: type mismatch in binary expression
<unnamed-signed:12>
<unnamed-signed:12>
int

That's for 'a = a + D.2617;' - To show more context, this lines appears in the
following omplow dump (slightly edited). - The D.2617 variable is generated
before line 11738 in omp-low.cc's lower_omp_for where the type is  type =
fd.iter_type.


  #pragma omp for private(k.2) firstprivate(a) lastprivate(a)
  for (k.2 = 0; k.2 < 64; k.2 = k.2 + 1)
  {
    int D.2617;
    int D.2618;
    <unnamed-signed:12> a;
    int k;
    a = a + D.2617;   // <<< ICE here:
    k = 0;
    #pragma omp simd _looptemp_(D.2617) _looptemp_(D.2618) linear(k:1)
linear(a:1)
    for (k = 0; k < 64; k = k + 1)
      a.0 = a;
      a.1 = (<unnamed-unsigned:12>) a.0;
      D.2611 = a.1 + 1;
      a = (<unnamed-signed:12>) D.2611;
      #pragma omp continue (k, k)
      if (k == 64) goto <D.2620>; else goto <D.2619>;
      <D.2620>:
      a = a;
      <D.2619>:

[Bug middle-end/106492] [OpenMP] ICE in #pragma omp for simd and bitfields

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106492

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The following seems to fix it:

diff --git a/gcc/omp-low.cc b/gcc/omp-low.cc
index d73c165f029..1af18e92395 100644
--- a/gcc/omp-low.cc
+++ b/gcc/omp-low.cc
@@ -6244,7 +6244,8 @@ lower_rec_input_clauses (tree clauses, gimple_seq *ilist,
                        x = fold_build2 (POINTER_PLUS_EXPR,
                                         TREE_TYPE (x), x, t);
                      else
-                       x = fold_build2 (PLUS_EXPR, TREE_TYPE (x), x, t);
+                       x = fold_build2 (PLUS_EXPR, TREE_TYPE (x), x,
+                                        fold_convert (TREE_TYPE (x), t));
                    }

                  if ((OMP_CLAUSE_CODE (c) != OMP_CLAUSE_LINEAR

[Bug middle-end/106492] [OpenMP] ICE in #pragma omp for simd and bitfields

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106492

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Patch:
  https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599308.html

[Bug middle-end/106492] [OpenMP] ICE in #pragma omp for simd and bitfields

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106492

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:8a16b9f983824b6b9a25275cd23b6bba8c98b800

commit r13-1997-g8a16b9f983824b6b9a25275cd23b6bba8c98b800
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Aug 9 07:57:40 2022 +0200

    OpenMP: Fix folding with simd's linear clause [PR106492]

    gcc/ChangeLog:

            PR middle-end/106492
            * omp-low.cc (lower_rec_input_clauses): Add missing folding
            to data type of linear-clause list item.

    gcc/testsuite/ChangeLog:

            PR middle-end/106492
            * g++.dg/gomp/pr106492.C: New test.

[Bug middle-end/106492] [OpenMP] ICE in #pragma omp for simd and bitfields

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106492

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Tobias Burnus
<burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:68b8c55c7e7de8438ea97f600cdccac826b8e67d

commit r12-8678-g68b8c55c7e7de8438ea97f600cdccac826b8e67d
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Aug 9 07:57:40 2022 +0200

    OpenMP: Fix folding with simd's linear clause [PR106492]

    gcc/ChangeLog:

            PR middle-end/106492
            * omp-low.cc (lower_rec_input_clauses): Add missing folding
            to data type of linear-clause list item.

    gcc/testsuite/ChangeLog:

            PR middle-end/106492
            * g++.dg/gomp/pr106492.C: New test.

    (cherry picked from commit 8a16b9f983824b6b9a25275cd23b6bba8c98b800)