[Bug tree-optimization/106506] New: g++.dg/opt/pr94589-2.C FAILS after enabling floats in VRP

[Bug tree-optimization/106506] New: g++.dg/opt/pr94589-2.C FAILS after enabling floats in VRP

[aldyh at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106506

            Bug ID: 106506
           Summary: g++.dg/opt/pr94589-2.C FAILS after enabling floats in
                    VRP
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: aldyh at gcc dot gnu.org
                CC: amacleod at redhat dot com, jakub at gcc dot gnu.org
  Target Milestone: ---

As mentioned in this thread, enabling frange operators in range-op-float.cc
causes g++.dg/opt/pr94589-2.C to fail:

https://gcc.gnu.org/pipermail/gcc/2022-July/239207.html

I've marked it as XFAIL.

It's all yours Jakub ;-).

[Bug tree-optimization/106506] [13 Regression] g++.dg/opt/pr94589-2.C FAILS after enabling floats in VRP

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106506

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |missed-optimization, xfail
            Summary|g++.dg/opt/pr94589-2.C      |[13 Regression]
                   |FAILS after enabling floats |g++.dg/opt/pr94589-2.C
                   |in VRP                      |FAILS after enabling floats
                   |                            |in VRP
            Version|12.0                        |13.0
   Target Milestone|---                         |13.0

[Bug tree-optimization/106506] [13 Regression] g++.dg/opt/pr94589-2.C FAILS after enabling floats in VRP

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106506

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2022-08-10
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 53431
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=53431&action=edit
gcc13-pr106506.patch

Those 2 checks were just trying to be careful, the (phires & 1) == phires and
variants it is folded to of course make only sense for the -1/0/1/2 result
spaceship, for -1/0/1 one can just use comparisons of phires.  We only floating
point spaceship if nans aren't honored, so the 2 case is ignored, and if it is,
with Aldy's changes we can simplify the 2 case away from the phi but the
(phires & 1) == phires stayed.  It is safe to treat the phires comparison as
phires >= 0 even then.

[Bug tree-optimization/106506] [13 Regression] g++.dg/opt/pr94589-2.C FAILS after enabling floats in VRP

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106506

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:83e9bc792ef10d08bb952a961e8c6f567521d28d

commit r13-2032-g83e9bc792ef10d08bb952a961e8c6f567521d28d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Aug 12 13:40:43 2022 +0200

    phiopt: Remove unnecessary checks from spaceship_replacement [PR106506]

    Those 2 checks were just me trying to be extra careful, the
    (phires & 1) == phires and variants it is folded to of course make only
sense
    for the -1/0/1/2 result spaceship, for -1/0/1 one can just use comparisons
of
    phires.  We only floating point spaceship if nans aren't honored, so the
    2 case is ignored, and if it is, with Aldy's changes we can simplify the
    2 case away from the phi but the (phires & 1) == phires stayed.  It is safe
    to treat the phires comparison as phires >= 0 even then.

    2022-08-12  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/106506
            * tree-ssa-phiopt.cc (spaceship_replacement): Don't punt for
            is_cast or orig_use_lhs cases if phi_bb has 3 predecessors.

            * g++.dg/opt/pr94589-2.C: New test.

[Bug tree-optimization/106506] [13 Regression] g++.dg/opt/pr94589-2.C FAILS after enabling floats in VRP

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106506

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.