[Bug target/106543] New: *sge<u>_<X:mode><GPR:mode> uses operand 2 but there is no operand 2

[Bug target/106543] New: *sge<u>_<X:mode><GPR:mode> uses operand 2 but there is no operand 2

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106543

            Bug ID: 106543
           Summary: *sge<u>_<X:mode><GPR:mode> uses operand 2 but there is
                    no operand 2
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: riscv

This is definitely broken:
(define_insn "*sge<u>_<X:mode><GPR:mode>"
  [(set (match_operand:GPR           0 "register_operand" "=r")
        (any_ge:GPR (match_operand:X 1 "register_operand" " r")
                    (const_int 1)))]
  ""
  "slt%i2<u>\t%0,zero,%1"
  [(set_attr "type" "slt")
   (set_attr "mode" "<X:MODE>")])

%i2 is not valid here as there is no operand[2] .

[Bug target/106543] [10/11/12 Regression] *sge<u>_<X:mode><GPR:mode> uses operand 2 but there is no operand 2

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106543

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-03-22
      Known to work|                            |7.1.0
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
            Summary|*sge<u>_<X:mode><GPR:mode>  |[10/11/12 Regression]
                   |uses operand 2 but there is |*sge<u>_<X:mode><GPR:mode>
                   |no operand 2                |uses operand 2 but there is
                   |                            |no operand 2
      Known to fail|                            |8.1.0
   Target Milestone|---                         |10.5

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
It broke with r8-4335-g0791ac186bdddf so it is a regression as riscv was added
in GCC 7 and was correct then.

[Bug target/106543] [10/11/12/13 Regression] *sge<u>_<X:mode><GPR:mode> uses operand 2 but there is no operand 2

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106543

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug target/106543] [11/12/13/14 Regression] *sge<u>_<X:mode><GPR:mode> uses operand 2 but there is no operand 2

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106543

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|10.5                        |11.5

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 10 branch is being closed.

[Bug target/106543] [11/12/13/14 Regression] *sge<u>_<X:mode><GPR:mode> uses operand 2 but there is no operand 2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106543

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kito Cheng <kito@gcc.gnu.org>:

https://gcc.gnu.org/g:325d5dd53270fe8fd62b36c92c8f8b87c2938bf1

commit r14-9025-g325d5dd53270fe8fd62b36c92c8f8b87c2938bf1
Author: Kito Cheng <kito.cheng@sifive.com>
Date:   Fri Feb 16 17:27:24 2024 +0800

    RISC-V: Fix *sge<u>_<X:mode><GPR:mode> pattern

    *sge<u>_<X:mode><GPR:mode> pattern has referenced operand[2] which is
    invalid...it should just use `slti<u>` rather than `slti%i2<u>`.

    gcc/ChangeLog:

            PR target/106543
            * config/riscv/riscv.md (*sge<u>_<X:mode><GPR:mode>): Fix asm
            pattern.