public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/106545] New: peephole.md seems like it should not exist
@ 2022-08-06  4:59 pinskia at gcc dot gnu.org
  2022-08-10 22:47 ` [Bug target/106545] " vineetg at rivosinc dot com
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2022-08-06  4:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106545

            Bug ID: 106545
           Summary: peephole.md seems like it should not exist
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---
            Target: riscv

There is one peephole2 in there for:
Simplify (unsigned long)(unsigned int)a << const

But that should really be handled in generic code in simplify-rtx/combine
already.
If it is not, then it should be added.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/106545] peephole.md seems like it should not exist
  2022-08-06  4:59 [Bug target/106545] New: peephole.md seems like it should not exist pinskia at gcc dot gnu.org
@ 2022-08-10 22:47 ` vineetg at rivosinc dot com
  2023-05-19  5:02 ` pinskia at gcc dot gnu.org
  2023-05-19  5:14 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: vineetg at rivosinc dot com @ 2022-08-10 22:47 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106545

Vineet Gupta <vineetg at rivosinc dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vineetg at rivosinc dot com

--- Comment #1 from Vineet Gupta <vineetg at rivosinc dot com> ---
How do I assign this to myself, can this only be done by maintainers ?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/106545] peephole.md seems like it should not exist
  2022-08-06  4:59 [Bug target/106545] New: peephole.md seems like it should not exist pinskia at gcc dot gnu.org
  2022-08-10 22:47 ` [Bug target/106545] " vineetg at rivosinc dot com
@ 2023-05-19  5:02 ` pinskia at gcc dot gnu.org
  2023-05-19  5:14 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-05-19  5:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106545

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |vineetg at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-05-19
     Ever confirmed|0                           |1

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Vineet Gupta from comment #1)
> How do I assign this to myself, can this only be done by maintainers ?

You use your @gcc.gnu.org email.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug target/106545] peephole.md seems like it should not exist
  2022-08-06  4:59 [Bug target/106545] New: peephole.md seems like it should not exist pinskia at gcc dot gnu.org
  2022-08-10 22:47 ` [Bug target/106545] " vineetg at rivosinc dot com
  2023-05-19  5:02 ` pinskia at gcc dot gnu.org
@ 2023-05-19  5:14 ` pinskia at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-05-19  5:14 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106545

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note I see XTheadMemPair code has been added to peephole.md which is good to
have it away. 
But again the first peephole is also handled differently already via
zero_extendsidi2_shifted which was added in r11-745-gd5cdcd5cf2b292 but it was
not until r13-4907-g2e886eef7f2b5a when we started to optimizing the following
code:
unsigned long f(unsigned long a)
{
  a <<= 32;
  a >>= 32;
  a <<= 10;
  return a;
}

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-05-19  5:14 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-06  4:59 [Bug target/106545] New: peephole.md seems like it should not exist pinskia at gcc dot gnu.org
2022-08-10 22:47 ` [Bug target/106545] " vineetg at rivosinc dot com
2023-05-19  5:02 ` pinskia at gcc dot gnu.org
2023-05-19  5:14 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).