public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "sebastian.huber@embedded-brains.de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/106680] Test gcc.target/powerpc/bswap64-4.c fails on 32-bit BE
Date: Sat, 20 Jan 2024 11:33:07 +0000	[thread overview]
Message-ID: <bug-106680-4-B6HeSI6FTU@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-106680-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106680

--- Comment #6 from Sebastian Huber <sebastian.huber@embedded-brains.de> ---
It seems that the change

commit acc727cf02a1446dc00f8772f3f479fa3a508f8e
Author: Kewen Lin <linkw@linux.ibm.com>
Date:   Tue Dec 27 04:13:07 2022 -0600

    rs6000: Rework option -mpowerpc64 handling [PR106680]

causes a regression for -mcpu=e6500 -m32, for example:

gcc -fpreprocessed -O2 -S -mcpu=e6500 -m32 -S imfs_add_node.c.67.s
imfs_add_node.c.67.i

diff -u imfs_add_node.c.67.s.good.e2acff49fb2962b921bf8b73984b89878b61492c
imfs_add_node.c.67.s.bad.acc727cf02a1446dc00f8772f3f479fa3a508f8e
--- imfs_add_node.c.67.s.good.e2acff49fb2962b921bf8b73984b89878b61492c 
2024-01-20 12:15:15.143182571 +0100
+++ imfs_add_node.c.67.s.bad.acc727cf02a1446dc00f8772f3f479fa3a508f8e  
2024-01-20 12:11:46.804204927 +0100
@@ -52,8 +52,8 @@
        bne- 0,.L4
 .L2:
        mr 4,29
-       addi 3,1,8
        li 5,24
+       addi 3,1,8
        bl rtems_filesystem_eval_path_start
        lis 9,IMFS_node_clone@ha
        lwz 10,20(3)
@@ -63,12 +63,12 @@
        cmpw 0,10,9
        beq- 0,.L24
        li 4,134
-       addi 3,1,8
+       li 3,0
        bl rtems_filesystem_eval_path_error
 .L9:
        li 31,-1
 .L10:
-       addi 3,1,8
+       li 3,0
        bl rtems_filesystem_eval_path_cleanup
 .L1:
        lwz 0,116(1)
@@ -93,7 +93,7 @@
        lwz 9,12(31)
        li 8,96
        lhz 10,16(31)
-       addi 3,1,8
+       li 3,0
        stw 8,24(1)
        stw 9,8(1)
        stw 10,12(1)
@@ -105,7 +105,7 @@
        cmpwi 0,9,0
        beq- 0,.L9
        li 4,22
-       addi 3,1,8
+       li 3,0
        bl rtems_filesystem_eval_path_error
        b .L9
        .p2align 4,,15
@@ -129,12 +129,9 @@
        stw 9,0(10)
        stw 10,4(9)
        bl _Timecounter_Getbintime
-       lwz 10,64(1)
-       lwz 11,68(1)
-       stw 10,40(30)
-       stw 11,44(30)
-       stw 10,48(30)
-       stw 11,52(30)
+       ld 9,64(1)
+       std 9,40(30)
+       std 9,48(30)
        b .L10
        .cfi_endproc
 .LFE351:

For the call to rtems_filesystem_eval_path_cleanup() the register 3 should
point to a structure on the stack. Correct is:

-       addi 3,1,8

Wrong is:

+       li 3,0

It seems that for the -mcpu=e6500 the -m32 option has not the right effect and
some 64-bit instructions are generated, for example ld and std plus the wrong
function parameters.

  parent reply	other threads:[~2024-01-20 11:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-106680-4@http.gcc.gnu.org/bugzilla/>
2022-08-29  8:52 ` linkw at gcc dot gnu.org
2022-12-27 10:14 ` cvs-commit at gcc dot gnu.org
2023-01-04  5:21 ` linkw at gcc dot gnu.org
2024-01-20 11:27 ` sebastian.huber@embedded-brains.de
2024-01-20 11:33 ` sebastian.huber@embedded-brains.de [this message]
2024-02-05 12:54 ` linkw at gcc dot gnu.org
2024-02-05 13:01 ` sebastian.huber@embedded-brains.de
2024-02-05 13:03 ` linkw at gcc dot gnu.org
2024-02-05 13:08 ` sebastian.huber@embedded-brains.de
2024-02-05 13:24 ` linkw at gcc dot gnu.org
2024-02-05 13:30 ` linkw at gcc dot gnu.org
2024-02-05 13:38 ` sebastian.huber@embedded-brains.de
2024-02-07 14:08 ` sebastian.huber@embedded-brains.de

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-106680-4-B6HeSI6FTU@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).